From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95613 invoked by alias); 20 Feb 2018 08:25:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 95604 invoked by uid 89); 20 Feb 2018 08:25:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: mx2.suse.de Received: from mx2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 20 Feb 2018 08:25:09 +0000 Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 8D2DAAD7D for ; Tue, 20 Feb 2018 08:25:07 +0000 (UTC) Subject: Re: [PATCH] Add limit for maximal alignment options (PR c/84310). From: =?UTF-8?Q?Martin_Li=c5=a1ka?= To: gcc-patches@gcc.gnu.org References: <0a23778f-57c2-5f01-4919-231ec7d001e0@suse.cz> Message-ID: Date: Tue, 20 Feb 2018 08:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <0a23778f-57c2-5f01-4919-231ec7d001e0@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg01148.txt.bz2 PING^1 On 02/12/2018 01:09 PM, Martin Liška wrote: > Hi. > > Following patch fixes 2 issues with -falign-*: > 1) when using -malign-x=16 (or corresponding -falign-* value) then ICE appeared > as code in final.c can deal just with limited alignment. > 2) thus I also documented and limited the maximum value of -falign-* options. > > Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. > i386.exp test-suite works fine on x86_64 machine. > > Ready to be installed? > Martin > > gcc/ChangeLog: > > 2018-02-09 Martin Liska > > PR c/84310 > PR target/79747 > * final.c (shorten_branches): Build align_tab array with one > more element. > * opts.c (finish_options): Add alignment option limit check. > (MAX_CODE_ALIGN): Likewise. > (MAX_CODE_ALIGN_VALUE): Likewise. > * doc/invoke.texi: Document maximum allowed option value for > all -falign-* options. > > gcc/testsuite/ChangeLog: > > 2018-02-12 Martin Liska > > PR c/84310 > PR target/79747 > * gcc.target/i386/pr84310.c: New test. > * gcc.target/i386/pr84310-2.c: Likewise. > --- > gcc/doc/invoke.texi | 4 ++++ > gcc/final.c | 4 ++-- > gcc/opts.c | 20 ++++++++++++++++++++ > gcc/testsuite/gcc.target/i386/pr84310-2.c | 10 ++++++++++ > gcc/testsuite/gcc.target/i386/pr84310.c | 8 ++++++++ > 5 files changed, 44 insertions(+), 2 deletions(-) > create mode 100644 gcc/testsuite/gcc.target/i386/pr84310-2.c > create mode 100644 gcc/testsuite/gcc.target/i386/pr84310.c > >