From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9A2903858D33 for ; Tue, 31 Jan 2023 22:48:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A2903858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675205290; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WkXty230YOPQLxC0na/dPqUDBS+tp5Bde65VNMwqD8E=; b=HDv4obQDxQ/VbBYY9iPweeflZ+yaumaK5h8Gm/8aypYsiLWUX64bA0zFGQv5BVZB4oxPB9 jqaMwHpR1pdKkSJu+ZgEv4uzGVXdvlUBOkzU+tg1oyHz2G1x7T22JyzWyH67T84Y8LTNng pUGnLTFw8Xe8S8lTcy5Ka/YvwwS69Xg= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-131-EYAlCQgOPdK35uNp-9bRXA-1; Tue, 31 Jan 2023 17:48:08 -0500 X-MC-Unique: EYAlCQgOPdK35uNp-9bRXA-1 Received: by mail-qv1-f72.google.com with SMTP id i17-20020a0cfcd1000000b005377f5ce3baso8954196qvq.10 for ; Tue, 31 Jan 2023 14:48:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WkXty230YOPQLxC0na/dPqUDBS+tp5Bde65VNMwqD8E=; b=moxMz9PKZRR1fTT3o5dIy5iXB339Lb0BG2ub1t7RGf+Pa6S8u1Jctu5v1L+U+euyKZ 3jjSbmt6sNWxYZgE5FmlnugHY+SghzimYXhg5NinbOiDP+iuQs0X9oGSfWBSX/R6XxtJ I5rmBPEXalHYkszFWXbxfjGi1KaUjv0EfTB1TLYlTrIx8CL9bUN/UpDOBqlbUQtwXOHu yabEYF2M034tQiCpJwaCG2g1xxZzhYqK1NxlCOrm5PF9fspCbYVDcUi7c6ZzbQoTyKB2 6kRV3hCsQG6jzksboBsscZi+zI2lvtbQfkh8V13vGA7d8/Oh13QIyhroidRvO1SE75l/ JAiQ== X-Gm-Message-State: AO0yUKUAR0Uxx9JOtWGalCrJFOV2w5jrGcLyMT+oNTiVInMUGkabVg0o pG/JERd5AhHOHSCOiqpBaXKVep/sBqHzYJX4aNY/7oz0U+xILDcldSBlXy+wHb5BLffP9nvcb/a WOvtwRMgb9inm72nmHg== X-Received: by 2002:a05:6214:d6b:b0:53a:e4de:3b7 with SMTP id 11-20020a0562140d6b00b0053ae4de03b7mr1707484qvs.0.1675205287645; Tue, 31 Jan 2023 14:48:07 -0800 (PST) X-Google-Smtp-Source: AK7set/+uoavlz+DHjENlfXQnUEIyxQmFOgmGvihvIa9fjB0m3wdRmvI06evTD3SaEIXbcspkXyo1Q== X-Received: by 2002:a05:6214:d6b:b0:53a:e4de:3b7 with SMTP id 11-20020a0562140d6b00b0053ae4de03b7mr1707453qvs.0.1675205287306; Tue, 31 Jan 2023 14:48:07 -0800 (PST) Received: from [192.168.1.108] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id o20-20020a05620a229400b0072835b8e4a8sm891389qkh.75.2023.01.31.14.48.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 14:48:06 -0800 (PST) Message-ID: Date: Tue, 31 Jan 2023 17:48:05 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] c++: ICE with -Wlogical-op [PR107755] To: Marek Polacek , GCC Patches References: <20230131204134.725217-1-polacek@redhat.com> From: Jason Merrill In-Reply-To: <20230131204134.725217-1-polacek@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/31/23 15:41, Marek Polacek wrote: > Here we crash in the middle end because warn_logical_operator calls > build_range_check which calls various fold_* functions and those > don't work too well when we're still processing template trees. For > instance here we crash because we're converting a RECORD_TYPE to bool. > At this point VIEW_CONVERT_EXPR(b) hasn't yet been converted > to Foo::operator bool (&b). > > I was excited to fix this with instantiation_dependent_expression_p > which can now be called from c-family/ as well, but the problem isn't > that the expression is dependent. So, p_t_d it is. > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? OK. > PR c++/107755 > > gcc/cp/ChangeLog: > > * call.cc (build_new_op): Don't call warn_logical_operator when > processing a template. > > gcc/testsuite/ChangeLog: > > * g++.dg/warn/Wlogical-op-4.C: New test. > --- > gcc/cp/call.cc | 2 +- > gcc/testsuite/g++.dg/warn/Wlogical-op-4.C | 23 +++++++++++++++++++++++ > 2 files changed, 24 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/g++.dg/warn/Wlogical-op-4.C > > diff --git a/gcc/cp/call.cc b/gcc/cp/call.cc > index 5715a7cd1de..f7c5d9da94b 100644 > --- a/gcc/cp/call.cc > +++ b/gcc/cp/call.cc > @@ -7335,7 +7335,7 @@ build_new_op (const op_location_t &loc, enum tree_code code, int flags, > case TRUTH_ORIF_EXPR: > case TRUTH_AND_EXPR: > case TRUTH_OR_EXPR: > - if (complain & tf_warning) > + if ((complain & tf_warning) && !processing_template_decl) > warn_logical_operator (loc, code, boolean_type_node, > code_orig_arg1, arg1, > code_orig_arg2, arg2); > diff --git a/gcc/testsuite/g++.dg/warn/Wlogical-op-4.C b/gcc/testsuite/g++.dg/warn/Wlogical-op-4.C > new file mode 100644 > index 00000000000..745c9117a3d > --- /dev/null > +++ b/gcc/testsuite/g++.dg/warn/Wlogical-op-4.C > @@ -0,0 +1,23 @@ > +// PR c++/107755 > +// { dg-do compile } > +// { dg-options "-Wlogical-op" } > + > +struct Foo > +{ > + operator bool() const { return false; } > +}; > + > +bool a; > +Foo b; > + > +template > +static bool Bar() > +{ > + return (true && (false ? a : b)); > + return (false || (false ? a : b)); > +} > + > +bool Baz() > +{ > + return Bar(); > +} > > base-commit: b2ec2504af77b35e748067eeb846821d12a6b6b4