From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id 64FBD3858422 for ; Tue, 23 Nov 2021 20:44:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 64FBD3858422 Received: by mail-pj1-x1035.google.com with SMTP id v23so462563pjr.5 for ; Tue, 23 Nov 2021 12:44:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to; bh=38Q+3PAu8DUGSaRlpTXNuKbwQvolKuFOlx9VoVCroV0=; b=nP9TZ02rqAAB34TgFzkNnpENuDPXSK9Kqb5XnEmQALOqh7T9syeRX/sZqrlWy8MltV GlyP/9rOIkrUgU+s7mRJnFCMlHtdAnb33L/qgmYsrEcXPjAE2kF59rfEhyq2Hu4BLAeQ JiX4yoHKhnhg6JYI94mWrmnj+r4aAALOfkO3o+OSTvZE02a5mB+ifWPwb2bnPpBoNjHo svXMPyl+DXvRDiEIStSXzNIh0yTwlwjahrLlrJODRSsSO3HRaLk3T/Wb7734NWmufDKi K9+/9teniMRez9Kl1uzQaTrb2uq+aDR3/tWYVOKrJMrhbAD+2gT/mmptxq8s+tJHZaY7 oewQ== X-Gm-Message-State: AOAM533DRGGJnBKFxVT3hhZyV6gghLdUqvE39ZtMG8SC3KdTXmqWP5NJ EWHrnqIhGg6H6GZamYZtXps= X-Google-Smtp-Source: ABdhPJwdwWT/V6MHUQ5Rm0/iU+YLTwfIzOVIkPJCIoC9g1H/dZxn+YjKWN6/5wfCsDt/KXeLDd1V6w== X-Received: by 2002:a17:90b:4c8b:: with SMTP id my11mr6876456pjb.96.1637700240490; Tue, 23 Nov 2021 12:44:00 -0800 (PST) Received: from [172.31.0.175] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id g9sm14558677pfj.160.2021.11.23.12.43.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Nov 2021 12:44:00 -0800 (PST) Message-ID: Date: Tue, 23 Nov 2021 13:43:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH] libcpp: Use [[likely]] conditionally Content-Language: en-US To: Christophe Lyon Cc: Christophe LYON , GCC Patches References: <20211122172235.19438-1-polacek@redhat.com> <01c229cd-8ce8-8057-c3b2-98260ee31ae4@gmail.com> <90c086c1-48f2-7df5-f5af-3bcd7e062b32@foss.st.com> <80552f43-bb51-4526-f06a-c4c4855d7073@gmail.com> From: Jeff Law In-Reply-To: X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Nov 2021 20:44:03 -0000 On 11/23/2021 1:34 PM, Christophe Lyon wrote: > > > On Tue, Nov 23, 2021 at 4:41 PM Jeff Law via Gcc-patches > wrote: > > > > On 11/23/2021 8:26 AM, Christophe LYON via Gcc-patches wrote: > > Hi! > > > > On 23/11/2021 01:26, Jeff Law via Gcc-patches wrote: > >> > >> > >> On 11/22/2021 10:22 AM, Marek Polacek via Gcc-patches wrote: > >>> Let's hide [[likely]] behind a macro, to suppress warnings if the > >>> compiler doesn't support it. > >>> > >>> Co-authored-by: Jonathan Wakely > >>> > >>> Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? > >>> > >>>     PR preprocessor/103355 > >>> > >>> libcpp/ChangeLog: > >>> > >>>     * lex.c: Use ATTR_LIKELY instead of [[likely]]. > >>>     * system.h (ATTR_LIKELY): Define. > >> OK > >> jeff > > > > > > This patch breaks the build when the host compiler is gcc-4.8.5, > > because __has_cpp_attribute is not defined. > Sigh.  I'd like to move to a more recent prereq if we could. > > > I don't know why we have such an old dependency indeed. > I am not requesting it, I just happen to have an old enough host > compiler so that I can check/complain when we accidentally > break the dependency :-) Probably the enterprise distros.  I suspect we'll be able to roll forward in 2-3 years... Jeff