From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by sourceware.org (Postfix) with ESMTP id 5CFDC3857B89 for ; Tue, 12 Dec 2023 08:13:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5CFDC3857B89 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5CFDC3857B89 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.140.110.172 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702368832; cv=none; b=w5ErBUpT4uXAEvvEXUKVNJnMfSsJSMKiGcfbkH6HZPkF0nqNbB9QXEAsXt7ClUAvXDBpjM3bfKdMxrokAlOFvDr/ZRy7Bp425tnEyZDTG3Ky4URR6BWfslMW6Xk7RoF5U4lX3k3wvXYpaZvRM6h3SGXR6ua2qLQs1JTMXrDG5Pg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702368832; c=relaxed/simple; bh=q+lK9GKIRSW6mbZOH1ZOe7PDceEcc+h9yy86dP1JbdE=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=APYe6Otv2fHJ8FL24FCRjUcz5PglBzgc1lAWvCbQPsEl/06+fw4EeFTbl0voyf+N9ovHxZsdUX8QteUiAR/j1qWt3jpDlFR1IzUfNm1l1N7lN61lZNlczX2gAfhlBhVkaI8v+fsiT/LFR5MK+fHciUVz6sCpX4Jj6w6N/3ksMdI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4545D143D; Tue, 12 Dec 2023 00:14:34 -0800 (PST) Received: from [10.57.75.194] (unknown [10.57.75.194]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 00EF13F5A1; Tue, 12 Dec 2023 00:13:46 -0800 (PST) Message-ID: Date: Tue, 12 Dec 2023 08:13:45 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] aarch64: enable mixed-types for aarch64 simdclones Content-Language: en-US To: Thomas Schwinge Cc: Jakub Jelinek , gcc-patches@gcc.gnu.org, Kyrylo Tkachov , richard.sandiford@arm.com References: <9322d3d7-5188-fd49-7902-74efa5d65da7@arm.com> <48784e1a-b3b3-4b89-8d59-9c25cb943856@arm.com> <6d99ea34-78df-4807-8e83-00695d729517@arm.com> <87cyvcs9fu.fsf@euler.schwinge.homeip.net> From: "Andre Vieira (lists)" In-Reply-To: <87cyvcs9fu.fsf@euler.schwinge.homeip.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,KAM_DMARC_NONE,KAM_DMARC_STATUS,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/12/2023 21:42, Thomas Schwinge wrote: > Hi Andre! > > On 2023-10-16T16:03:26+0100, "Andre Vieira (lists)" wrote: >> Just a minor update to the patch, I had missed the libgomp testsuite, so >> had to make some adjustments there too. > > Unfortunately, there appear to be a number of DejaGnu directive errors in > your test case changes -- do you not see those in your testing? I hadn't seen those... I wonder whether they don't show up if you do dg-cmp-results with just one -v, I have binned the build, but I'll rerun it and double check, may need to use '-v -v' instead. Thanks for letting me know. ..., and the following change also doesn't look quite right: > >> --- a/libgomp/testsuite/libgomp.fortran/declare-simd-1.f90 >> +++ b/libgomp/testsuite/libgomp.fortran/declare-simd-1.f90 >> @@ -1,5 +1,5 @@ >> ! { dg-do run { target vect_simd_clones } } >> -! { dg-options "-fno-inline" } >> +! { dg-options "-fno-inline -cpp -D__aarch64__" } > Yeah, that needs a target selector. Thanks!