From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id ED47C385B52D; Thu, 1 Dec 2022 04:52:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ED47C385B52D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B14JkMJ003143; Thu, 1 Dec 2022 04:52:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=4pHGzYRlczDa/Ku+3qDpCXRbvBUuzln2/4HnBcinPF4=; b=ImyIH0C6xWqPztou2/9JPXEiZdsSjAgM4REiNTu4dPKgSTK2EEA45ESlhXtBGEarSdGE f51PnyhRzxq62BO9PS3Gzg9ebirKkb0sg+Gz0u7RbAdCy/LDqcoBeqj1t6TGD3KDete6 te7TSmWMDCgM6onYcAFwin+ZAP+Ilc2IoRkoK5mECcRGlzRTSkXGj7fkatFkF/fAGWyq PP9J1lYoyNhE85mBCIRs3HbPgcXn0lQ9OvYq4LPHZ0lea3pIZXx/hMYTRfkmmJZUTaJu rPo58De5IY0gIut2XeKil5UBywaz0ieVc41PWMpffx8uk2Tcd3shAtkVPIAF8o4GI5su lg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3m6n57rnae-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Dec 2022 04:52:38 +0000 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2B14ULww006662; Thu, 1 Dec 2022 04:52:37 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3m6n57rn9w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Dec 2022 04:52:37 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 2B14qPSF016520; Thu, 1 Dec 2022 04:52:35 GMT Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by ppma04ams.nl.ibm.com with ESMTP id 3m3ae9es3v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 01 Dec 2022 04:52:35 +0000 Received: from d06av23.portsmouth.uk.ibm.com (d06av23.portsmouth.uk.ibm.com [9.149.105.59]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2B14qXdY61407544 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 1 Dec 2022 04:52:33 GMT Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 31A6BA404D; Thu, 1 Dec 2022 04:52:33 +0000 (GMT) Received: from d06av23.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9C30EA4040; Thu, 1 Dec 2022 04:52:31 +0000 (GMT) Received: from [9.200.99.34] (unknown [9.200.99.34]) by d06av23.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 1 Dec 2022 04:52:31 +0000 (GMT) Message-ID: Date: Thu, 1 Dec 2022 12:52:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH 3/3]rs6000: NFC no need copy_rtx in rs6000_emit_set_long_const and rs6000_emit_set_const Content-Language: en-US To: "Kewen.Lin" Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, gcc-patches@gcc.gnu.org References: <20221201013619.196004-1-guojiufu@linux.ibm.com> <20221201013619.196004-3-guojiufu@linux.ibm.com> From: Jiufu Guo In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 8gSGR_4usZgmiloCpuuqaCckdcct99Gq X-Proofpoint-ORIG-GUID: DQZIDpbg_gAqtP7mDd5EEbk56BxkS4gx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-01_03,2022-11-30_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 suspectscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 impostorscore=0 malwarescore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212010029 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Kewen, 在 12/1/22 11:31 AM, Kewen.Lin 写道: > Hi Jeff, > > on 2022/12/1 09:36, Jiufu Guo wrote: >> Hi, >> >> Function rs6000_emit_set_const/rs6000_emit_set_long_const are only invoked from >> two "define_split"s where the target operand is limited to gpc_reg_operand or >> int_reg_operand, then the operand must be REG_P. >> And in rs6000_emit_set_const/rs6000_emit_set_long_const, to create temp rtx, >> it is using code like "gen_reg_rtx({S|D}Imode)", it must also be REG_P. >> So, copy_rtx is not needed for temp and dest. >> >> This patch removes those "copy_rtx" for rs6000_emit_set_const and >> rs6000_emit_set_long_const. >> >> Bootstrap & regtest pass on ppc64{,le}. >> Is this ok for trunk? > > This patch is okay, thanks! For the subject, IMHO it's better to use something > like: "rs6000: Remove useless copy_rtx in rs6000_emit_set_{,long}_const". > I don't see NFC tag used much in GCC, though it's used a lot in llvm, but > anyway you can append (NFC)/[NFC] at the end if you like. :) > "rs6000: Remove useless copy_rtx in rs6000_emit_set_{,long}_const" is great! Thanks for your review and suggestions! BR, Jeff (Jiufu) > BR, > Kewen