From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id C6CDD3858D35 for ; Fri, 16 Jun 2023 10:10:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C6CDD3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-5169f614977so678169a12.3 for ; Fri, 16 Jun 2023 03:10:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686910233; x=1689502233; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8YeMpcJItHK5EOy6rTmB2QItq92vAx4DJMUEQ5uCM+Q=; b=PRYKesyApaqKP4JYpWXFsnlwFLzRu5TZJlshoIHz15haglAUWsolfWx7nnrOsC3jL3 IYyng/0Q6WoAVbK+GMYQixWOx5IIKWB+as/6UFNwEN/QA7xVWEvw9hvOSSoZN9j7Irsu B35dR8JbCTB9JwsL8Sd82Zx2c00GjI+EiPi3Bs/wsu75jB+mDADBvfFD9eDetqNlYJK7 wHa+5DIe5DU0frcJAo2eLNogLTz9gfxqZ48rlx+2mQq2/oNlW4dfm48LpK5M/Bgj8m4J VliWj1mtef1yqLuPuD47096jBwR6/wNIuBn5+B+kikyHuP2zMlb272wy8mdSdAMcVixh M0wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686910233; x=1689502233; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:cc:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8YeMpcJItHK5EOy6rTmB2QItq92vAx4DJMUEQ5uCM+Q=; b=ct4FY4zOn7FWMMcXqdFBhEduYTMTpyBdIv5c22ni2pyRu6lxQzrc38fZCsCFzL8Dk+ 822xBYxcgN7rlDA1XZUYwcXgoFlDlGQLmPspP1crUY90uPAuUmx1QvbCD41ZOyRHuBZm l/zcffJ1mVnJ9drVYt93rJwQVvhKKZmTKh7/dr3pQEzAAX6zmQMYylzR4Fh3l3EA+Xie XEjHmDxNIynRkkQTotbZ11dO1SZcamjH+D8hQFptkbmb6cx9Aj1A6I3IAzZLX6z6jV0A sre/1QbT8QBkHW0+yxAcf20j8FIOgH4LDuXYa70g9DX6F6ohH8OETNDLRaWC8/G0H05S 5QQw== X-Gm-Message-State: AC+VfDwY2aldXU8xc+dJjOaEGTQSqYd7kAcr7/NpmC8AHgeicbdaA7gr C9qge/b0Prgv3659cuaOCQw= X-Google-Smtp-Source: ACHHUZ7ETAjKa0VxirPGd7DSyIyvsf8FmxBAE+o3ktxSIg/KvJukrpLLyXSJjn59z2n8xt2QhFixYw== X-Received: by 2002:a17:907:6e10:b0:971:1717:207b with SMTP id sd16-20020a1709076e1000b009711717207bmr1484419ejc.35.1686910233148; Fri, 16 Jun 2023 03:10:33 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id h18-20020a1709063b5200b0097457363fc0sm10574187ejf.33.2023.06.16.03.10.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Jun 2023 03:10:32 -0700 (PDT) Message-ID: Date: Fri, 16 Jun 2023 12:10:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: rdapp.gcc@gmail.com, rguenther , "richard.sandiford" Subject: Re: [PATCH V4] VECT: Support LEN_MASK_{LOAD,STORE} ifn && optabs Content-Language: en-US To: "juzhe.zhong@rivai.ai" , gcc-patches References: <20230615131435.10323-1-juzhe.zhong@rivai.ai> From: Robin Dapp In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > <= (operand 2 + operand 4) are used." Sorry it's really minor (and my mistake) but it should be < and not <=, right? Mask index 0 is inactive when the length is 0. > +Perform a masked store (operand 2 + operand 4) Even more minor but as mentioned the "of" is still missing ;) Same with the <=. Regards Robin