From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gerald@pfeifer.com>
Received: from hamza.pair.com (hamza.pair.com [209.68.5.143])
 by sourceware.org (Postfix) with ESMTPS id 8E0FD3858C62
 for <gcc-patches@gcc.gnu.org>; Tue, 26 Jul 2022 11:32:49 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8E0FD3858C62
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=pfeifer.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=pfeifer.com
Received: from hamza.pair.com (localhost [127.0.0.1])
 by hamza.pair.com (Postfix) with ESMTP id 0C3CF33E74;
 Tue, 26 Jul 2022 07:32:49 -0400 (EDT)
Received: from [192.168.253.150] (213142097041.public.telering.at
 [213.142.97.41])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by hamza.pair.com (Postfix) with ESMTPSA id CD6FA33E82;
 Tue, 26 Jul 2022 07:32:47 -0400 (EDT)
Date: Tue, 26 Jul 2022 13:32:45 +0200 (CEST)
From: Gerald Pfeifer <gerald@pfeifer.com>
To: Lulu Cheng <chenglulu@loongson.cn>
cc: gcc-patches@gcc.gnu.org, xuchenghua@loongson.cn
Subject: Re: [PATCH][wwwdocs] gcc-13: Add loongarch '-mexplicit-relocs' support
In-Reply-To: <20220726072119.2910839-1-chenglulu@loongson.cn>
Message-ID: <cf188e3f-5251-6f0a-4959-fdc2193b1324@pfeifer.com>
References: <20220726072119.2910839-1-chenglulu@loongson.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
X-Scanned-By: mailmunge 3.09 on 209.68.5.143
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 26 Jul 2022 11:32:50 -0000

On Tue, 26 Jul 2022, Lulu Cheng wrote:
> +<h3 id="loongarch">LoongArch</h3>
> +<ul>
> +  <li>The option <code>-mexplicit-relocs</code> has been added, this indicates
> +  whether the <code>la.*</code> macro instructions will be generated when
> +  loading symbolic addresses.

How about making this "...has been added. It indicates..." or, if you
prefer one sentence "...has been added to indicate whether"?

> +  This feature requires binutils version 2.40 or later. If you want to use the
> +  older version of bintuils, add compiler parameters
> +  <code>-mno-explicit-relocs</code> at compile time.

"...older versions..." (or "...an older version...")

And I believe we can simplify and just say "...add <code>-mno-explicit..."

> +  <li>The method for calling global functions changed from
> +  <code>la.global + jirl</code> to <code>bl</code> when complied add
> +  <code>-fplt</code>.

Do you mean "compiled" instead of "complied"?

And maybe "compiled with"?

> +  <li>Enable option <code>-fsection-anchors</code> when <code>-O1</code> and
> +  more advanced optimization.

How about "<code>-fsection-anchors</code> is now enabled with 
<code>-O1</code> and above"?


If my suggestions make sense to you, please go ahead and commit with those
or variations thereof you may prefer. 

If you have any questions, please let me know and we'll sort things out
quickly.

Thank you,
Gerald