From: Jeff Law <jeffreyalaw@gmail.com>
To: "Martin Liška" <mliska@suse.cz>,
"Richard Biener" <richard.guenther@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
"Joseph S. Myers" <joseph@codesourcery.com>
Subject: Re: [PATCH] Fix handling of flag_rename_registers.
Date: Thu, 14 Oct 2021 08:27:48 -0600 [thread overview]
Message-ID: <cfa0de87-96bd-5f8e-1ded-72370c7bf19d@gmail.com> (raw)
In-Reply-To: <a1b59126-3774-6d61-1032-182a7ee67a62@suse.cz>
On 10/13/2021 4:02 AM, Martin Liška wrote:
>
>> works and that it is not somehow dependent on ordering? Otherwise we
>> have to
>> use EnabledBy(funroll-loops,funroll-all-loops) on frename-registers.
>> I guess the
>> EnabledBy doesn't work if the target decides to set flag_unroll_loop
>> in one of
>> its hooks rather than via its option table override? (as said, this
>> is all a mess...)
>
> It's a complete mess. The only override happens in
> rs6000_override_options_after_change. I think it can also utilize
> EnabledBy, but
> I would like to do it in a different patch.
So what's the preferred way to handle this? We're in the process of
evaluating -frename-registers on our target right now and subject to
verification of a couple issues, our inclination is to turn it on for
our target at -O2.
Jeff
next prev parent reply other threads:[~2021-10-14 14:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 12:17 Martin Liška
2021-10-12 13:37 ` Richard Biener
2021-10-12 14:03 ` Martin Liška
2021-10-12 15:11 ` Martin Liška
2021-10-13 8:39 ` Richard Biener
2021-10-13 10:02 ` Martin Liška
2021-10-13 11:49 ` Richard Biener
2021-10-14 14:27 ` Jeff Law [this message]
2021-10-15 15:27 ` Martin Liška
2021-10-16 19:51 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cfa0de87-96bd-5f8e-1ded-72370c7bf19d@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=mliska@suse.cz \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).