public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Yong <10walls@gmail.com>
To: Andrew Pinski <pinskia@gmail.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: testsuite: Fix pr55569.c excess errors
Date: Tue, 20 Dec 2022 23:32:15 +0000	[thread overview]
Message-ID: <cfd536a4-db17-e350-5389-650bc1fe0615@gmail.com> (raw)
In-Reply-To: <CA+=Sn1mnT1g-Pd_qL+a7Uhj6bcOMn2vhhF3Ly0itSnvmX_AD6A@mail.gmail.com>

On 12/20/22 16:55, Andrew Pinski wrote:
> On Tue, Dec 20, 2022 at 1:22 AM Jonathan Yong via Gcc-patches
> <gcc-patches@gcc.gnu.org> wrote:
>>
>> This fixes the following:
> 
> It is not obvious from the email, why this patch is needed but I
> figured it was due to LLP64 targets or some other targets where long
> is not the same size of the size_t type.
> I think this patch is good but I cannot approve it. The commit message
> should be improved to make a mention of LLP64 targets and long being a
> smaller size than size_t.
> 
> Thanks,
> Andrew
> 

You are right that this is for LLP64 win32. I will change the subject to 
"testsuite: Fix pr55569.c excess errors on LLP64"

This fixes the following on LLP64 mingw-w64 target:

Excess errors:

gcc/testsuite/gcc.c-torture/compile/pr55569.c:13:12: warning: overflow 
in conversion from 'long long unsigned int' to 'long int' changes value 
from '4611686018427387903' to '-1' [-Woverflow]

gcc/testsuite/gcc.c-torture/compile/pr55569.c:13:34: warning: iteration 
2147483647 invokes undefined behavior [-Waggressive-loop-optimizations]


  reply	other threads:[~2022-12-20 23:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20  9:22 Jonathan Yong
2022-12-20 16:55 ` Andrew Pinski
2022-12-20 23:32   ` Jonathan Yong [this message]
2022-12-20 18:55 ` Mike Stump

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cfd536a4-db17-e350-5389-650bc1fe0615@gmail.com \
    --to=10walls@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=pinskia@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).