From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 300F63858D20 for ; Tue, 14 Nov 2023 17:50:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 300F63858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 300F63858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699984221; cv=none; b=vTY20CP5KXYpCJizQC2nb/wd7ZNZ+bWuB/Ci8Qfi6x9IyFVWIdpr0e8rYQrpuQpVmiocrbkAg0Bcf5HdmBnw73qPkizQZXogFGbIeiwxsLVPMTndr/pTRrFkzyv4YB4Yfl4CbT6+e076wX5uDviv0jm3OG47UjdjpGoXOHqsq7c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699984221; c=relaxed/simple; bh=z7kMlnT0KF9nXXrMGevKiDdARuLy7GDlOoqEyFaojfA=; h=DKIM-Signature:From:To:Subject:Message-ID:Date:MIME-Version; b=Ixc8yaUHDHIBhFef347ayZ8HQKlsUaYi+cfIX1CB4xj1K57mfuF5G2/35R3zz7OHW+2x192YYFz1cLKv/1MfGegVXEswF3G/3hYHxG/FqbzjFMSksV0TTT9aQvvEs5y1Juc21FrzpxFTcE0Bsi30f3MpRV/JBf3c8diYH4sQ4YQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699984218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0tpOnYcpM2cYnQHx+Z6/1/RS2u1kZ+jclRm2vHMEk28=; b=T9ihWp+YEEdXADAJCYt9am9UoL2xe/VMk26lFr9Ua2IHp0w+gZc4/k9p007CtmuqqEZe45 3NhFOHO/m+d8dbhiVA6xdLqldchPwI5p6quxSg/mZNBvRKsp/93eih4pGysuuHwVnxETn+ tCJxhQ8u1B3UqIVtUJat5YOf6BaoBP0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-74-8cWlps2UNKW4C7ssHgbv3g-1; Tue, 14 Nov 2023 12:50:15 -0500 X-MC-Unique: 8cWlps2UNKW4C7ssHgbv3g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6F4408058EE; Tue, 14 Nov 2023 17:50:14 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C054D40C6EBA; Tue, 14 Nov 2023 17:50:12 +0000 (UTC) From: Florian Weimer To: gcc-patches@gcc.gnu.org Cc: jason@redhat.com, jeffreyalaw@gmail.com, joseph@codesourcery.com, sam@gentoo.org Subject: [PATCH v2 0/8] Turn some C warnings into errors by default Message-ID: X-From-Line: a5f0cb7b4691598e5f61634f08d162f5d7e90d38 Mon Sep 17 00:00:00 2001 Date: Tue, 14 Nov 2023 18:50:11 +0100 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This new series covers: -Wint-conversion -Wimplicit-function-declaration -Wimplicit-int -Wreturn-mismatch -Wincompatible-pointer-types -Wdeclaration-missing-parameter-type (new) There are now gcc.dg/permerror-*.c tests which track the graduation of warnings to errors. It turns out that pedpermerror was indeed unnecessary, and I can use permerror_opt directly (or DK_PERMERROR in case I call one of the low-level functions). While working on this I found out that -Wimplicit-int is mostly ineffective in system headers, so I fixed that for consistency. I also added a new -Wdeclaration-missing-parameter-type warning because missing types in parameter lists in function declarations (as opposed to old-style function definitions) are not covered by -Wimplicit-int, and probably shouldn't be because the omitted types are not necessarily int. This still depends on a couple of unreviewed patches. In particular, I do not want to break the AArch64 bootstrap, so the first patch looks like a blocker. [PATCH] aarch64: Avoid -Wincompatible-pointer-types warning in Linux unwinder [PATCH] aarch64: Call named function in gcc.target/aarch64/aapcs64/ice_1.c [PATCH] gm2: Add missing declaration of m2pim_M2RTS_Terminate to test Thanks, Florian Florian Weimer (8): Add tests for validating future C permerrors c: Turn int-conversion warnings into permerrors c: Turn -Wimplicit-function-declaration into a permerror c: Turn -Wimplicit-int into a permerror c: Do not ignore some forms of -Wimplicit-int in system headers c: Turn -Wreturn-mismatch into a permerror c: Turn -Wincompatible-pointer-types into a permerror c: Add new -Wdeclaration-missing-parameter-type permerror gcc/c-family/c.opt | 4 + gcc/c/c-decl.cc | 71 +++---- gcc/c/c-typeck.cc | 164 ++++++++------- gcc/doc/invoke.texi | 50 ++++- gcc/testsuite/c-c++-common/pr77624-1.c | 4 +- .../c-c++-common/spellcheck-reserved.c | 4 +- gcc/testsuite/gcc.dg/20030906-1.c | 2 +- gcc/testsuite/gcc.dg/20030906-1a.c | 21 ++ gcc/testsuite/gcc.dg/20030906-2.c | 2 +- gcc/testsuite/gcc.dg/20030906-2a.c | 21 ++ .../Wimplicit-function-declaration-c99-2.c | 7 + .../Wimplicit-function-declaration-c99.c | 2 +- gcc/testsuite/gcc.dg/Wimplicit-int-1.c | 2 +- gcc/testsuite/gcc.dg/Wimplicit-int-1a.c | 11 ++ gcc/testsuite/gcc.dg/Wimplicit-int-4.c | 2 +- gcc/testsuite/gcc.dg/Wimplicit-int-4a.c | 11 ++ .../gcc.dg/Wincompatible-pointer-types-2.c | 2 +- .../gcc.dg/Wincompatible-pointer-types-5.c | 10 + gcc/testsuite/gcc.dg/Wint-conversion-2.c | 2 +- gcc/testsuite/gcc.dg/Wint-conversion-3.c | 2 +- gcc/testsuite/gcc.dg/Wint-conversion-4.c | 14 ++ gcc/testsuite/gcc.dg/Wreturn-mismatch-1.c | 2 +- gcc/testsuite/gcc.dg/Wreturn-mismatch-1a.c | 40 ++++ gcc/testsuite/gcc.dg/Wreturn-mismatch-2.c | 2 +- gcc/testsuite/gcc.dg/Wreturn-mismatch-2a.c | 41 ++++ gcc/testsuite/gcc.dg/anon-struct-11.c | 5 +- gcc/testsuite/gcc.dg/anon-struct-11a.c | 111 +++++++++++ gcc/testsuite/gcc.dg/anon-struct-13.c | 2 +- gcc/testsuite/gcc.dg/anon-struct-13a.c | 76 +++++++ gcc/testsuite/gcc.dg/assign-warn-1.c | 2 +- gcc/testsuite/gcc.dg/assign-warn-4.c | 21 ++ .../gcc.dg/builtin-arith-overflow-4.c | 2 +- .../gcc.dg/builtin-arith-overflow-4a.c | 43 ++++ gcc/testsuite/gcc.dg/c23-qual-4.c | 6 +- gcc/testsuite/gcc.dg/dfp/composite-type-2.c | 58 ++++++ gcc/testsuite/gcc.dg/dfp/composite-type.c | 2 +- gcc/testsuite/gcc.dg/diag-aka-1.c | 2 +- gcc/testsuite/gcc.dg/diag-aka-1a.c | 29 +++ .../gcc.dg/diagnostic-range-bad-return-2.c | 52 +++++ .../gcc.dg/diagnostic-range-bad-return.c | 2 +- gcc/testsuite/gcc.dg/diagnostic-types-1.c | 2 +- gcc/testsuite/gcc.dg/diagnostic-types-2.c | 24 +++ gcc/testsuite/gcc.dg/enum-compat-1.c | 2 +- gcc/testsuite/gcc.dg/enum-compat-2.c | 32 +++ gcc/testsuite/gcc.dg/func-ptr-conv-1.c | 2 +- gcc/testsuite/gcc.dg/func-ptr-conv-2.c | 56 ++++++ gcc/testsuite/gcc.dg/gnu23-attr-syntax-2.c | 2 +- gcc/testsuite/gcc.dg/gnu23-attr-syntax-3.c | 17 ++ gcc/testsuite/gcc.dg/gomp/pr35738-2.c | 18 ++ gcc/testsuite/gcc.dg/gomp/pr35738.c | 2 +- gcc/testsuite/gcc.dg/init-bad-7.c | 2 +- gcc/testsuite/gcc.dg/init-bad-7a.c | 12 ++ gcc/testsuite/gcc.dg/init-excess-3.c | 4 +- gcc/testsuite/gcc.dg/missing-header-fixit-1.c | 2 +- .../gcc.dg/missing-header-fixit-1a.c | 37 ++++ gcc/testsuite/gcc.dg/missing-header-fixit-2.c | 2 +- .../gcc.dg/missing-header-fixit-2a.c | 31 +++ gcc/testsuite/gcc.dg/missing-header-fixit-4.c | 2 +- .../gcc.dg/missing-header-fixit-4a.c | 27 +++ gcc/testsuite/gcc.dg/missing-header-fixit-5.c | 2 +- .../gcc.dg/missing-header-fixit-5a.c | 42 ++++ .../gcc.dg/noncompile/incomplete-3.c | 2 +- gcc/testsuite/gcc.dg/noncompile/pr79758-2.c | 6 + gcc/testsuite/gcc.dg/noncompile/pr79758.c | 1 + gcc/testsuite/gcc.dg/overflow-warn-1.c | 4 +- gcc/testsuite/gcc.dg/overflow-warn-3.c | 4 +- gcc/testsuite/gcc.dg/param-type-mismatch-2.c | 187 ++++++++++++++++++ gcc/testsuite/gcc.dg/param-type-mismatch.c | 2 +- gcc/testsuite/gcc.dg/permerror-default.c | 85 ++++++++ gcc/testsuite/gcc.dg/permerror-fpermissive.c | 85 ++++++++ .../gcc.dg/permerror-gnu89-pedantic.c | 85 ++++++++ gcc/testsuite/gcc.dg/permerror-gnu89.c | 85 ++++++++ gcc/testsuite/gcc.dg/permerror-noerror.c | 85 ++++++++ gcc/testsuite/gcc.dg/permerror-pedantic.c | 85 ++++++++ gcc/testsuite/gcc.dg/permerror-system.c | 45 +++++ gcc/testsuite/gcc.dg/pointer-array-atomic-2.c | 60 ++++++ gcc/testsuite/gcc.dg/pointer-array-atomic.c | 2 +- gcc/testsuite/gcc.dg/pointer-array-quals-1.c | 6 +- gcc/testsuite/gcc.dg/pr105635-2.c | 11 ++ gcc/testsuite/gcc.dg/pr105635.c | 2 +- gcc/testsuite/gcc.dg/pr23075-2.c | 14 ++ gcc/testsuite/gcc.dg/pr23075.c | 2 +- gcc/testsuite/gcc.dg/pr29521-a.c | 15 ++ gcc/testsuite/gcc.dg/pr29521.c | 2 +- gcc/testsuite/gcc.dg/pr61162-2.c | 2 +- gcc/testsuite/gcc.dg/pr61162-3.c | 13 ++ gcc/testsuite/gcc.dg/pr61852.c | 4 +- gcc/testsuite/gcc.dg/pr67730-a.c | 11 ++ gcc/testsuite/gcc.dg/pr67730.c | 2 +- gcc/testsuite/gcc.dg/spec-barrier-3.c | 2 +- gcc/testsuite/gcc.dg/spec-barrier-3a.c | 13 ++ .../gcc.dg/spellcheck-identifiers-1a.c | 136 +++++++++++++ .../gcc.dg/spellcheck-identifiers-2.c | 2 +- .../gcc.dg/spellcheck-identifiers-2a.c | 33 ++++ .../gcc.dg/spellcheck-identifiers-3.c | 2 +- .../gcc.dg/spellcheck-identifiers-3a.c | 45 +++++ .../gcc.dg/spellcheck-identifiers-4.c | 2 +- .../gcc.dg/spellcheck-identifiers-4a.c | 10 + gcc/testsuite/gcc.dg/spellcheck-identifiers.c | 2 +- gcc/testsuite/gcc.dg/transparent-union-1.c | 2 +- gcc/testsuite/gcc.dg/transparent-union-1a.c | 85 ++++++++ .../gcc.target/aarch64/acle/memtag_2.c | 4 +- .../gcc.target/aarch64/acle/memtag_2a.c | 71 +++++++ .../sve/acle/general-c/ld1sh_gather_1.c | 2 +- .../aarch64/sve/acle/general-c/load_2.c | 4 +- .../aarch64/sve/acle/general-c/load_3.c | 2 +- .../acle/general-c/load_ext_gather_index_1.c | 2 +- .../load_ext_gather_index_restricted_1.c | 2 +- .../acle/general-c/load_ext_gather_offset_1.c | 4 +- .../acle/general-c/load_ext_gather_offset_2.c | 4 +- .../acle/general-c/load_ext_gather_offset_3.c | 4 +- .../acle/general-c/load_ext_gather_offset_4.c | 4 +- .../acle/general-c/load_ext_gather_offset_5.c | 4 +- .../load_ext_gather_offset_restricted_1.c | 4 +- .../load_ext_gather_offset_restricted_2.c | 4 +- .../load_ext_gather_offset_restricted_3.c | 4 +- .../load_ext_gather_offset_restricted_4.c | 4 +- .../aarch64/sve/acle/general-c/sizeless-1.c | 8 +- .../aarch64/sve/acle/general-c/sizeless-2.c | 8 +- .../aarch64/sve/acle/general-c/store_1.c | 8 +- .../aarch64/sve/acle/general-c/store_2.c | 10 +- .../acle/general-c/store_scatter_index_1.c | 8 +- .../store_scatter_index_restricted_1.c | 8 +- .../acle/general-c/store_scatter_offset_2.c | 8 +- .../store_scatter_offset_restricted_1.c | 8 +- .../aarch64/sve/acle/general/attributes_7.c | 28 +-- .../i386/sse2-bfloat16-scalar-typecheck.c | 4 +- .../i386/vect-bfloat16-typecheck_1.c | 4 +- .../i386/vect-bfloat16-typecheck_2.c | 4 +- .../gcc.target/powerpc/conditional-return.c | 2 +- 130 files changed, 2441 insertions(+), 257 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/20030906-1a.c create mode 100644 gcc/testsuite/gcc.dg/20030906-2a.c create mode 100644 gcc/testsuite/gcc.dg/Wimplicit-function-declaration-c99-2.c create mode 100644 gcc/testsuite/gcc.dg/Wimplicit-int-1a.c create mode 100644 gcc/testsuite/gcc.dg/Wimplicit-int-4a.c create mode 100644 gcc/testsuite/gcc.dg/Wincompatible-pointer-types-5.c create mode 100644 gcc/testsuite/gcc.dg/Wint-conversion-4.c create mode 100644 gcc/testsuite/gcc.dg/Wreturn-mismatch-1a.c create mode 100644 gcc/testsuite/gcc.dg/Wreturn-mismatch-2a.c create mode 100644 gcc/testsuite/gcc.dg/anon-struct-11a.c create mode 100644 gcc/testsuite/gcc.dg/anon-struct-13a.c create mode 100644 gcc/testsuite/gcc.dg/assign-warn-4.c create mode 100644 gcc/testsuite/gcc.dg/builtin-arith-overflow-4a.c create mode 100644 gcc/testsuite/gcc.dg/dfp/composite-type-2.c create mode 100644 gcc/testsuite/gcc.dg/diag-aka-1a.c create mode 100644 gcc/testsuite/gcc.dg/diagnostic-range-bad-return-2.c create mode 100644 gcc/testsuite/gcc.dg/diagnostic-types-2.c create mode 100644 gcc/testsuite/gcc.dg/enum-compat-2.c create mode 100644 gcc/testsuite/gcc.dg/func-ptr-conv-2.c create mode 100644 gcc/testsuite/gcc.dg/gnu23-attr-syntax-3.c create mode 100644 gcc/testsuite/gcc.dg/gomp/pr35738-2.c create mode 100644 gcc/testsuite/gcc.dg/init-bad-7a.c create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-1a.c create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-2a.c create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-4a.c create mode 100644 gcc/testsuite/gcc.dg/missing-header-fixit-5a.c create mode 100644 gcc/testsuite/gcc.dg/noncompile/pr79758-2.c create mode 100644 gcc/testsuite/gcc.dg/param-type-mismatch-2.c create mode 100644 gcc/testsuite/gcc.dg/permerror-default.c create mode 100644 gcc/testsuite/gcc.dg/permerror-fpermissive.c create mode 100644 gcc/testsuite/gcc.dg/permerror-gnu89-pedantic.c create mode 100644 gcc/testsuite/gcc.dg/permerror-gnu89.c create mode 100644 gcc/testsuite/gcc.dg/permerror-noerror.c create mode 100644 gcc/testsuite/gcc.dg/permerror-pedantic.c create mode 100644 gcc/testsuite/gcc.dg/permerror-system.c create mode 100644 gcc/testsuite/gcc.dg/pointer-array-atomic-2.c create mode 100644 gcc/testsuite/gcc.dg/pr105635-2.c create mode 100644 gcc/testsuite/gcc.dg/pr23075-2.c create mode 100644 gcc/testsuite/gcc.dg/pr29521-a.c create mode 100644 gcc/testsuite/gcc.dg/pr61162-3.c create mode 100644 gcc/testsuite/gcc.dg/pr67730-a.c create mode 100644 gcc/testsuite/gcc.dg/spec-barrier-3a.c create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-1a.c create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-2a.c create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-3a.c create mode 100644 gcc/testsuite/gcc.dg/spellcheck-identifiers-4a.c create mode 100644 gcc/testsuite/gcc.dg/transparent-union-1a.c create mode 100644 gcc/testsuite/gcc.target/aarch64/acle/memtag_2a.c base-commit: 69d69865a792a93cce2905617c53913769d0f260 prerequisite-patch-id: f46d6a56470ab459865ba2e45372d60e131b9ee2 prerequisite-patch-id: 7e0b407ec2bbd5e3b9c7ed1342b08d3677a65283 prerequisite-patch-id: 02e95117add6ada9d5cdb489399fb2e562db76e2 -- 2.41.0