From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by sourceware.org (Postfix) with ESMTPS id C0EF4389901A for ; Tue, 15 Nov 2022 16:37:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C0EF4389901A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1036.google.com with SMTP id m6-20020a17090a5a4600b00212f8dffec9so14372269pji.0 for ; Tue, 15 Nov 2022 08:37:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=sj6iB7xAueVHLNJY0RV+rpZ4tuDq28EdpwkuaRI1dqY=; b=Kb0JiHR9rNfqnUKYU0wEtoAPCnfHR8oIGLawfxTLkR57TY/7tadIdqrNPqq+2faGUB WTv2ibunEdYgQGP7o0ZLykG0a+NHzyJOKG0Ie0Sq25e52/hbhotxvywm9a9/MHpWNgFb FrF1fjLPl/1wVMFujgD6sMBAzQMbXX1W6xbmxzcu1hR41nMLS26MS5o6P1OMXzVPCyPa Ll75XYKO4J/4lvZ69A3eIl+aQk4OPQMFUThNNBjXQj1nrhzNCnquRbR/cgPk6aiKgLOM C7UBCtXFcc/bDbMyvoTRRVYAE8F+2I2mj3OZWchubd3AwZN6WvWl2gBWXOdF3ow+tMLt Acxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=sj6iB7xAueVHLNJY0RV+rpZ4tuDq28EdpwkuaRI1dqY=; b=kAbmvt45X/iB45+Zc1yr3uM2AzxoEv8B8HoxTiL/R+lA02DGnLG4EwU1W9qYb0hiSL UYxKPYvZSj5qvqarjuCfI1vx6xC5sprSYnVSYDtKnck/23TNP16BRJ66mszbOjbhIZ/F THMj4UXvJYLEwrYzAIp81sUKiU2sHMDzgBb0CUpQ+Qjbz0io9xnv7MPc57hP4S8LgRCU tcb70LSkby0yj+BtSnsl7vbkU+4thZyNqSFmT7HWkJM0LlPq4P73eUVAQIAesHPM1BLx sKrUEUMgsbCndxyuwgQhDfg1/KW1dK9x7gKcNgvUYPybexrn3vi/967DEmtv+O0YXbtH fe4w== X-Gm-Message-State: ANoB5pm9vYjENfKAUbzq6YDYkPkiU52XVmP+uuYJqpEEhH5Me2kusFG7 4z4kUmwR7LFTqdOIBEzm/pnQRpwHlI8= X-Google-Smtp-Source: AA0mqf5pd+giQvSizZVRjuT0/tEAXNmThljMIYVUtmHLvjtIkSWZ6PyuY6xFsfTOyrMHEOQFM0rbDw== X-Received: by 2002:a17:902:9a48:b0:186:7e8f:54dc with SMTP id x8-20020a1709029a4800b001867e8f54dcmr4674648plv.156.1668530264682; Tue, 15 Nov 2022 08:37:44 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id w138-20020a627b90000000b00545f5046372sm8877875pfc.208.2022.11.15.08.37.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 08:37:43 -0800 (PST) Content-Type: multipart/alternative; boundary="------------a073VqDL0u1OfEQOU7YZtI33" Message-ID: Date: Tue, 15 Nov 2022 09:37:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] RISC-V: Use .p2align for code-alignment Content-Language: en-US To: Philipp Tomsich , gcc-patches@gcc.gnu.org Cc: Christoph Muellner , Palmer Dabbelt , Vineet Gupta , Kito Cheng , Jeff Law References: <20221113204119.4061447-1-philipp.tomsich@vrull.eu> From: Jeff Law In-Reply-To: <20221113204119.4061447-1-philipp.tomsich@vrull.eu> X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------a073VqDL0u1OfEQOU7YZtI33 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/13/22 13:41, Philipp Tomsich wrote: > RISC-V's .p2align (currently) ignores the max-skip argument. As we > have experimental patches underway to address this in a > backwards-compatible manner, let's prepare GCC for the day when > binutils gets updated. > > gcc/ChangeLog: > > * config/riscv/riscv.h (ASM_OUTPUT_MAX_SKIP_ALIGN): Implement. What are the implications if we start using p2align immediately when the current (broken?) state of the assembler?  I'm pretty sure configure is already turning on HAVE_GAS_SKIP_P2ALIGN.  From a native risc-v build: auto-host.h:#define HAVE_GAS_MAX_SKIP_P2ALIGN 1 jeff --------------a073VqDL0u1OfEQOU7YZtI33--