From: Jeff Law <jeffreyalaw@gmail.com>
To: 钟居哲 <juzhe.zhong@rivai.ai>, gcc-patches <gcc-patches@gcc.gnu.org>
Cc: "pan2.li" <pan2.li@intel.com>, Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: [Committed] RISC-V: Suppress warning
Date: Sun, 21 Jan 2024 15:51:37 -0700 [thread overview]
Message-ID: <d04f3acc-e593-47f6-84b2-05c2f3d8b2cc@gmail.com> (raw)
In-Reply-To: <23E6260D5D91876E+202401200918412733588@rivai.ai>
On 1/19/24 18:18, 钟居哲 wrote:
> OK. I saw the other arguments there:
>
> tree fntype ATTRIBUTE_UNUSED,
> rtx libname ATTRIBUTE_UNUSED,
>
> So I leverage these and add ATTRIBUTE_UNUSED to 'fndecl'
>
> Maybe it's better remove all arguments for riscv_init_cumulative_args
> which are unused as you suggested.
Yea. The biggest problem with ATTRIBUTE_UNUSED is that it's a "may be
unused" and thus if the code changes it's sometimes left on an parameter
incorrectly. C++ allows us to specify a "is definitely unused" concept
by dropping the parameter's name, but leaving its type.
I just pushed the obvious patch to fixup that function signature. It
would be a nice easy task for someone to go through all of riscv*.cc and
clean those up after gcc-14 branches.
jeff
next prev parent reply other threads:[~2024-01-21 22:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-20 0:27 Juzhe-Zhong
2024-01-20 0:52 ` Jeff Law
2024-01-20 1:18 ` 钟居哲
2024-01-21 22:51 ` Jeff Law [this message]
2024-01-21 23:29 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d04f3acc-e593-47f6-84b2-05c2f3d8b2cc@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=pan2.li@intel.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).