From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by sourceware.org (Postfix) with ESMTPS id 1A7983858C00 for ; Mon, 19 Jun 2023 11:43:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A7983858C00 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-668709767b1so892128b3a.2 for ; Mon, 19 Jun 2023 04:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687175026; x=1689767026; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=LVo+TMfYlv6JKQFMFpvU+YCMcvvsLZY1erjwO0DTeZo=; b=AgBLOypfDg9x3Cfr9gSfvPkEvOalk8AqHiPGvgIpcAhuOG/7r1qmod/ya3sqO8fVaC pg+ZoYwVdqbcvyrkF05t66p2uz8PdcY0FPXrq8qMvGXK82/qs9yyNnaNFFk3NKz7GvT7 sSDrTc778RCSlosQXsSEFrgK9vL5OvF7eZ7GKzEqTegkY98F2+yLIPXC1cU3fwWaA4qV Kxu6l8YAhcIDnKZBzuxU2OW8w2iPWtFSnECNngrDTlktBL/hE+8dVrqndd5m7X5zuD+H EM3ILP3ODwUGmFDbMRhggldtVKutR+XoY2/DHa8rCKC9lPiPHHqvZcb4fsczUe6ic6p0 KE+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687175026; x=1689767026; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LVo+TMfYlv6JKQFMFpvU+YCMcvvsLZY1erjwO0DTeZo=; b=ZxnGyT/roLScdOF8oCo9IhFlWGBxKgo6D4zTQFEhz1Y4XZ1bGSIKk/+oPv2gy0HCz1 rIe31gv2pOtAxcXrGJrm68xuRSqFl3+W1yoppeAWOVviFVys3IFC+ooWfUJ9vEmPA1DY gb4QmizijLmJV2aj/WMFvL6imdOm1IGmFTillFCGhqF+CwqLJG9rwNvMHmLVBOJtmfaA HhPDxANpYs38ypxNuB9x69f9XKP5AMjcYkUxWlPbEoh+PEk8npqr/7E4MsJbGT5dtlao o8JZ6ppIx3bk0nJPt9W/oVFBavYd06C75SDibOGDrvO9jS+iNNFSBVWp6Ji0oEA9BoPF PVIA== X-Gm-Message-State: AC+VfDzLz/2h9EtpxtIywc0N26GVFdoQejRGKvYineWRuC2SsLcqs0MC lxYoiazTOaSmH7IBA1i6SK4= X-Google-Smtp-Source: ACHHUZ6dnIluOrTm+jQOcfBfFbcDPnx0nY1O9amLVi28ghDiiipsuSzs8B1xqqQscuUHgyeEyprrMw== X-Received: by 2002:a05:6a21:2c98:b0:110:32ba:33d8 with SMTP id ua24-20020a056a212c9800b0011032ba33d8mr7272481pzb.28.1687175025903; Mon, 19 Jun 2023 04:43:45 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id q4-20020a170902bd8400b001ab061e352bsm20186695pls.195.2023.06.19.04.43.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Jun 2023 04:43:45 -0700 (PDT) Message-ID: Date: Mon, 19 Jun 2023 05:43:43 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH V6] VECT: Support LEN_MASK_{LOAD,STORE} ifn && optabs Content-Language: en-US To: Robin Dapp , =?UTF-8?B?6ZKf5bGF5ZOy?= , gcc-patches Cc: "richard.sandiford" , rguenther References: <20230616102912.262207-1-juzhe.zhong@rivai.ai> <43e33266-e449-4ddf-4ea4-938dcd458665@gmail.com> <3c5cd2c6-8b65-6405-c8cf-b02b04c4cd88@gmail.com> From: Jeff Law In-Reply-To: <3c5cd2c6-8b65-6405-c8cf-b02b04c4cd88@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/19/23 00:56, Robin Dapp wrote: >>>> If the pattern is not allowed to fail, then what code enforces the bias >>>> argument's restrictions?  I don't see it in the generic expander code. >> >> I have no ideal since this is just copied from len_load/len_store which is >> s390 target dependent stuff. >> >> I have sent V7 patch with fixing doc by following your suggestion. >> > > We have: > > signed char > internal_len_load_store_bias (internal_fn ifn, machine_mode mode) > { > optab optab = direct_internal_fn_optab (ifn); > insn_code icode = direct_optab_handler (optab, mode); > > if (icode != CODE_FOR_nothing) > { > /* For now we only support biases of 0 or -1. Try both of them. */ > if (insn_operand_matches (icode, 3, GEN_INT (0))) > return 0; > if (insn_operand_matches (icode, 3, GEN_INT (-1))) > return -1; > } > > return VECT_PARTIAL_BIAS_UNSUPPORTED; Ah. That's not where I expected to find it. Thanks for pointing it out. Jeff