From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cross.elm.relay.mailchannels.net (cross.elm.relay.mailchannels.net [23.83.212.46]) by sourceware.org (Postfix) with ESMTPS id 06B263858D28 for ; Mon, 10 Jan 2022 23:55:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 06B263858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 9AA006C1C4E; Mon, 10 Jan 2022 23:55:21 +0000 (UTC) Received: from pdx1-sub0-mail-a306.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 5EEAA6C1BD1; Mon, 10 Jan 2022 23:55:21 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a306.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.124.238.73 (trex/6.4.3); Mon, 10 Jan 2022 23:55:21 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Print-Abaft: 1d32f7394123be30_1641858921480_935054696 X-MC-Loop-Signature: 1641858921480:1034201547 X-MC-Ingress-Time: 1641858921480 Received: from [192.168.1.174] (unknown [1.186.121.232]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a306.dreamhost.com (Postfix) with ESMTPSA id 4JXrKz623Hz1PV; Mon, 10 Jan 2022 15:55:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d=gotplt.org; s=gotplt.org; t=1641858920; bh=BCqBF1Z1q3XaVzooGIBhhZoAftc=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=xNWpFyUioC1jqYgVAh7Ul+kT3KmwkFciVVo/Hki/Dv46bep0ccwcO6NtH+DURsPqE EQ+rtc+AH+t6GSn2mYE09dbviwMoTyes0K0SPiGFiEnaepWeKGEEis2SiYd9iOJDsz FN6DbT+oNla5Yct51+dkrdjAPt2OSc1wHBtjc2C0= Message-ID: Date: Tue, 11 Jan 2022 05:25:14 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v5 1/4] tree-object-size: Support dynamic sizes in conditions Content-Language: en-US To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org References: <20211109190137.1107736-1-siddhesh@gotplt.org> <20211218123511.139456-1-siddhesh@gotplt.org> <20211218123511.139456-2-siddhesh@gotplt.org> <20220110103730.GD2646553@tucnak> From: Siddhesh Poyarekar In-Reply-To: <20220110103730.GD2646553@tucnak> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3030.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SBL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jan 2022 23:55:24 -0000 On 10/01/2022 16:07, Jakub Jelinek wrote: > You test the above with both possibilities. > >> + if (test_builtin_calloc_condphi (128, 1, 0) == 128) >> + FAIL (); > > But not this one, why? Also, it would be better to have > a != ... test rather than ==, if it is the VLA, then 128 * sizeof (struct { int a; char b; }) > ? I think I'll move the test_builtin_calloc_condphi test into the GIMPLE_CALL patch since that's where it becomes fully functional. Thanks, Siddhesh