* Re: pragma-eof.c
@ 2020-07-18 21:04 David Edelsohn
2020-07-18 21:11 ` pragma-eof.c Jakub Jelinek
0 siblings, 1 reply; 4+ messages in thread
From: David Edelsohn @ 2020-07-18 21:04 UTC (permalink / raw)
To: Hans-Peter Nilsson; +Cc: GCC Patches, Nathan Sidwell
H-P,
After your patch to the testsuite, the cpp/pragma-eof.c testcase is
failing on all targets. Would you please investigate and fix?
Thanks, David
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: pragma-eof.c
2020-07-18 21:04 pragma-eof.c David Edelsohn
@ 2020-07-18 21:11 ` Jakub Jelinek
2020-07-18 23:32 ` pragma-eof.c Hans-Peter Nilsson
2020-07-20 14:43 ` pragma-eof.c Nathan Sidwell
0 siblings, 2 replies; 4+ messages in thread
From: Jakub Jelinek @ 2020-07-18 21:11 UTC (permalink / raw)
To: David Edelsohn; +Cc: Hans-Peter Nilsson, GCC Patches, Nathan Sidwell
On Sat, Jul 18, 2020 at 05:04:56PM -0400, David Edelsohn via Gcc-patches wrote:
> H-P,
>
> After your patch to the testsuite, the cpp/pragma-eof.c testcase is
> failing on all targets. Would you please investigate and fix?
That is because the dg-error directive had line number of the last line
in the file (without EOL) and the added line changed that.
I've committed following, tested on x86_64-linux, committed to trunk as
obvious.
2020-07-18 Jakub Jelinek <jakub@redhat.com>
* c-c++-common/cpp/pragma-eof.c: Use .+3 instead of 6 in
dg-error.
--- gcc/testsuite/c-c++-common/cpp/pragma-eof.c.jj 2020-07-18 10:49:16.000000000 +0200
+++ gcc/testsuite/c-c++-common/cpp/pragma-eof.c 2020-07-18 23:08:31.565619340 +0200
@@ -1,7 +1,7 @@
/* { dg-require-effective-target fopenmp } */
/* { dg-additional-options -fopenmp } */
-/* { dg-error "expected" "" { target *-*-* } 6 } */
+/* { dg-error "expected" "" { target *-*-* } .+3 } */
/* Make sure we see pragma_eol even though lacking new line. *
/* no newline at end of file. */
#pragma omp parallel
\ No newline at end of file
Jakub
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: pragma-eof.c
2020-07-18 21:11 ` pragma-eof.c Jakub Jelinek
@ 2020-07-18 23:32 ` Hans-Peter Nilsson
2020-07-20 14:43 ` pragma-eof.c Nathan Sidwell
1 sibling, 0 replies; 4+ messages in thread
From: Hans-Peter Nilsson @ 2020-07-18 23:32 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: David Edelsohn, GCC Patches, Nathan Sidwell
On Sat, 18 Jul 2020, Jakub Jelinek wrote:
> On Sat, Jul 18, 2020 at 05:04:56PM -0400, David Edelsohn via Gcc-patches wrote:
> > H-P,
> >
> > After your patch to the testsuite, the cpp/pragma-eof.c testcase is
> > failing on all targets. Would you please investigate and fix?
>
> That is because the dg-error directive had line number of the last line
> in the file (without EOL) and the added line changed that.
>
> I've committed following, tested on x86_64-linux, committed to trunk as
> obvious.
Thanks! (Too fast for me. :)
brgds, H-P
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: pragma-eof.c
2020-07-18 21:11 ` pragma-eof.c Jakub Jelinek
2020-07-18 23:32 ` pragma-eof.c Hans-Peter Nilsson
@ 2020-07-20 14:43 ` Nathan Sidwell
1 sibling, 0 replies; 4+ messages in thread
From: Nathan Sidwell @ 2020-07-20 14:43 UTC (permalink / raw)
To: Jakub Jelinek, David Edelsohn; +Cc: Hans-Peter Nilsson, GCC Patches
On 7/18/20 5:11 PM, Jakub Jelinek wrote:
> On Sat, Jul 18, 2020 at 05:04:56PM -0400, David Edelsohn via Gcc-patches wrote:
>> H-P,
>>
>> After your patch to the testsuite, the cpp/pragma-eof.c testcase is
>> failing on all targets. Would you please investigate and fix?
>
> That is because the dg-error directive had line number of the last line
> in the file (without EOL) and the added line changed that.
>
> I've committed following, tested on x86_64-linux, committed to trunk as
> obvious.
>thanks jakub!
--
Nathan Sidwell
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-20 14:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-18 21:04 pragma-eof.c David Edelsohn
2020-07-18 21:11 ` pragma-eof.c Jakub Jelinek
2020-07-18 23:32 ` pragma-eof.c Hans-Peter Nilsson
2020-07-20 14:43 ` pragma-eof.c Nathan Sidwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).