From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 959DC3858C74 for ; Thu, 8 Sep 2022 18:01:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 959DC3858C74 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1C92633685; Thu, 8 Sep 2022 18:01:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1662660099; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lmxfW+eIJTRonNpRRcDZA1wN3IEDnufDxhOV55g9h5E=; b=hZGfgwVcmu/JP0g2k2MABqAP3U5JTXBJypRKPNZJo/PHaFSCtdyX551KoUVCUkZruHCEMK knp41uDd7HHAtgmuojI7tLLsX1kGqGHJXC2aXgcqNFklLg01HrlVCSfBFKDu7TkqHEdQA2 f/ANVVXfsN9Z2HBSkAgMHQzDoWH1W9o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1662660099; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lmxfW+eIJTRonNpRRcDZA1wN3IEDnufDxhOV55g9h5E=; b=clhxSpmkLzx9lnh2q2eLiSjDjhsD6e/97VNtf6gSylwPV/YToNvJMZhiCJMbcsv0bazIHG /t26aQll78q5MMCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F0B8F1322C; Thu, 8 Sep 2022 18:01:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id x7t4OAIuGmNpLQAAMHmgww (envelope-from ); Thu, 08 Sep 2022 18:01:38 +0000 Content-Type: multipart/mixed; boundary="------------bNos2AeMnIW4o9lZvOZF5F8E" Message-ID: Date: Thu, 8 Sep 2022 20:01:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH] optc-save-gen.awk: adjust generated array compare To: Jason Merrill , Chung-Lin Tang , gcc-patches Cc: Sandra Loosemore , Joseph Myers References: <56951572-c9b4-af2d-0e8b-9d47b87ba313@codesourcery.com> Content-Language: en-US From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_NONE,SPF_SOFTFAIL,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------bNos2AeMnIW4o9lZvOZF5F8E Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 9/8/22 18:23, Jason Merrill wrote: > It seems to me that the warning is pointing out that comparing the address of the array is nonsensical, and we should remove it and just have the memcmp. Yes, thanks for the pointer. We should always compare the array types with memcmp. Ready to be installed? Thanks, Martin --------------bNos2AeMnIW4o9lZvOZF5F8E Content-Type: text/x-patch; charset=UTF-8; name="0001-opts-always-compare-array-option-values-with-memcmp.patch" Content-Disposition: attachment; filename*0="0001-opts-always-compare-array-option-values-with-memcmp.pat"; filename*1="ch" Content-Transfer-Encoding: base64 RnJvbSAzMmU4NzViZjM5NWViYjA0NDRjZWQyODFjNWU3NjM0NDc0MTAwZmI4IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gTGlza2EgPG1saXNrYUBzdXNlLmN6PgpE YXRlOiBUaHUsIDggU2VwIDIwMjIgMjA6MDA6MzMgKzAyMDAKU3ViamVjdDogW1BBVENIXSBv cHRzOiBhbHdheXMgY29tcGFyZSBhcnJheSBvcHRpb24gdmFsdWVzIHdpdGggbWVtY21wCgpn Y2MvQ2hhbmdlTG9nOgoKCSogb3B0Yy1zYXZlLWdlbi5hd2s6IEFsd2F5cyBjb21wYXJlIGFy cmF5IG9wdGlvbiB2YWx1ZXMgd2l0aCBtZW1jbXAuCi0tLQogZ2NjL29wdGMtc2F2ZS1nZW4u YXdrIHwgMyArLS0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMiBkZWxldGlv bnMoLSkKCmRpZmYgLS1naXQgYS9nY2Mvb3B0Yy1zYXZlLWdlbi5hd2sgYi9nY2Mvb3B0Yy1z YXZlLWdlbi5hd2sKaW5kZXggMjMzZDFmYmI2MzcuLjQ5MDY1Y2VkMGIzIDEwMDY0NAotLS0g YS9nY2Mvb3B0Yy1zYXZlLWdlbi5hd2sKKysrIGIvZ2NjL29wdGMtc2F2ZS1nZW4uYXdrCkBA IC0xMDkzLDggKzEwOTMsNyBAQCBmb3IgKGkgPSAwOyBpIDwgbl90YXJnZXRfYXJyYXk7IGkr KykgewogCW5hbWUgPSB2YXJfdGFyZ2V0X2FycmF5W2ldCiAJc2l6ZSA9IHZhcl90YXJnZXRf YXJyYXlfc2l6ZVtpXQogCXR5cGUgPSB2YXJfdGFyZ2V0X2FycmF5X3R5cGVbaV0KLQlwcmlu dCAiICBpZiAocHRyMS0+IiBuYW1lIiAhPSBwdHIyLT4iIG5hbWUgIiI7Ci0JcHJpbnQgIiAg ICAgIHx8IG1lbWNtcCAocHRyMS0+IiBuYW1lICIsIHB0cjItPiIgbmFtZSAiLCAiIHNpemUg IiAqIHNpemVvZigiIHR5cGUgIikpKSIKKwlwcmludCAiICBpZiAobWVtY21wIChwdHIxLT4i IG5hbWUgIiwgcHRyMi0+IiBuYW1lICIsICIgc2l6ZSAiICogc2l6ZW9mKCIgdHlwZSAiKSkp IgogCXByaW50ICIgICAgcmV0dXJuIGZhbHNlOyI7CiB9CiBmb3IgKGkgPSAwOyBpIDwgbl90 YXJnZXRfdmFsOyBpKyspIHsKLS0gCjIuMzcuMwoK --------------bNos2AeMnIW4o9lZvOZF5F8E--