From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 2D4DA3858C55 for ; Sun, 3 Mar 2024 18:55:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D4DA3858C55 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=linux.vnet.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2D4DA3858C55 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709492113; cv=none; b=Nb5Y7Tt049JKvmGy9yYl0yENvpvD5zuZ2vi/lgVvujHQQA72+K2ZZ0gOnC08H0gPmcEYpKqFvC8GbkejzWxGDcvf2vpeBTe+AvvLv3cjmEITk/XtxE9P41ANUXhx25MQj44q2cXPN4o4oQh20kZU4T3IdU89C/mYzo+BtLsBJl8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709492113; c=relaxed/simple; bh=csinBEqA4dVkxYRZRtJfVfD3WbKSdtFQTSe2uHshyx8=; h=DKIM-Signature:Message-ID:Date:MIME-Version:To:From:Subject; b=JYVnaRc61prygrptiMokm+iYPR70flQ2E/fYYbzMCRFYQ/0M9TXEIziCFYuiKyrjLE4l1a3MTxIGP/OJa6xkp18PJ2pkjCYlsYeGg7wh5II40GxIJwbo7GPgSeiIdTCqIKjEVo8o2W5uzWDuiOHZ1lfPo8KjKE4NR3yPi9pWJfM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 423IRNin017990; Sun, 3 Mar 2024 18:55:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : to : from : subject : content-type : content-transfer-encoding; s=pp1; bh=/6ifEPDaJhSoLM9U06z9I8jHEBkzsaF9D6C8S0iQyco=; b=RnIip/MrMHKds2Mm+pAsbQqG60TyLAyKGtTROI1q0RnmPB9PRK6GZnlQVnlHAmF60ORz t42NP1JGwW3Z3vWbkBI5+Qs7J1276g5XbS2crBQQCDhbpUS2GxZ10gr92E3QsKhUjxX7 uOcbm1NOXERESZ1t6VmsT4MF/5FU9K7tEx6Ov1BMHUMT1oOx2RdPMvwgTTpdmNn73xT0 qO9eiU3QEBjVoTA8EUMxt3XWD5g5qqCma+wVy5eW9IdupMbvl38SkO4hO1Seshv9aDY/ 7efmaJr1tJMJqEcx8+iNiBeBC/9nhpKFNwSqw+NGueTc5iSwlhIsy+YxqG2u0xcXQMFk 3A== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wmxgbr9c0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 03 Mar 2024 18:55:10 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 423G2Qod026183; Sun, 3 Mar 2024 18:55:09 GMT Received: from smtprelay07.wdc07v.mail.ibm.com ([172.16.1.74]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3wmfenc2na-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 03 Mar 2024 18:55:09 +0000 Received: from smtpav04.dal12v.mail.ibm.com (smtpav04.dal12v.mail.ibm.com [10.241.53.103]) by smtprelay07.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 423It63T12976846 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 3 Mar 2024 18:55:08 GMT Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2571058065; Sun, 3 Mar 2024 18:55:06 +0000 (GMT) Received: from smtpav04.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 097AF5806A; Sun, 3 Mar 2024 18:55:04 +0000 (GMT) Received: from [9.195.39.29] (unknown [9.195.39.29]) by smtpav04.dal12v.mail.ibm.com (Postfix) with ESMTP; Sun, 3 Mar 2024 18:55:03 +0000 (GMT) Message-ID: Date: Mon, 4 Mar 2024 00:25:01 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: GCC Patches , "Kewen.Lin" , Segher Boessenkool , Michael Meissner , Peter Bergner From: jeevitha Subject: [PATCH V3] rs6000: Don't ICE when compiling the __builtin_vsx_splat_2di built-in [PR113950] Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: b8B3eKPp5ohvfokfA0PMRvyhk6SeFTD6 X-Proofpoint-ORIG-GUID: b8B3eKPp5ohvfokfA0PMRvyhk6SeFTD6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-03_09,2024-03-01_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 mlxlogscore=753 suspectscore=0 priorityscore=1501 mlxscore=0 spamscore=0 phishscore=0 clxscore=1015 adultscore=0 bulkscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403030159 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi All, The following patch has been bootstrapped and regtested on powerpc64le-linux. When we expand the __builtin_vsx_splat_2di function, we were allowing immediate value for second operand which causes an unrecognizable insn ICE. Even though the immediate value was forced into a register, it wasn't correctly assigned to the second operand. So corrected the assignment of op1 to operands[1]. 2024-02-29 Jeevitha Palanisamy gcc/ PR target/113950 * config/rs6000/vsx.md (vsx_splat_): Corrected assignment to operand1. gcc/testsuite/ PR target/113950 * gcc.target/powerpc/pr113950.c: New testcase. diff --git a/gcc/config/rs6000/vsx.md b/gcc/config/rs6000/vsx.md index 6111cc90eb7..f135fa079bd 100644 --- a/gcc/config/rs6000/vsx.md +++ b/gcc/config/rs6000/vsx.md @@ -4666,8 +4666,8 @@ rtx op1 = operands[1]; if (MEM_P (op1)) operands[1] = rs6000_force_indexed_or_indirect_mem (op1); - else if (!REG_P (op1)) - op1 = force_reg (mode, op1); + else + operands[1] = force_reg (mode, op1); }) (define_insn "vsx_splat__reg" diff --git a/gcc/testsuite/gcc.target/powerpc/pr113950.c b/gcc/testsuite/gcc.target/powerpc/pr113950.c new file mode 100644 index 00000000000..64566a580d9 --- /dev/null +++ b/gcc/testsuite/gcc.target/powerpc/pr113950.c @@ -0,0 +1,24 @@ +/* PR target/113950 */ +/* { dg-require-effective-target powerpc_vsx_ok } */ +/* { dg-options "-O1 -mvsx" } */ + +/* Verify we do not ICE on the following. */ + +void abort (void); + +int main () +{ + int i; + vector signed long long vsll_result, vsll_expected_result; + signed long long sll_arg1; + + sll_arg1 = 300; + vsll_expected_result = (vector signed long long) {300, 300}; + vsll_result = __builtin_vsx_splat_2di (sll_arg1); + + for (i = 0; i < 2; i++) + if (vsll_result[i] != vsll_expected_result[i]) + abort(); + + return 0; +}