From: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
To: Richard Henderson <richard.henderson@linaro.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Ramana Radhakrishnan <Ramana.Radhakrishnan@arm.com>,
"agraf@suse.de" <agraf@suse.de>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
James Greenhalgh <James.Greenhalgh@arm.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH, AArch64, v3 0/6] LSE atomics out-of-line
Date: Thu, 05 Sep 2019 09:51:00 -0000 [thread overview]
Message-ID: <d1691c20-c066-7d14-c63c-54bbf9e0409e@foss.arm.com> (raw)
In-Reply-To: <20181101214648.29432-1-richard.henderson@linaro.org>
Hi Richard,
On 11/1/18 9:46 PM, Richard Henderson wrote:
> From: Richard Henderson <rth@twiddle.net>
>
> Changes since v2:
> Â * Committed half of the patch set.
> Â * Split inline TImode support from out-of-line patches.
> Â * Removed the ST<OP> out-of-line functions, to match inline.
> Â * Moved the out-of-line functions to assembly.
>
> What I have not done, but is now a possibility, is to use a custom
> calling convention for the out-of-line routines. I now only clobber
> 2 (or 3, for TImode) temp regs and set a return value.
>
I think this patch series would be great to have for GCC 10!
I've rebased them on current trunk and fixed up a couple of minor
conflicts in my local tree.
After that, I've encountered a couple of issues with building a compiler
with these patches.
I'll respond to the individual patches that I think cause the trouble.
Thanks,
Kyrill
>
> r~
>
>
> Richard Henderson (6):
> Â aarch64: Extend %R for integer registers
> Â aarch64: Implement TImode compare-and-swap
> Â aarch64: Tidy aarch64_split_compare_and_swap
> Â aarch64: Add out-of-line functions for LSE atomics
> Â aarch64: Implement -matomic-ool
> Â Enable -matomic-ool by default
>
>  gcc/config/aarch64/aarch64-protos.h          | 13 +
>  gcc/common/config/aarch64/aarch64-common.c   |  6 +-
>  gcc/config/aarch64/aarch64.c                 | 211 ++++++++++++----
>  .../atomic-comp-swap-release-acquire.c       |  2 +-
>  .../gcc.target/aarch64/atomic-op-acq_rel.c   |  2 +-
>  .../gcc.target/aarch64/atomic-op-acquire.c   |  2 +-
>  .../gcc.target/aarch64/atomic-op-char.c      |  2 +-
>  .../gcc.target/aarch64/atomic-op-consume.c   |  2 +-
>  .../gcc.target/aarch64/atomic-op-imm.c       |  2 +-
>  .../gcc.target/aarch64/atomic-op-int.c       |  2 +-
>  .../gcc.target/aarch64/atomic-op-long.c      |  2 +-
>  .../gcc.target/aarch64/atomic-op-relaxed.c   |  2 +-
>  .../gcc.target/aarch64/atomic-op-release.c   |  2 +-
>  .../gcc.target/aarch64/atomic-op-seq_cst.c   |  2 +-
>  .../gcc.target/aarch64/atomic-op-short.c     |  2 +-
>  .../aarch64/atomic_cmp_exchange_zero_reg_1.c |  2 +-
>  .../atomic_cmp_exchange_zero_strong_1.c      |  2 +-
>  .../gcc.target/aarch64/sync-comp-swap.c      |  2 +-
>  .../gcc.target/aarch64/sync-op-acquire.c     |  2 +-
>  .../gcc.target/aarch64/sync-op-full.c        |  2 +-
>  libgcc/config/aarch64/lse-init.c             | 45 ++++
>  gcc/config/aarch64/aarch64.opt               |  4 +
>  gcc/config/aarch64/atomics.md                | 185 +++++++++++++-
>  gcc/config/aarch64/iterators.md              |  3 +
>  gcc/doc/invoke.texi                          | 14 +-
>  libgcc/config.host                           |  4 +
> Â libgcc/config/aarch64/lse.SÂ Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â | 238 ++++++++++++++++++
>  libgcc/config/aarch64/t-lse                  | 44 ++++
> Â 28 files changed, 717 insertions(+), 84 deletions(-)
> Â create mode 100644 libgcc/config/aarch64/lse-init.c
> Â create mode 100644 libgcc/config/aarch64/lse.S
> Â create mode 100644 libgcc/config/aarch64/t-lse
>
> --
> 2.17.2
>
next prev parent reply other threads:[~2019-09-05 9:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-01 21:47 Richard Henderson
2018-11-01 21:46 ` [PATCH, AArch64, v3 1/6] aarch64: Extend %R for integer registers Richard Henderson
2018-11-01 21:46 ` [PATCH, AArch64, v3 2/6] aarch64: Implement TImode compare-and-swap Richard Henderson
2018-11-01 21:47 ` [PATCH, AArch64, v3 6/6] Enable -matomic-ool by default Richard Henderson
2018-11-01 21:47 ` [PATCH, AArch64, v3 3/6] aarch64: Tidy aarch64_split_compare_and_swap Richard Henderson
2018-11-01 21:47 ` [PATCH, AArch64, v3 4/6] aarch64: Add out-of-line functions for LSE atomics Richard Henderson
2019-09-05 10:00 ` Kyrill Tkachov
2019-09-05 12:13 ` Richard Henderson
2019-09-05 12:53 ` Kyrill Tkachov
2018-11-01 21:47 ` [PATCH, AArch64, v3 5/6] aarch64: Implement -matomic-ool Richard Henderson
2019-09-05 9:56 ` Kyrill Tkachov
2019-09-05 12:17 ` Richard Henderson
2018-11-11 12:30 ` [PATCH, AArch64, v3 0/6] LSE atomics out-of-line Richard Henderson
2019-09-05 9:51 ` Kyrill Tkachov [this message]
2019-09-05 14:36 Wilco Dijkstra
2019-09-14 19:26 ` Richard Henderson
2019-09-16 11:59 ` Wilco Dijkstra
2019-09-17 8:40 ` Kyrill Tkachov
2019-09-17 10:55 ` Wilco Dijkstra
2019-09-17 21:11 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1691c20-c066-7d14-c63c-54bbf9e0409e@foss.arm.com \
--to=kyrylo.tkachov@foss.arm.com \
--cc=James.Greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Ramana.Radhakrishnan@arm.com \
--cc=agraf@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.henderson@linaro.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).