From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x635.google.com (mail-pl1-x635.google.com [IPv6:2607:f8b0:4864:20::635]) by sourceware.org (Postfix) with ESMTPS id E44363858C74 for ; Tue, 29 Aug 2023 13:44:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E44363858C74 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-1bf3a2f4528so34509765ad.2 for ; Tue, 29 Aug 2023 06:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693316670; x=1693921470; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lPQ35d1jrh219lx3iAUB1+KnZa2SarRQQ9oHqYO9fY4=; b=Gc3q7bjlnkpahvqrzxa/BCjWglLd+uXJmpA4rLgBFDrtp1f9Bpxkil9R2zMvxKfTrB FSmVv8skf3aEtiW6z3uVzOKYzwW/V1pcNz6eZWmiwLf6GB5Hn50Ew96M0avxKPLlKyfA lVmMR4UlGhtvhKS0xjm1IflWrz/vjeC2x3EqPSAx6jX6MbYFz8HV+mjU7+NTHk1gj6gG Ex0ttasb6YJa0JgviF96+ApWL7YzHFSQE3zbC968RmyX/hNvzuLkTHIWmKkw9uq15xBF uGnu7bVgyHpZZCVPoQ73jq2ATRJfInWk9ACTnR8UzScQVL30A0VLj7MjUCr2aPWISB9+ lCHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693316670; x=1693921470; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lPQ35d1jrh219lx3iAUB1+KnZa2SarRQQ9oHqYO9fY4=; b=VPfp9ZkN5ALOZHZ9SXssKo/npX8s69SWKpn9ap2bvuTVrA4p/gFPN+EB+/EGJqHRMR wBG9uN4p6hN7SYdg1nOayuAiewuMWNwNTspMqLwtwZxUp3QfzKrmsNpMrrfZiM97WAhJ 6aH9dq9Y0OuZxsgzKFXYdsQu8xOATNOzm648WxBwv8fmsx6pzSxmtloQ7GsfLWRddYx2 SSbESU62N36MMdHv+ZTnqcne9KE25OocopCQeVMhcma6aSQRpqrdxhh1lHT6OQlayurO rN1DX9stKjhI84CCcT/p/H/OzrujXbqdFUCfB6yodM+ISUr5WKKzup2CuAIdQrRJUTMU jnsQ== X-Gm-Message-State: AOJu0YxcXAbFEcBmPql/l17sceLHXPZd+oKiz/R9AQ9D2r0MOsMUMLM0 cHwmgatkDNV3PWwfPubJssY= X-Google-Smtp-Source: AGHT+IEpUB9dALw0jYUv+TYFbq/46JTknlAgqJtf2oQFsZclQ9N4MVPmKlxjCAFFFFc7F99HaOkHug== X-Received: by 2002:a17:902:c381:b0:1b8:4baa:52ff with SMTP id g1-20020a170902c38100b001b84baa52ffmr26974280plg.47.1693316670012; Tue, 29 Aug 2023 06:44:30 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id ja9-20020a170902efc900b001b3bf8001a9sm9499876plb.48.2023.08.29.06.44.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Aug 2023 06:44:29 -0700 (PDT) Message-ID: Date: Tue, 29 Aug 2023 07:44:28 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] RISC-V: Make PR 102957 tests more comprehensive Content-Language: en-US To: Tsukasa OI , Kito Cheng , Palmer Dabbelt , Andrew Waterman , Jim Wilson Cc: gcc-patches@gcc.gnu.org References: <3aa13843de038d960fdb3415f416243e43b376f2.1691745095.git.research_trasio@irq.a4lg.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/28/23 21:28, Tsukasa OI wrote: > From: Tsukasa OI > > Commit c283c4774d1c ("RISC-V: Throw compilation error for unknown > extensions") changed how do we handle unknown extensions and > commit 6f709f79c915a ("[committed] [RISC-V] Fix expected diagnostic messages > in testsuite") "fixed" test failures caused by that change (on pr102957.c, > by testing the error message after the first change). > > However, the latter change will partially break the original intent of PR > 102957 test case because we wanted to make sure that we can parse a valid > two-letter extension name. > > Fortunately, there is a valid two-letter extension name, 'Zk' (standard > scalar cryptography extension superset with NIST algorithm suite). > > This commit adds pr102957-2.c to make sure that there will be no errors if > we parse a valid two-letter extension name. > > gcc/testsuite/ChangeLog: > > * gcc.target/riscv/pr102957-2.c: New test case using the 'Zk' > extension to continue testing whether we can use valid two-letter > extensions. OK jeff