From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id B155C3858D35 for ; Wed, 31 Jan 2024 21:53:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B155C3858D35 Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B155C3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706738016; cv=none; b=gLFC+jRa8ZLbhIRvoMWl6Q5DgkYBqMHtRj2n1q+ouv4vi16ULIStYeEet+Tj2gcxS6abQ+4EDgTtnmZqVy1XYTqe1pteBe3vdpD9TU0DVYTt7NM7+2k5W/kvc1pqZF2BCkgZxRkjHGjyysOuVqe4wbu1eLBPkscueHueO3OPqZo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706738016; c=relaxed/simple; bh=GvCg/8rPwhul73B4esZua7/QL7Wp9IMN5+Fnz0NmB1c=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=erdh+a3+at1i8T0GTW2RXGHxrindsQrbMkOjng76TJGEIge0D3QlcUx63D4ubAW3VHsjeBn2Djj2x0t9fhmacBVCp8q2cosva6JMqUQqXo8m2z2KanhhAJmlOR6Ixf3x5AV69pv3p655wb+S6nh6GinsCu+RbZ5EJfqvHoyWzjw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rVIWS-0000QA-VC for gcc-patches@gnu.org; Wed, 31 Jan 2024 16:53:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706738011; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=u33xmClMJ3j3LdAJphBcU+MOW4NoT/JCivArj4BWmIE=; b=Ha7ay4Sbqckw8Tfbwr22YweZ9ad2jzivcVAStpLeq5C8kfNavUTVRK7WXLJa5WE5Q2D69t VRIhs3kwdxU4caBJPJwxIBS6O1zUmCOjPWCdR4rkrA/uljy/KZWV6587pZJu7nGyX3xrMh hvax5k79OtBajbVHC+nXlu/S56X/HIw= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-495-CltRAm5UOyWLfcovpswzxA-1; Wed, 31 Jan 2024 16:53:29 -0500 X-MC-Unique: CltRAm5UOyWLfcovpswzxA-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40f00a86728so1433145e9.2 for ; Wed, 31 Jan 2024 13:53:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706738008; x=1707342808; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=u33xmClMJ3j3LdAJphBcU+MOW4NoT/JCivArj4BWmIE=; b=uBmk1edV22TTXHbgsq0rv9byByV+B6IkwBlMHjYOsajB6WjcEO+0BkIP/G7pV7urPC aGu0mMqZZCkdfaHN4mm5HtNxrsWPGxBIF9E26QPip8x94pH7muoIu9sDrsMn4WbfTptn fcdbZCQekBVtc+Xs8P8FVIiChMTbn0+GfSGPfkxc84RTYmVe16/t6ql+J2X4jAitX2EA CAXubdVB7rgVosYxykvSbUInVndSEN2eIOjbH/wia4sPHqX6mYUyxqGeiWgeHOxqa6ZJ 2xGBkJpJmC8mY/vbL8pKP2r68WFTMtZLxUT7wfaGJXbyrG/mW8Y1bma8yYtH2BQesEcD 2nIA== X-Gm-Message-State: AOJu0YxuhIIhIE+ENWwoNAYlv+ylWjSGpxvLJhIxptvv+g2PscoIZPQS hgRgOoGFMa342scKQnI8apVYacvqqJ462taSKvqtDYwhcI5hrlsS6Yfzo7e7xO+iMRl/cYi8lw1 Drdzbn7MYRFW6icGMTocBOOYN98UPqyJO5srAt8S86SGExUT5Jg== X-Received: by 2002:a5d:4a02:0:b0:33b:731:808c with SMTP id m2-20020a5d4a02000000b0033b0731808cmr227569wrq.13.1706738008726; Wed, 31 Jan 2024 13:53:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IG88aRz/u8SKdWBbJ+wkyjPyQTrsxMysaHavsyCilcFWxoPWeu0q5jyl0SLlH88D3EfiNzn4w== X-Received: by 2002:a5d:4a02:0:b0:33b:731:808c with SMTP id m2-20020a5d4a02000000b0033b0731808cmr227564wrq.13.1706738008440; Wed, 31 Jan 2024 13:53:28 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXrcHmctQmSghKzFAa6Uo4awvJddtdM8zX2uGBGi+FOMh4Udk7E5YG7rhgFDHXGU22BE8Xtu/L6L81aLoY5PPZSy19tNrWKAsR/dn4DATmD94et5Icttkk= Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id o7-20020a05600c510700b0040e880ac6ecsm2650550wms.35.2024.01.31.13.53.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jan 2024 13:53:28 -0800 (PST) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1rVIWN-006NK1-1d; Wed, 31 Jan 2024 21:53:27 +0000 Date: Wed, 31 Jan 2024 21:53:27 +0000 (UTC) From: Joseph Myers To: Jakub Jelinek cc: Andi Kleen , Marek Polacek , gcc-patches@gnu.org Subject: Re: [PATCH v3 2/5] C++: Support clang compatible [[musttail]] (PR83324) In-Reply-To: Message-ID: References: <20240131021808.151575-1-ak@linux.intel.com> <20240131021808.151575-3-ak@linux.intel.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Received-SPF: pass client-ip=170.10.129.124; envelope-from=josmyers@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9,DKIMWL_WL_HIGH=-1.292,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,DKIM_VALID_EF=-0.1,RCVD_IN_DNSWL_NONE=-0.0001,RCVD_IN_MSPIKE_H2=-0.001,SPF_HELO_NONE=0.001,SPF_PASS=-0.001,T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 31 Jan 2024, Jakub Jelinek wrote: > On Wed, Jan 31, 2024 at 12:21:38PM -0800, Andi Kleen wrote: > > > > + case RID_RETURN: > > > > + { > > > > + bool musttail_p = false; > > > > + std_attrs = process_stmt_hotness_attribute (std_attrs, attrs_loc); > > > > + if (lookup_attribute ("", "musttail", std_attrs)) > > > > + { > > > > + musttail_p = true; > > > > + std_attrs = remove_attribute ("", "musttail", std_attrs); > > > > + } > > Using "" looks wrong to me, that is for standard attributes which > are also gnu attributes, say [[noreturn]]/[[gnu::noreturn]]. > That is not the case here. Even the __attribute__((musttail)) form will have > gnu namespace. And it's incorrect to use [[musttail]] (C23 syntax, no namespace) in any circumstances, at least for C, as it's not a standard attribute - so tests should verify that [[musttail]] is diagnosed as ignored even in contexts where [[gnu::musttail]] is valid. (It can't be standardized as [[musttail]] because of the rule that standard attributes must be ignorable; the proposed syntax for a TS and possible future standardization after that is "return goto".) -- Joseph S. Myers josmyers@redhat.com