From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C97A63858D20 for ; Sun, 12 Nov 2023 23:03:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C97A63858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C97A63858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699830188; cv=none; b=BTMI7nF+KzVL8mDhW+H2UqWZPNGV3gSmYk6K9uW7xjOYhZvgjWlfH6YVGh9BWnWWzrW45YqU/cpebuDCKSSViznH5APACVqyPAUqq7bAj+K61uEHqj+e5KGFRFgC8tcyeZYUV9iOOjoE9YsqvQfYRb5Hs3htRFz/hnSai/hnPto= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699830188; c=relaxed/simple; bh=foy7IQg6L3YpkzaalMs9GoT9tVUAn6h4LcC/WjkHiT0=; h=DKIM-Signature:Message-ID:Subject:From:To:Date:MIME-Version; b=hK/O03A2+VjGFS0+Vp8/AkFZlho9gyltkmS7dmBsatw0pWueF0JXD3+wvhA0arepf7VppUTm8t8J633dADcebA5H22yNW/DjZ2Uw09kmx8V/IjLMD0s10/gdYjxfnAqaL2Y1CRZJM2cD3xWxEMU50yb2gHsWF3y9C3ha82c79Ck= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699830186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=N3qUsWHEx7Bhu+RM9/4JYLR0l+LkxST2dCoQBhvbGXs=; b=BeI1htkHWrP0bzpYc5OcG688HZgb3FV+y5OPnjn9+RU2sFNkYnrwMCgsWwxPUvO3m9USz3 c+KdnZBtede8/ByXHxw64mmrb/dDGZeRQ63Rapm119n+8Ih6UYSkczTQjTRTL5+A9l0zmz IoHoeFF4KaFSnJG4moPdfN/QiaOqf54= Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-68-LFZlpwSyMiOEUwBv9EeyOA-1; Sun, 12 Nov 2023 18:03:04 -0500 X-MC-Unique: LFZlpwSyMiOEUwBv9EeyOA-1 Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-66d120c28afso45741116d6.0 for ; Sun, 12 Nov 2023 15:03:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699830184; x=1700434984; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=N3qUsWHEx7Bhu+RM9/4JYLR0l+LkxST2dCoQBhvbGXs=; b=kbyIJrE6CZyoIuxh9f1MpEYok6nFoOhSre+dPpuL40Msj0jsYaC42DBxRRVNYO9Qfc c6U5wJ3+4SCBHm34ri8Q5Gl7sryJaeFa85XabPvC69ALALgJszjZGctM/i6PmPPTi5Le O5EU8x4qHH0HaqtHRAfjPLSs2gvOQx2LWQBvB8VjMTCacVomsEiChPAKXgysbG4Hkset KSuzynUDSDZywhfq+UQMoQ7O2+bDj24Mz++Kuto+f35kLWwcLLzcHfSSZMt7Y2/JRc2k k9Hp5O3LAVsVehdYiYujwp0nUMbC74pU1cefKW583fKovJxwhAxgO9wN+ZOlv/iy59gA kE/A== X-Gm-Message-State: AOJu0YxoU5CyCoqWEOkRdTNP2eaiXbwhk3+xEYnQTubgPeiO/U3Ld7D9 i57L2hu/0OJDknCDaOHmuQ+Y+OmmsEhpj+A54EOwj1GEGBdi+PE+L0Ioj4BVPjUCloqXaOTdXpJ Q987Ga9P5bL/WXlY42A== X-Received: by 2002:ad4:4a68:0:b0:658:22f8:4e51 with SMTP id cn8-20020ad44a68000000b0065822f84e51mr5855608qvb.1.1699830184175; Sun, 12 Nov 2023 15:03:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGx5gIT/5lBT/JcjumGeMQOH4RNdQ7KMgGrfjP3StGqg+u7xTHP5vhtOC6lonTYmBgBG43oA== X-Received: by 2002:ad4:4a68:0:b0:658:22f8:4e51 with SMTP id cn8-20020ad44a68000000b0065822f84e51mr5855586qvb.1.1699830183834; Sun, 12 Nov 2023 15:03:03 -0800 (PST) Received: from t14s.localdomain (c-76-28-97-5.hsd1.ma.comcast.net. [76.28.97.5]) by smtp.gmail.com with ESMTPSA id y17-20020a056214017100b0065b0d9b4ee7sm1577599qvs.20.2023.11.12.15.03.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Nov 2023 15:03:03 -0800 (PST) Message-ID: Subject: Re: [PATCH] libgccjit: Fix GGC segfault when using -flto From: David Malcolm To: Antoni Boucher , jit@gcc.gnu.org, gcc-patches@gcc.gnu.org Date: Sun, 12 Nov 2023 18:03:02 -0500 In-Reply-To: <459954b377768b7a0d79dd9d99328b45c66e4fa0.camel@redhat.com> References: <459954b377768b7a0d79dd9d99328b45c66e4fa0.camel@redhat.com> User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 2023-11-10 at 18:14 -0500, David Malcolm wrote: > On Fri, 2023-11-10 at 11:02 -0500, Antoni Boucher wrote: > > Hi. > > This patch fixes the segfault when using -flto with libgccjit (bug > > 111396). > >=20 > > You mentioned in bugzilla that this didn't fix the reproducer for > > you, >=20 > Rereading https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D111396=C2=A0it > looks > like all I tested back in August was your reproducer; I didn't yet > test > your patch. >=20 > > but it does for me. > > At first, the test case would not pass, but running "make install" > > made > > it pass. > > Not sure if this is normal. > >=20 > > Could you please check if this fixes the issue on your side as > > well? > > Since this patch changes files outside of gcc/jit, what tests > > should > > I > > run to make sure it didn't break anything? >=20 > I'm trying your patch in my tester now. Bootstrapped with x86_64-pc-linux-gnu/build. No changes to non-jit tests, but had this effect on jit.sum: Changes to jit.sum ------------------ FAIL: 9->11 (+2) PASS: 14827->11434 (-3393) apparently due to: FAIL: test-combination.c.exe iteration 1 of 5: verify_code_accessing_bitfi= eld: result is NULL FAIL: test-combination.c.exe killed: 997638 exp16 0 0 CHILDKILLED SIGABRT = SIGABRT >=20 > BTW, we shouldn't add test-ggc-bugfix to since it adds options to the > context: this would affect all the other tests.