From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by sourceware.org (Postfix) with ESMTPS id ED29B3944832 for ; Wed, 28 Apr 2021 16:00:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org ED29B3944832 Received: by mail-qk1-x72c.google.com with SMTP id v23so12002114qkj.13 for ; Wed, 28 Apr 2021 09:00:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DJB9IsD4xNZmgvzWSpzmbEj2dUpNg4UWvknSoMk0k7M=; b=oFJj5/U2dFVXVDFEEkwABBWiOXWuaxRBjrCTqpKAwBUXE0Z14RZ/wbJILz2cPtNpES pZNcXMH1gyJ0N0NTUnwV/chjbPyQ5jabJBtORdJSMoyM4nOIl+tY6emMI4zdACX9Dj9E IUQU5DFI9o1Xudbl3V+gyDsHwJFC/Yta7NaJRSfoAK85FjGTOTXeRitqnpd5C3/RmW27 xqRpJx666fYHkPO2PiyzB6nT+4Ezwc5qisNQN3w/mWSpWUZpm4KIdbnaZ7OY5eIIVLqR TAINMJ3MQfWfAsCSVqmFMheGZJNzmAsHA+z4mG/AQ2FZF1dQ0p0MMoELYwwOdPWTOiAD wlzw== X-Gm-Message-State: AOAM533H/vku6X0S5EecF/U9hWVtKNpTCIatqckunM7tsYvaQrQ2p3lV Np4+sKUIWlvM/aJnWgGMhcM= X-Google-Smtp-Source: ABdhPJyvbZMcJlC0Gu9yeNZqY7lyzbNLW4PKocfcjuGBD8CG/I9ZCH+vyeNHpeqRZBRb0kzTEbBQlA== X-Received: by 2002:a37:9106:: with SMTP id t6mr28834784qkd.150.1619625628441; Wed, 28 Apr 2021 09:00:28 -0700 (PDT) Received: from [192.168.0.41] (71-218-14-121.hlrn.qwest.net. [71.218.14.121]) by smtp.gmail.com with ESMTPSA id q23sm340770qtl.25.2021.04.28.09.00.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Apr 2021 09:00:28 -0700 (PDT) Subject: Re: [PATCH] doc/options.texi: Fix the discription of 'Negative'. To: Geng Qi , gcc-patches@gcc.gnu.org, hongjiu.lu@intel.com References: <20210428092432.104-1-gengqi@linux.alibaba.com> From: Martin Sebor Message-ID: Date: Wed, 28 Apr 2021 10:00:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20210428092432.104-1-gengqi@linux.alibaba.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Apr 2021 16:00:31 -0000 On 4/28/21 3:24 AM, Geng Qi via Gcc-patches wrote: > gcc/ChangeLog: > * doc/options.texi (Negative): Fix the discription so that it matches > the code implementation of prune_options(). > --- > gcc/doc/options.texi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gcc/doc/options.texi b/gcc/doc/options.texi > index 2057629..37386ca 100644 > --- a/gcc/doc/options.texi > +++ b/gcc/doc/options.texi > @@ -223,8 +223,8 @@ propagate through the @code{Negative} property of the option to be > turned off. The driver will prune options, removing those that are > turned off by some later option. This pruning is not done for options > with @code{Joined} or @code{JoinedOrMissing} properties, unless the > -options have either @code{RejectNegative} property or the @code{Negative} > -property mentions an option other than itself. > +options have both @code{RejectNegative} property and the @code{Negative} > +property mentions itself. I don't know how it works so I can't comment on the correctness of the change but while making an adjustment to the text can you please also add the missing article before RejectNegative? ...have both the @code{RejectNegative} property and the @code{Negative} > +property mentions itself. Thanks Martin > > As a consequence, if you have a group of mutually-exclusive > options, their @code{Negative} properties should form a circular chain. >