From: "Kewen.Lin" <linkw@linux.ibm.com>
To: Pat Haugen <pthaugen@linux.ibm.com>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
David Edelsohn <dje.gcc@gmail.com>,
Peter Bergner <bergner@linux.ibm.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] rs6000: Make P10_FUSION honour tuning setting
Date: Fri, 6 Jan 2023 17:28:38 +0800 [thread overview]
Message-ID: <d1ab5c41-b72a-d70f-6736-85b4459285af@linux.ibm.com> (raw)
In-Reply-To: <b1075a99-6ebb-1e37-bdaa-a380f326872a@linux.ibm.com>
Hi Pat,
on 2023/1/6 03:30, Pat Haugen wrote:
> On 1/4/23 3:20 AM, Kewen.Lin via Gcc-patches wrote:
>> diff --git a/gcc/config/rs6000/rs6000.cc b/gcc/config/rs6000/rs6000.cc
>> index 88c865b6b4b..6fa084c0807 100644
>> --- a/gcc/config/rs6000/rs6000.cc
>> +++ b/gcc/config/rs6000/rs6000.cc
>> @@ -4378,9 +4378,15 @@ rs6000_option_override_internal (bool global_init_p)
>> rs6000_isa_flags &= ~OPTION_MASK_MMA;
>> }
>>
>> - if (TARGET_POWER10
>> - && (rs6000_isa_flags_explicit & OPTION_MASK_P10_FUSION) == 0)
>> - rs6000_isa_flags |= OPTION_MASK_P10_FUSION;
>> + /* Enable power10 fusion if we are tuning for power10, even if we aren't
>> + generating power10 instructions. */
>> + if (!(rs6000_isa_flags_explicit & OPTION_MASK_P10_FUSION))
>> + {
>> + if (processor_target_table[tune_index].processor == PROCESSOR_POWER10)
>
> You can use (rs6000_tune == PROCESSOR_POWER10) at this point.
Good catch, I will update it. Thanks!
BR,
Kewen
next prev parent reply other threads:[~2023-01-06 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 9:20 Kewen.Lin
2023-01-05 19:30 ` Pat Haugen
2023-01-06 9:28 ` Kewen.Lin [this message]
2023-01-11 13:05 ` Kewen.Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1ab5c41-b72a-d70f-6736-85b4459285af@linux.ibm.com \
--to=linkw@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=pthaugen@linux.ibm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).