From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 2D5AA385021E for ; Mon, 27 Feb 2023 15:13:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2D5AA385021E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677510785; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=AW+DFEvl8eejutMvqo+mlg0YfWC6bEV1vxNP7WuQ1w8=; b=KqJpVFaOhqK3zJwaJRSW/BlepwuFEA0Pl97nt8I0cIkJ6bkp/q3pGppxvEBAoK+nnau3Sm 6JeQcyfIE+wXMmF+D7xXOs7qAlsiZKOiJU+VSm4vAYG7/XqRnJ4QYX9V46OE2CbqkUBWof 61ml0oIiWEw9LynWLl+8sZ7jUzxmFAU= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-606-aRL0_PdYNsOrSpE6IOOQMA-1; Mon, 27 Feb 2023 10:13:04 -0500 X-MC-Unique: aRL0_PdYNsOrSpE6IOOQMA-1 Received: by mail-qt1-f198.google.com with SMTP id o10-20020a05622a138a00b003bfdabf3b89so1205313qtk.13 for ; Mon, 27 Feb 2023 07:13:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:date :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AW+DFEvl8eejutMvqo+mlg0YfWC6bEV1vxNP7WuQ1w8=; b=3Lz/k0lk9CtC6tqVKzkH4whd2wQRQrSTxCZLv0xCYOsOJ+3a1XNR+lyj7S5W/LKwK5 D2cwHlXx03CChRaVg82kiVMFQIZpLUTl10Psn6tOPtsxR5cvrArHlcSbGjatQa5YduIT Jr0IuomZ9KpUTbjWdXCQXOunXsqo2MGpiorIVwa3VwKDU8myy6KxkyHa60S2qtAl6E4y NVsgPe6EhE2uQmPqn+Hj+J6AgiulEaB9LgSoNAJjdco65vYrB3yOY+MsUvH/03lgg3Ok qm61NVkCn0AK2bnkbi5jvohNOvPGji2L4Yz0CVRo41s11ZSiPQR195fM0ZF35ys06Uc0 fF1g== X-Gm-Message-State: AO0yUKVa28e1CEozFbO3HMJ8MkNfzA+epe5f+UxjtI9xXwvIMgWa0uRf gDr4VkhlsgFtMt+jUw2GPlKPJeeV0svwMIbQygDX9R5pp0SJlNEcYcPV1D15SyDfkJY8PDlordF IDTExqpfd311HByjgMNGG310= X-Received: by 2002:a05:622a:4ce:b0:3bf:c423:c36d with SMTP id q14-20020a05622a04ce00b003bfc423c36dmr16193590qtx.12.1677510783769; Mon, 27 Feb 2023 07:13:03 -0800 (PST) X-Google-Smtp-Source: AK7set9XxhUIuZIuHTCLZqReB9868U5xGNftDlcTn3gQKAt3ZY046YXLaZ2lUQ+voSpP6KumqdTZzg== X-Received: by 2002:a05:622a:4ce:b0:3bf:c423:c36d with SMTP id q14-20020a05622a04ce00b003bfc423c36dmr16193543qtx.12.1677510783386; Mon, 27 Feb 2023 07:13:03 -0800 (PST) Received: from [192.168.1.130] (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id a4-20020a05622a02c400b003b323387c1asm4704386qtx.18.2023.02.27.07.13.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Feb 2023 07:13:02 -0800 (PST) From: Patrick Palka X-Google-Original-From: Patrick Palka Date: Mon, 27 Feb 2023 10:13:02 -0500 (EST) To: Patrick Palka cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] don't declare header-defined functions both static and inline, pt 2 In-Reply-To: <20230216134431.1600922-1-ppalka@redhat.com> Message-ID: References: <20230216134431.1600922-1-ppalka@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 16 Feb 2023, Patrick Palka wrote: > This fixes some header-defined functions that are undesirably declared > static and weren't caught by the "^static inline" pattern used in the > previous patch. > > gcc/ChangeLog: > > * hash-table.h (gt_pch_nx): Remove static. > * lra-int.h (lra_change_class): Likewise. > * recog.h (which_op_alt): Likewise. > * sel-sched-ir.h (sel_bb_empty_or_nop_p): Replace static with > inline. I went ahead and pushed this since I reckon it's a fairly safe/obvious follow-up to the main patch (https://gcc.gnu.org/pipermail/gcc-patches/2023-February/612130.html). > --- > gcc/hash-table.h | 2 +- > gcc/lra-int.h | 2 +- > gcc/recog.h | 2 +- > gcc/sel-sched-ir.h | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/gcc/hash-table.h b/gcc/hash-table.h > index 3f87ec06f37..c0c6e1cd83d 100644 > --- a/gcc/hash-table.h > +++ b/gcc/hash-table.h > @@ -1275,7 +1275,7 @@ hashtab_entry_note_pointers (void *obj, void *h, gt_pointer_operator op, > } > > template > -static void > +void > gt_pch_nx (hash_table *h) > { > h->check_complete_insertion (); > diff --git a/gcc/lra-int.h b/gcc/lra-int.h > index 73f8eb004b0..a400a0f85e2 100644 > --- a/gcc/lra-int.h > +++ b/gcc/lra-int.h > @@ -428,7 +428,7 @@ lra_get_regno_hard_regno (int regno) > > /* Change class of pseudo REGNO to NEW_CLASS. Print info about it > using TITLE. Output a new line if NL_P. */ > -static void inline > +inline void > lra_change_class (int regno, enum reg_class new_class, > const char *title, bool nl_p) > { > diff --git a/gcc/recog.h b/gcc/recog.h > index 764fa90afde..539a27c3edf 100644 > --- a/gcc/recog.h > +++ b/gcc/recog.h > @@ -382,7 +382,7 @@ extern const operand_alternative *recog_op_alt; > on operand OP of the current instruction alternative (which_alternative). > Only valid after calling preprocess_constraints and constrain_operands. */ > > -inline static const operand_alternative * > +inline const operand_alternative * > which_op_alt () > { > gcc_checking_assert (IN_RANGE (which_alternative, 0, > diff --git a/gcc/sel-sched-ir.h b/gcc/sel-sched-ir.h > index 7034a1ab06c..0e87134c6db 100644 > --- a/gcc/sel-sched-ir.h > +++ b/gcc/sel-sched-ir.h > @@ -1096,7 +1096,7 @@ get_loop_exit_edges_unique_dests (const class loop *loop) > return edges; > } > > -static bool > +inline bool > sel_bb_empty_or_nop_p (basic_block bb) > { > insn_t first = sel_bb_head (bb), last; > -- > 2.39.2.422.gc867e4fa18 > >