[PATCH, GCC/x86 mingw32] Add configure option to force wildcard behavior on Windows

[PATCH, GCC/x86 mingw32] Add configure option to force wildcard behavior on Windows

[Thomas Preudhomme]

[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]

By default, wildcard support on Windows for programs compiled with mingw depends 
on how the mingw runtime was configured. This means if one wants to build GCC 
for Windows with a consistent behavior with Wildcard (enabled or disabled) the 
mingw runtime must be built as well. This patch adds an option to GCC 
configuration to force the behavior with wildcard when building GCC for Windows 
host. It does so by setting the _dowildcard variable in the driver to a given 
value depending on the configure option value (yes or no), thus overriding the 
variable from mingw runtime.

Testing: I've successfully done a build of the arm-none-eabi cross GCC for 
Windows with Ubuntu system mingw runtime (configured without wildcard support by 
default) with the three configure options:
   1) --enable-wildcard: wildcard can be used successfully and nm of 
driver-mingw32.o shows that _dowildcard is in .data section
   2) --disable-wildcard: wildcard cannot be used and nm of driver-mingw32.o 
shows that _dowildcard is in .bss section
   3) no option: wildcard cannot be used and nm of driver-mingw32.o shows no 
_dowildcard defined and all sections are empty

Is this ok for stage1?

Best regards,

Thomas

[-- Attachment #2: force_windows_wildcard_behavior.patch --]
[-- Type: text/x-patch, Size: 5977 bytes --]

diff --git a/gcc/config.host b/gcc/config.host
index 6b28f3033ef92f1f0e09cc41f3a90be05c5e1e43..5e2db5327e3094a19cd29c81ceb1a9e2b11797c9 100644
--- a/gcc/config.host
+++ b/gcc/config.host
@@ -239,6 +239,7 @@ case ${host} in
     host_xmake_file="${host_xmake_file} i386/x-mingw32"
     host_exeext=.exe
     out_host_hook_obj=host-mingw32.o
+    host_extra_gcc_objs="${host_extra_gcc_objs} driver-mingw32.o"
     host_lto_plugin_soname=liblto_plugin-0.dll
     ;;
   x86_64-*-mingw*)
@@ -247,6 +248,7 @@ case ${host} in
     host_xmake_file="${host_xmake_file} i386/x-mingw32"
     host_exeext=.exe
     out_host_hook_obj=host-mingw32.o
+    host_extra_gcc_objs="${host_extra_gcc_objs} driver-mingw32.o"
     host_lto_plugin_soname=liblto_plugin-0.dll
     ;;
   i[34567]86-*-darwin* | x86_64-*-darwin*)
diff --git a/gcc/config.in b/gcc/config.in
index 1959dd7a603f121b6f2a3e0f80563d6290299c8a..a6afc623c5d8c2064eb43252235bc2b90e5de0e7 100644
--- a/gcc/config.in
+++ b/gcc/config.in
@@ -2015,6 +2015,12 @@
 #endif
 
 
+/* Value to set mingw's _dowildcard to. */
+#ifndef USED_FOR_TARGET
+#undef MINGW_DOWILDCARD
+#endif
+
+
 /* Define if host mkdir takes a single argument. */
 #ifndef USED_FOR_TARGET
 #undef MKDIR_TAKES_ONE_ARG
diff --git a/gcc/config/i386/driver-mingw32.c b/gcc/config/i386/driver-mingw32.c
new file mode 100644
index 0000000000000000000000000000000000000000..b70363ad26a7dc8ffccbb273e46d4dd6de1a6f8c
--- /dev/null
+++ b/gcc/config/i386/driver-mingw32.c
@@ -0,0 +1,26 @@
+/* Host OS specific configuration for the gcc driver.
+   Copyright (C) 2017 Free Software Foundation, Inc.
+
+This file is part of GCC.
+
+GCC is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 3, or (at your option)
+any later version.
+
+GCC is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GCC; see the file COPYING3.  If not see
+<http://www.gnu.org/licenses/>.  */
+
+#include "config.h"
+
+/* When defined, force the use (if non null) or not (otherwise) of CLI
+   globbing.  */
+#ifdef MINGW_DOWILDCARD
+int _dowildcard = MINGW_DOWILDCARD;
+#endif
diff --git a/gcc/config/i386/x-mingw32 b/gcc/config/i386/x-mingw32
index b5cef97512032a223605fb4db592fab05b1bb521..d0fa05245c4566c56aab6a1a6683a13a4392f864 100644
--- a/gcc/config/i386/x-mingw32
+++ b/gcc/config/i386/x-mingw32
@@ -63,3 +63,6 @@ host-mingw32.o : $(srcdir)/config/i386/host-mingw32.c $(CONFIG_H) $(SYSTEM_H) \
   coretypes.h hosthooks.h hosthooks-def.h toplev.h $(DIAGNOSTIC_H) $(HOOKS_H)
 	$(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) \
 		$(srcdir)/config/i386/host-mingw32.c
+
+driver-mingw32.o : $(srcdir)/config/i386/driver-mingw32.c $(CONFIG_H)
+	$(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) $<
diff --git a/gcc/configure b/gcc/configure
index 60cb979b558431949a20fc83482b198a091c5efe..db2d114a52d8795265ca4d4348dfc695455e56f5 100755
--- a/gcc/configure
+++ b/gcc/configure
@@ -919,6 +919,7 @@ enable_rpath
 with_libiconv_prefix
 enable_sjlj_exceptions
 enable_secureplt
+enable_mingw_wildcard
 enable_leading_mingw64_underscores
 enable_cld
 enable_frame_pointer
@@ -1631,6 +1632,8 @@ Optional Features:
   --enable-sjlj-exceptions
                           arrange to use setjmp/longjmp exception handling
   --enable-secureplt      enable -msecure-plt by default for PowerPC
+  --enable-mingw-wildcard Set whether to expand wildcard on command-line.
+                          Default to platform configuration
   --enable-leading-mingw64-underscores
                           enable leading underscores on 64 bit mingw targets
   --enable-cld            enable -mcld by default for 32bit x86
@@ -11944,6 +11947,21 @@ if test "${enable_secureplt+set}" = set; then :
 fi
 
 
+# Check whether --enable-mingw-wildcard was given.
+if test "${enable_mingw_wildcard+set}" = set; then :
+  enableval=$enable_mingw_wildcard;
+else
+  enable_mingw_wildcard=platform
+fi
+
+if test x"$enable_mingw_wildcard" != xplatform ; then :
+
+cat >>confdefs.h <<_ACEOF
+#define MINGW_DOWILDCARD $(test x"$enable_mingw_wildcard" = xno; echo $?)
+_ACEOF
+
+fi
+
 # Check whether --enable-leading-mingw64-underscores was given.
 if test "${enable_leading_mingw64_underscores+set}" = set; then :
   enableval=$enable_leading_mingw64_underscores;
@@ -18414,7 +18432,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 18417 "configure"
+#line 18435 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
@@ -18520,7 +18538,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 18523 "configure"
+#line 18541 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
diff --git a/gcc/configure.ac b/gcc/configure.ac
index b73a807ed14b5aafa51570a2449d9ac6e3c1f446..dde9c6b6f44053e4b8cfc1e62732318d9e1e3ab6 100644
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -1808,6 +1808,16 @@ AC_ARG_ENABLE(secureplt,
 		[enable -msecure-plt by default for PowerPC])],
 [], [])
 
+AC_ARG_ENABLE(mingw-wildcard,
+[AS_HELP_STRING([--enable-mingw-wildcard],
+		[Set whether to expand wildcard on command-line.
+		 Default to platform configuration])],
+[],[enable_mingw_wildcard=platform])
+AS_IF([test x"$enable_mingw_wildcard" != xplatform ],
+      [AC_DEFINE_UNQUOTED(MINGW_DOWILDCARD,
+		 $(test x"$enable_mingw_wildcard" = xno; echo $?),
+		 [Value to set mingw's _dowildcard to.])])
+
 AC_ARG_ENABLE(leading-mingw64-underscores,
   AS_HELP_STRING([--enable-leading-mingw64-underscores],
                  [enable leading underscores on 64 bit mingw targets]),

Re: [PATCH, GCC/x86 mingw32] Add configure option to force wildcard behavior on Windows

[JonY]

[-- Attachment #1.1: Type: text/plain, Size: 1489 bytes --]

On 01/18/2017 09:48 AM, Thomas Preudhomme wrote:
> By default, wildcard support on Windows for programs compiled with mingw
> depends on how the mingw runtime was configured. This means if one wants
> to build GCC for Windows with a consistent behavior with Wildcard
> (enabled or disabled) the mingw runtime must be built as well. This
> patch adds an option to GCC configuration to force the behavior with
> wildcard when building GCC for Windows host. It does so by setting the
> _dowildcard variable in the driver to a given value depending on the
> configure option value (yes or no), thus overriding the variable from
> mingw runtime.
> 
> Testing: I've successfully done a build of the arm-none-eabi cross GCC
> for Windows with Ubuntu system mingw runtime (configured without
> wildcard support by default) with the three configure options:
>   1) --enable-wildcard: wildcard can be used successfully and nm of
> driver-mingw32.o shows that _dowildcard is in .data section
>   2) --disable-wildcard: wildcard cannot be used and nm of
> driver-mingw32.o shows that _dowildcard is in .bss section
>   3) no option: wildcard cannot be used and nm of driver-mingw32.o shows
> no _dowildcard defined and all sections are empty
> 
> Is this ok for stage1?
> 
> Best regards,
> 
> Thomas

No objections, but documentation should mention that wildcard expansion
is not handled by the CMD shell on Windows, it is up to individual
programs to interpret it.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 829 bytes --]

Re: [PATCH, GCC/x86 mingw32] Add configure option to force wildcard behavior on Windows

[Thomas Preudhomme]

Hi JonY,

On 19/01/17 01:37, JonY wrote:
> On 01/18/2017 09:48 AM, Thomas Preudhomme wrote:
>> By default, wildcard support on Windows for programs compiled with mingw
>> depends on how the mingw runtime was configured. This means if one wants
>> to build GCC for Windows with a consistent behavior with Wildcard
>> (enabled or disabled) the mingw runtime must be built as well. This
>> patch adds an option to GCC configuration to force the behavior with
>> wildcard when building GCC for Windows host. It does so by setting the
>> _dowildcard variable in the driver to a given value depending on the
>> configure option value (yes or no), thus overriding the variable from
>> mingw runtime.
>>
>> Testing: I've successfully done a build of the arm-none-eabi cross GCC
>> for Windows with Ubuntu system mingw runtime (configured without
>> wildcard support by default) with the three configure options:
>>   1) --enable-wildcard: wildcard can be used successfully and nm of
>> driver-mingw32.o shows that _dowildcard is in .data section
>>   2) --disable-wildcard: wildcard cannot be used and nm of
>> driver-mingw32.o shows that _dowildcard is in .bss section
>>   3) no option: wildcard cannot be used and nm of driver-mingw32.o shows
>> no _dowildcard defined and all sections are empty
>>
>> Is this ok for stage1?
>>
>> Best regards,
>>
>> Thomas
>
> No objections, but documentation should mention that wildcard expansion
> is not handled by the CMD shell on Windows, it is up to individual
> programs to interpret it.

Do you mean that this configuration option should make it clear that it only 
affects wildcard expansion for GCC itself but not for programs built by GCC?

Best regards,

Thomas

Re: [PATCH, GCC/x86 mingw32] Add configure option to force wildcard behavior on Windows

[Thomas Preudhomme]

[-- Attachment #1: Type: text/plain, Size: 2113 bytes --]

Hi JonY,

On 19/01/17 01:37, JonY wrote:
> On 01/18/2017 09:48 AM, Thomas Preudhomme wrote:
>> By default, wildcard support on Windows for programs compiled with mingw
>> depends on how the mingw runtime was configured. This means if one wants
>> to build GCC for Windows with a consistent behavior with Wildcard
>> (enabled or disabled) the mingw runtime must be built as well. This
>> patch adds an option to GCC configuration to force the behavior with
>> wildcard when building GCC for Windows host. It does so by setting the
>> _dowildcard variable in the driver to a given value depending on the
>> configure option value (yes or no), thus overriding the variable from
>> mingw runtime.
>>
>> Testing: I've successfully done a build of the arm-none-eabi cross GCC
>> for Windows with Ubuntu system mingw runtime (configured without
>> wildcard support by default) with the three configure options:
>>   1) --enable-wildcard: wildcard can be used successfully and nm of
>> driver-mingw32.o shows that _dowildcard is in .data section
>>   2) --disable-wildcard: wildcard cannot be used and nm of
>> driver-mingw32.o shows that _dowildcard is in .bss section
>>   3) no option: wildcard cannot be used and nm of driver-mingw32.o shows
>> no _dowildcard defined and all sections are empty
>>
>> Is this ok for stage1?
>>
>> Best regards,
>>
>> Thomas
>
> No objections, but documentation should mention that wildcard expansion
> is not handled by the CMD shell on Windows, it is up to individual
> programs to interpret it.

How about the attached updated patch? Here's the associated ChangeLog entry:

2017-01-24  Thomas Preud'homme  <thomas.preudhomme@arm.com>

         * configure.ac (--enable-mingw-wildcard): Add new configurable feature.
         * configure: Regenerate.
         * config.in: Regenerate.
         * config/i386/driver-mingw32.c: new file.
         * config/i386/x-mingw32: Add rule to build driver-mingw32.o.
         * config.host: Link driver-mingw32.o on MinGW host.
         * doc/install.texi: Document new --enable-mingw-wildcard configure
         option.

Best regards,

Thomas

[-- Attachment #2: force_windows_wildcard_behavior.patch --]
[-- Type: text/x-patch, Size: 7053 bytes --]

diff --git a/gcc/config.host b/gcc/config.host
index 6b28f3033ef92f1f0e09cc41f3a90be05c5e1e43..5e2db5327e3094a19cd29c81ceb1a9e2b11797c9 100644
--- a/gcc/config.host
+++ b/gcc/config.host
@@ -239,6 +239,7 @@ case ${host} in
     host_xmake_file="${host_xmake_file} i386/x-mingw32"
     host_exeext=.exe
     out_host_hook_obj=host-mingw32.o
+    host_extra_gcc_objs="${host_extra_gcc_objs} driver-mingw32.o"
     host_lto_plugin_soname=liblto_plugin-0.dll
     ;;
   x86_64-*-mingw*)
@@ -247,6 +248,7 @@ case ${host} in
     host_xmake_file="${host_xmake_file} i386/x-mingw32"
     host_exeext=.exe
     out_host_hook_obj=host-mingw32.o
+    host_extra_gcc_objs="${host_extra_gcc_objs} driver-mingw32.o"
     host_lto_plugin_soname=liblto_plugin-0.dll
     ;;
   i[34567]86-*-darwin* | x86_64-*-darwin*)
diff --git a/gcc/config.in b/gcc/config.in
index 1959dd7a603f121b6f2a3e0f80563d6290299c8a..b1f8018acfc5e8bf12503130a4707a2f6c21a1fd 100644
--- a/gcc/config.in
+++ b/gcc/config.in
@@ -2015,6 +2015,12 @@
 #endif
 
 
+/* Value to set MinGW's _dowildcard to. */
+#ifndef USED_FOR_TARGET
+#undef MINGW_DOWILDCARD
+#endif
+
+
 /* Define if host mkdir takes a single argument. */
 #ifndef USED_FOR_TARGET
 #undef MKDIR_TAKES_ONE_ARG
diff --git a/gcc/config/i386/driver-mingw32.c b/gcc/config/i386/driver-mingw32.c
new file mode 100644
index 0000000000000000000000000000000000000000..b70363ad26a7dc8ffccbb273e46d4dd6de1a6f8c
--- /dev/null
+++ b/gcc/config/i386/driver-mingw32.c
@@ -0,0 +1,26 @@
+/* Host OS specific configuration for the gcc driver.
+   Copyright (C) 2017 Free Software Foundation, Inc.
+
+This file is part of GCC.
+
+GCC is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 3, or (at your option)
+any later version.
+
+GCC is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GCC; see the file COPYING3.  If not see
+<http://www.gnu.org/licenses/>.  */
+
+#include "config.h"
+
+/* When defined, force the use (if non null) or not (otherwise) of CLI
+   globbing.  */
+#ifdef MINGW_DOWILDCARD
+int _dowildcard = MINGW_DOWILDCARD;
+#endif
diff --git a/gcc/config/i386/x-mingw32 b/gcc/config/i386/x-mingw32
index b5cef97512032a223605fb4db592fab05b1bb521..d0fa05245c4566c56aab6a1a6683a13a4392f864 100644
--- a/gcc/config/i386/x-mingw32
+++ b/gcc/config/i386/x-mingw32
@@ -63,3 +63,6 @@ host-mingw32.o : $(srcdir)/config/i386/host-mingw32.c $(CONFIG_H) $(SYSTEM_H) \
   coretypes.h hosthooks.h hosthooks-def.h toplev.h $(DIAGNOSTIC_H) $(HOOKS_H)
 	$(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) \
 		$(srcdir)/config/i386/host-mingw32.c
+
+driver-mingw32.o : $(srcdir)/config/i386/driver-mingw32.c $(CONFIG_H)
+	$(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) $<
diff --git a/gcc/configure b/gcc/configure
index 60cb979b558431949a20fc83482b198a091c5efe..db2d114a52d8795265ca4d4348dfc695455e56f5 100755
--- a/gcc/configure
+++ b/gcc/configure
@@ -919,6 +919,7 @@ enable_rpath
 with_libiconv_prefix
 enable_sjlj_exceptions
 enable_secureplt
+enable_mingw_wildcard
 enable_leading_mingw64_underscores
 enable_cld
 enable_frame_pointer
@@ -1631,6 +1632,8 @@ Optional Features:
   --enable-sjlj-exceptions
                           arrange to use setjmp/longjmp exception handling
   --enable-secureplt      enable -msecure-plt by default for PowerPC
+  --enable-mingw-wildcard Set whether to expand wildcard on command-line.
+                          Default to platform configuration
   --enable-leading-mingw64-underscores
                           enable leading underscores on 64 bit mingw targets
   --enable-cld            enable -mcld by default for 32bit x86
@@ -11944,6 +11947,21 @@ if test "${enable_secureplt+set}" = set; then :
 fi
 
 
+# Check whether --enable-mingw-wildcard was given.
+if test "${enable_mingw_wildcard+set}" = set; then :
+  enableval=$enable_mingw_wildcard;
+else
+  enable_mingw_wildcard=platform
+fi
+
+if test x"$enable_mingw_wildcard" != xplatform ; then :
+
+cat >>confdefs.h <<_ACEOF
+#define MINGW_DOWILDCARD $(test x"$enable_mingw_wildcard" = xno; echo $?)
+_ACEOF
+
+fi
+
 # Check whether --enable-leading-mingw64-underscores was given.
 if test "${enable_leading_mingw64_underscores+set}" = set; then :
   enableval=$enable_leading_mingw64_underscores;
@@ -18414,7 +18432,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 18417 "configure"
+#line 18435 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
@@ -18520,7 +18538,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 18523 "configure"
+#line 18541 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
diff --git a/gcc/configure.ac b/gcc/configure.ac
index b73a807ed14b5aafa51570a2449d9ac6e3c1f446..a8c323b60cc3c8af808934b023fd1689e421cadf 100644
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -1808,6 +1808,16 @@ AC_ARG_ENABLE(secureplt,
 		[enable -msecure-plt by default for PowerPC])],
 [], [])
 
+AC_ARG_ENABLE(mingw-wildcard,
+[AS_HELP_STRING([--enable-mingw-wildcard],
+		[Set whether to expand wildcard on command-line.
+		 Default to platform configuration])],
+[],[enable_mingw_wildcard=platform])
+AS_IF([test x"$enable_mingw_wildcard" != xplatform ],
+      [AC_DEFINE_UNQUOTED(MINGW_DOWILDCARD,
+		 $(test x"$enable_mingw_wildcard" = xno; echo $?),
+		 [Value to set MinGW's _dowildcard to.])])
+
 AC_ARG_ENABLE(leading-mingw64-underscores,
   AS_HELP_STRING([--enable-leading-mingw64-underscores],
                  [enable leading underscores on 64 bit mingw targets]),
diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
index 4958773818bba3318a20e555e9f00ea1c9b116fc..365d587a5a0ec6dad5b0fc62a04f022fcb33c386 100644
--- a/gcc/doc/install.texi
+++ b/gcc/doc/install.texi
@@ -1688,6 +1688,18 @@ Using the GNU Compiler Collection (GCC)},
 See ``i386 and x86-64 Options'' in the main manual
 @end ifhtml
 
+@item --enable-mingw-wildcard
+@itemx --disable-mingw-wildcard
+The @option{--enable-mingw-wildcard} option enables Microsoft Windows-hosted
+GCC to perform wildcard expansion of its arguments, irregardless of the default
+configuration of MinGW runtime.  Conversely, @option{--disable-mingw-wildcard}
+option disables wildcard expansion. When none of these options is specified,
+wildcard expansion will be decided according to the way the MinGW runtime was
+configured.
+
+Note that this option only affects wildcard expansion for GCC itself.  It does
+not affect wildcard expansion of executables built by the resulting GCC.
+
 @item --enable-win32-registry
 @itemx --enable-win32-registry=@var{key}
 @itemx --disable-win32-registry

Re: [PATCH, GCC/x86 mingw32] Add configure option to force wildcard behavior on Windows

[JonY]

[-- Attachment #1.1: Type: text/plain, Size: 1539 bytes --]

On 01/26/2017 01:04 PM, Thomas Preudhomme wrote:
> Hi JonY,
> 
> On 19/01/17 01:37, JonY wrote:
>> On 01/18/2017 09:48 AM, Thomas Preudhomme wrote:
>>> By default, wildcard support on Windows for programs compiled with mingw
>>> depends on how the mingw runtime was configured. This means if one wants
>>> to build GCC for Windows with a consistent behavior with Wildcard
>>> (enabled or disabled) the mingw runtime must be built as well. This
>>> patch adds an option to GCC configuration to force the behavior with
>>> wildcard when building GCC for Windows host. It does so by setting the
>>> _dowildcard variable in the driver to a given value depending on the
>>> configure option value (yes or no), thus overriding the variable from
>>> mingw runtime.
>>>
>>> Testing: I've successfully done a build of the arm-none-eabi cross GCC
>>> for Windows with Ubuntu system mingw runtime (configured without
>>> wildcard support by default) with the three configure options:
>>>   1) --enable-wildcard: wildcard can be used successfully and nm of
>>> driver-mingw32.o shows that _dowildcard is in .data section
>>>   2) --disable-wildcard: wildcard cannot be used and nm of
>>> driver-mingw32.o shows that _dowildcard is in .bss section
>>>   3) no option: wildcard cannot be used and nm of driver-mingw32.o shows
>>> no _dowildcard defined and all sections are empty
>>>
>>> Is this ok for stage1?
>>>

Looks good, be sure to emphasize this option affects mingw hosted GCC
only, not the compiler output.




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 829 bytes --]

Re: [PATCH, GCC/x86 mingw32] Add configure option to force wildcard behavior on Windows

[Thomas Preudhomme]

Hi Jonathan,

Sorry for the delay answering.

On 07/02/17 08:47, JonY wrote:
> On 01/26/2017 01:04 PM, Thomas Preudhomme wrote:
>> Hi JonY,
>>
>> On 19/01/17 01:37, JonY wrote:
>>> On 01/18/2017 09:48 AM, Thomas Preudhomme wrote:
>>>> By default, wildcard support on Windows for programs compiled with mingw
>>>> depends on how the mingw runtime was configured. This means if one wants
>>>> to build GCC for Windows with a consistent behavior with Wildcard
>>>> (enabled or disabled) the mingw runtime must be built as well. This
>>>> patch adds an option to GCC configuration to force the behavior with
>>>> wildcard when building GCC for Windows host. It does so by setting the
>>>> _dowildcard variable in the driver to a given value depending on the
>>>> configure option value (yes or no), thus overriding the variable from
>>>> mingw runtime.
>>>>
>>>> Testing: I've successfully done a build of the arm-none-eabi cross GCC
>>>> for Windows with Ubuntu system mingw runtime (configured without
>>>> wildcard support by default) with the three configure options:
>>>>   1) --enable-wildcard: wildcard can be used successfully and nm of
>>>> driver-mingw32.o shows that _dowildcard is in .data section
>>>>   2) --disable-wildcard: wildcard cannot be used and nm of
>>>> driver-mingw32.o shows that _dowildcard is in .bss section
>>>>   3) no option: wildcard cannot be used and nm of driver-mingw32.o shows
>>>> no _dowildcard defined and all sections are empty
>>>>
>>>> Is this ok for stage1?
>>>>
>
> Looks good, be sure to emphasize this option affects mingw hosted GCC
> only, not the compiler output.

I think that should be pretty clear in the latest version of the patch, 
doc/install.texi contains:

"Note that this option only affects wildcard expansion for GCC itself.  It does
not affect wildcard expansion of executables built by the resulting GCC."

If you think a part of that sentence is still confusing please let me know and 
I'll improve it.

Best regards,

Thomas

Re: [PATCH, GCC/x86 mingw32] Add configure option to force wildcard behavior on Windows

[JonY]

[-- Attachment #1.1: Type: text/plain, Size: 637 bytes --]

On 02/14/2017 09:32 AM, Thomas Preudhomme wrote:
>>
>> Looks good, be sure to emphasize this option affects mingw hosted GCC
>> only, not the compiler output.
> 
> I think that should be pretty clear in the latest version of the patch,
> doc/install.texi contains:
> 
> "Note that this option only affects wildcard expansion for GCC itself. 
> It does
> not affect wildcard expansion of executables built by the resulting GCC."
> 
> If you think a part of that sentence is still confusing please let me
> know and I'll improve it.
> 
> Best regards,
> 
> Thomas
> 

Yes, that should be good, no more objections.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 829 bytes --]

Re: [PATCH, GCC/x86 mingw32] Add configure option to force wildcard behavior on Windows

[JonY]

[-- Attachment #1.1: Type: text/plain, Size: 761 bytes --]

On 02/14/2017 10:42 AM, JonY wrote:
> On 02/14/2017 09:32 AM, Thomas Preudhomme wrote:
>>>
>>> Looks good, be sure to emphasize this option affects mingw hosted GCC
>>> only, not the compiler output.
>>
>> I think that should be pretty clear in the latest version of the patch,
>> doc/install.texi contains:
>>
>> "Note that this option only affects wildcard expansion for GCC itself. 
>> It does
>> not affect wildcard expansion of executables built by the resulting GCC."
>>
>> If you think a part of that sentence is still confusing please let me
>> know and I'll improve it.
>>
>> Best regards,
>>
>> Thomas
>>
> 
> Yes, that should be good, no more objections.
> 
> 

Before I forget, please also provide a changelog, thanks.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 829 bytes --]

Re: [PATCH, GCC/x86 mingw32] Add configure option to force wildcard behavior on Windows

[Thomas Preudhomme]

Here you are:

2017-01-24  Thomas Preud'homme  <thomas.preudhomme@arm.com>

         * configure.ac (--enable-mingw-wildcard): Add new configurable feature.
         * configure: Regenerate.
         * config.in: Regenerate.
         * config/i386/driver-mingw32.c: new file.
         * config/i386/x-mingw32: Add rule to build driver-mingw32.o.
         * config.host: Link driver-mingw32.o on MinGW host.
         * doc/install.texi: Document new --enable-mingw-wildcard configure
         option.

Must have forgotten to paste it.

On 17/02/17 10:52, JonY wrote:
> On 02/14/2017 10:42 AM, JonY wrote:
>> On 02/14/2017 09:32 AM, Thomas Preudhomme wrote:
>>>>
>>>> Looks good, be sure to emphasize this option affects mingw hosted GCC
>>>> only, not the compiler output.
>>>
>>> I think that should be pretty clear in the latest version of the patch,
>>> doc/install.texi contains:
>>>
>>> "Note that this option only affects wildcard expansion for GCC itself.
>>> It does
>>> not affect wildcard expansion of executables built by the resulting GCC."
>>>
>>> If you think a part of that sentence is still confusing please let me
>>> know and I'll improve it.
>>>
>>> Best regards,
>>>
>>> Thomas
>>>
>>
>> Yes, that should be good, no more objections.
>>
>>
>
> Before I forget, please also provide a changelog, thanks.
>
>

Re: [PATCH, GCC/x86 mingw32] Add configure option to force wildcard behavior on Windows

[JonY]

[-- Attachment #1.1: Type: text/plain, Size: 681 bytes --]

On 02/17/2017 11:31 AM, Thomas Preudhomme wrote:
> Here you are:
> 
> 2017-01-24  Thomas Preud'homme  <thomas.preudhomme@arm.com>
> 
>         * configure.ac (--enable-mingw-wildcard): Add new configurable
> feature.
>         * configure: Regenerate.
>         * config.in: Regenerate.
>         * config/i386/driver-mingw32.c: new file.
>         * config/i386/x-mingw32: Add rule to build driver-mingw32.o.
>         * config.host: Link driver-mingw32.o on MinGW host.
>         * doc/install.texi: Document new --enable-mingw-wildcard configure
>         option.
> 
> Must have forgotten to paste it.

Thanks, I'll stage it locally until stage 1 opens.




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 829 bytes --]

Re: [PATCH, GCC/x86 mingw32] Add configure option to force wildcard behavior on Windows

[Thomas Preudhomme]

Oh great thanks!

Best regards,

Thomas

On 17/02/17 22:52, JonY wrote:
> On 02/17/2017 11:31 AM, Thomas Preudhomme wrote:
>> Here you are:
>>
>> 2017-01-24  Thomas Preud'homme  <thomas.preudhomme@arm.com>
>>
>>         * configure.ac (--enable-mingw-wildcard): Add new configurable
>> feature.
>>         * configure: Regenerate.
>>         * config.in: Regenerate.
>>         * config/i386/driver-mingw32.c: new file.
>>         * config/i386/x-mingw32: Add rule to build driver-mingw32.o.
>>         * config.host: Link driver-mingw32.o on MinGW host.
>>         * doc/install.texi: Document new --enable-mingw-wildcard configure
>>         option.
>>
>> Must have forgotten to paste it.
>
> Thanks, I'll stage it locally until stage 1 opens.
>
>
>

Re: [PATCH, GCC/x86 mingw32] Add configure option to force wildcard behavior on Windows

[Thomas Preudhomme]

On 27/02/17 05:48, NightStrike wrote:
>
>
> On Feb 22, 2017 10:06 AM, "Thomas Preudhomme" <thomas.preudhomme@foss.arm.com
> <mailto:thomas.preudhomme@foss.arm.com>> wrote:
>
>     Oh great thanks!
>
>     Best regards,
>
>     Thomas
>
>
>     On 17/02/17 22:52, JonY wrote:
>
>         On 02/17/2017 11:31 AM, Thomas Preudhomme wrote:
>
>             Here you are:
>
>             2017-01-24  Thomas Preud'homme  <thomas.preudhomme@arm.com
>             <mailto:thomas.preudhomme@arm.com>>
>
>                     * configure.ac <http://configure.ac>
>             (--enable-mingw-wildcard): Add new configurable
>             feature.
>                     * configure: Regenerate.
>                     * config.in <http://config.in>: Regenerate.
>                     * config/i386/driver-mingw32.c: new file.
>                     * config/i386/x-mingw32: Add rule to build driver-mingw32.o.
>                     * config.host: Link driver-mingw32.o on MinGW host.
>                     * doc/install.texi: Document new --enable-mingw-wildcard
>             configure
>                     option.
>
>             Must have forgotten to paste it.
>
>
>         Thanks, I'll stage it locally until stage 1 opens.
>
>
> This should be mentioned in the "porting to" page when it eventually goes in, as
> it may be surprising behavior.
>

Will do once the file is created for gcc-8. Thanks for the suggestion

Best regards,

Thomas

[wwwdocs] gcc-8/porting_to.html (was: [PATCH, GCC/x86 mingw32] Add configure option to force wildcard behavior on Windows)

[Gerald Pfeifer]

On Thu, 2 Mar 2017, Thomas Preudhomme wrote:
>> This should be mentioned in the "porting to" page when it eventually 
>> goes in, as it may be surprising behavior.
> Will do once the file is created for gcc-8. Thanks for the suggestion

Here we go. :-)  Applied.

Gerald

Index: porting_to.html
===================================================================
RCS file: porting_to.html
diff -N porting_to.html
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ porting_to.html	4 Mar 2017 14:20:46 -0000
@@ -0,0 +1,37 @@
+<html>
+
+<head>
+<title>Porting to GCC 8</title>
+</head>
+
+<body>
+<h1>Porting to GCC 8</h1>
+
+<p>
+The GCC 8 release series differs from previous GCC releases in
+<a href="changes.html">a number of ways</a>. Some of these are a result
+of bug fixing, and some old behaviors have been intentionally changed
+to support new standards, or relaxed in standards-conforming ways to
+facilitate compilation or run-time performance.
+</p>
+
+<p>
+Some of these changes are user visible and can cause grief when
+porting to GCC 8. This document is an effort to identify common issues
+and provide solutions. Let us know if you have suggestions for improvements!
+</p>
+
+
+<h2 id="cpp">Preprocessor issues</h2>
+
+
+<h2 id="c">C language issues</h2>
+
+
+<h2 id="cxx">C++ language issues</h2>
+
+
+<h2 id="links">Links</h2>
+
+</body>
+</html>

Re: [wwwdocs] gcc-8/porting_to.html

[Thomas Preudhomme]

[-- Attachment #1: Type: text/plain, Size: 1669 bytes --]

Thanks Gerald,

JonY: what about the attached patch to document the change of behavior of GCC on 
Windows depending on the configure option used?

Best regards,

Thomas

On 04/03/17 14:25, Gerald Pfeifer wrote:
> On Thu, 2 Mar 2017, Thomas Preudhomme wrote:
>>> This should be mentioned in the "porting to" page when it eventually
>>> goes in, as it may be surprising behavior.
>> Will do once the file is created for gcc-8. Thanks for the suggestion
>
> Here we go. :-)  Applied.
>
> Gerald
>
> Index: porting_to.html
> ===================================================================
> RCS file: porting_to.html
> diff -N porting_to.html
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ porting_to.html	4 Mar 2017 14:20:46 -0000
> @@ -0,0 +1,37 @@
> +<html>
> +
> +<head>
> +<title>Porting to GCC 8</title>
> +</head>
> +
> +<body>
> +<h1>Porting to GCC 8</h1>
> +
> +<p>
> +The GCC 8 release series differs from previous GCC releases in
> +<a href="changes.html">a number of ways</a>. Some of these are a result
> +of bug fixing, and some old behaviors have been intentionally changed
> +to support new standards, or relaxed in standards-conforming ways to
> +facilitate compilation or run-time performance.
> +</p>
> +
> +<p>
> +Some of these changes are user visible and can cause grief when
> +porting to GCC 8. This document is an effort to identify common issues
> +and provide solutions. Let us know if you have suggestions for improvements!
> +</p>
> +
> +
> +<h2 id="cpp">Preprocessor issues</h2>
> +
> +
> +<h2 id="c">C language issues</h2>
> +
> +
> +<h2 id="cxx">C++ language issues</h2>
> +
> +
> +<h2 id="links">Links</h2>
> +
> +</body>
> +</html>
>

[-- Attachment #2: document_windows_wildcard_change_gcc8.patch --]
[-- Type: text/x-patch, Size: 3579 bytes --]

cvs diff: Diffing .
cvs diff: Diffing bin
cvs diff: Diffing cgi-bin
cvs diff: Diffing htdocs
cvs diff: Diffing htdocs/benchmarks
cvs diff: Diffing htdocs/bugs
cvs diff: Diffing htdocs/bzkanban
cvs diff: Diffing htdocs/egcs-1.0
cvs diff: Diffing htdocs/egcs-1.1
cvs diff: Diffing htdocs/fortran
cvs diff: Diffing htdocs/gcc-2.95
cvs diff: Diffing htdocs/gcc-3.0
cvs diff: Diffing htdocs/gcc-3.1
cvs diff: Diffing htdocs/gcc-3.2
cvs diff: Diffing htdocs/gcc-3.3
cvs diff: Diffing htdocs/gcc-3.4
cvs diff: Diffing htdocs/gcc-4.0
cvs diff: Diffing htdocs/gcc-4.1
cvs diff: Diffing htdocs/gcc-4.2
cvs diff: Diffing htdocs/gcc-4.3
cvs diff: Diffing htdocs/gcc-4.4
cvs diff: Diffing htdocs/gcc-4.5
cvs diff: Diffing htdocs/gcc-4.6
cvs diff: Diffing htdocs/gcc-4.7
cvs diff: Diffing htdocs/gcc-4.8
cvs diff: Diffing htdocs/gcc-4.9
cvs diff: Diffing htdocs/gcc-5
cvs diff: Diffing htdocs/gcc-6
cvs diff: Diffing htdocs/gcc-7
cvs diff: Diffing htdocs/gcc-8
Index: htdocs/gcc-8/porting_to.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/porting_to.html,v
retrieving revision 1.1
diff -u -r1.1 porting_to.html
--- htdocs/gcc-8/porting_to.html	4 Mar 2017 14:21:41 -0000	1.1
+++ htdocs/gcc-8/porting_to.html	9 Mar 2017 10:49:34 -0000
@@ -31,6 +31,17 @@
 <h2 id="cxx">C++ language issues</h2>
 
 
+<h2 id="mingw">MinGW issues</h2>
+
+<p>GCC on Microsoft Windows can now be configured via
+<code>--enable-mingw-wildcard</code> or <code>--disable-mingw-wildcard</code>
+to force a specific behavior for GCC itself with regards to supporting or
+not the wildcard character. Prior versions of GCC would follow the
+configuration of MinGW runtime. This behavior can still be obtained by not
+using the above options or by using
+<code>--enable-mingw-wildcard=platform</code>.</p>
+
+
 <h2 id="links">Links</h2>
 
 </body>
cvs diff: Diffing htdocs/git
cvs diff: Diffing htdocs/img
cvs diff: Diffing htdocs/install
cvs diff: Diffing htdocs/java
cvs diff: Diffing htdocs/libstdc++
cvs diff: Diffing htdocs/news
cvs diff: Diffing htdocs/onlinedocs
cvs diff: Diffing htdocs/onlinedocs/4.6.0
cvs diff: Diffing htdocs/onlinedocs/4.6.1
cvs diff: Diffing htdocs/onlinedocs/4.6.2
cvs diff: Diffing htdocs/onlinedocs/4.6.3
cvs diff: Diffing htdocs/onlinedocs/4.6.4
cvs diff: Diffing htdocs/onlinedocs/4.7.0
cvs diff: Diffing htdocs/onlinedocs/4.7.1
cvs diff: Diffing htdocs/onlinedocs/4.7.2
cvs diff: Diffing htdocs/onlinedocs/4.7.3
cvs diff: Diffing htdocs/onlinedocs/4.7.4
cvs diff: Diffing htdocs/onlinedocs/4.8.0
cvs diff: Diffing htdocs/onlinedocs/4.8.1
cvs diff: Diffing htdocs/onlinedocs/4.8.2
cvs diff: Diffing htdocs/onlinedocs/4.8.3
cvs diff: Diffing htdocs/onlinedocs/4.8.4
cvs diff: Diffing htdocs/onlinedocs/4.8.5
cvs diff: Diffing htdocs/onlinedocs/4.9.0
cvs diff: Diffing htdocs/onlinedocs/4.9.1
cvs diff: Diffing htdocs/onlinedocs/4.9.2
cvs diff: Diffing htdocs/onlinedocs/4.9.3
cvs diff: Diffing htdocs/onlinedocs/4.9.4
cvs diff: Diffing htdocs/onlinedocs/5.1.0
cvs diff: Diffing htdocs/onlinedocs/5.2.0
cvs diff: Diffing htdocs/onlinedocs/5.3.0
cvs diff: Diffing htdocs/onlinedocs/5.4.0
cvs diff: Diffing htdocs/onlinedocs/6.1.0
cvs diff: Diffing htdocs/onlinedocs/6.2.0
cvs diff: Diffing htdocs/onlinedocs/6.3.0
cvs diff: Diffing htdocs/projects
cvs diff: Diffing htdocs/projects/bp
cvs diff: Diffing htdocs/projects/cxx-reflection
cvs diff: Diffing htdocs/projects/gomp
cvs diff: Diffing htdocs/projects/lto
cvs diff: Diffing htdocs/projects/strees
cvs diff: Diffing htdocs/projects/tree-ssa
cvs diff: Diffing htdocs/testing

Re: [wwwdocs] gcc-8/porting_to.html

[Jakub Jelinek]

On Thu, Mar 09, 2017 at 10:51:27AM +0000, Thomas Preudhomme wrote:
> Thanks Gerald,
> 
> JonY: what about the attached patch to document the change of behavior of
> GCC on Windows depending on the configure option used?

GCC 7 has not branched yet, so the change can't be committed anywhere.
It seems documenting something before it is actually changed is just too
weird.

	Jakub

Re: [wwwdocs] gcc-8/porting_to.html

[Thomas Preudhomme]

Hi Jakub,

I forgot to mention "ok for stage1?", my bad. JonY said he was queuing the 
corresponding changes in GCC for stage1 so I was just trying to have a complete 
story. I do not expect to commit this before the actual code change is committed.

Best regards,

Thomas

On 09/03/17 10:58, Jakub Jelinek wrote:
> On Thu, Mar 09, 2017 at 10:51:27AM +0000, Thomas Preudhomme wrote:
>> Thanks Gerald,
>>
>> JonY: what about the attached patch to document the change of behavior of
>> GCC on Windows depending on the configure option used?
>
> GCC 7 has not branched yet, so the change can't be committed anywhere.
> It seems documenting something before it is actually changed is just too
> weird.
>
> 	Jakub
>

Re: [wwwdocs] gcc-8/porting_to.html

[JonY]

[-- Attachment #1.1: Type: text/plain, Size: 369 bytes --]

On 03/09/2017 11:22 AM, Thomas Preudhomme wrote:
> Hi Jakub,
> 
> I forgot to mention "ok for stage1?", my bad. JonY said he was queuing
> the corresponding changes in GCC for stage1 so I was just trying to have
> a complete story. I do not expect to commit this before the actual code
> change is committed.
> 

Right, I was waiting for GCC 8 to open.




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 858 bytes --]

Re: [wwwdocs] gcc-8/porting_to.html

[Gerald Pfeifer]

On Thu, 9 Mar 2017, Thomas Preudhomme wrote:
> JonY: what about the attached patch to document the change of behavior 
> of GCC on Windows depending on the configure option used?

+<h2 id="mingw">MinGW issues</h2>
+
+<p>GCC on Microsoft Windows can now be configured via
+<code>--enable-mingw-wildcard</code> or <code>--disable-mingw-wildcard</code>
+to force a specific behavior for GCC itself with regards to supporting or
+not the wildcard character. Prior versions of GCC would follow the

Perhaps put "(or not)" in parentheses?

+configuration of MinGW runtime. This behavior can still be obtained by not
+using the above options or by using
+<code>--enable-mingw-wildcard=platform</code>.</p>

Is this really going to be a question for the Porting Guide, or more
something you'd put into the release notes (aka changes.html)?  I am
thinking more the latter.

This patch is approved for gcc-8/changes.html once GCC 7 has branched
and gcc-8/changes.html be put in place (though I may be doing that pro-
actively later today ;-).

Gerald

Re: [wwwdocs] gcc-8/porting_to.html

[JonY]

[-- Attachment #1.1: Type: text/plain, Size: 1284 bytes --]

On 03/12/2017 02:07 PM, Gerald Pfeifer wrote:
> On Thu, 9 Mar 2017, Thomas Preudhomme wrote:
>> JonY: what about the attached patch to document the change of behavior
>> of GCC on Windows depending on the configure option used?
> 
> +<h2 id="mingw">MinGW issues</h2>
> +
> +<p>GCC on Microsoft Windows can now be configured via
> +<code>--enable-mingw-wildcard</code> or
> <code>--disable-mingw-wildcard</code>
> +to force a specific behavior for GCC itself with regards to supporting or
> +not the wildcard character. Prior versions of GCC would follow the
> 
> Perhaps put "(or not)" in parentheses?
> 
> +configuration of MinGW runtime. This behavior can still be obtained by not
> +using the above options or by using
> +<code>--enable-mingw-wildcard=platform</code>.</p>
> 
> Is this really going to be a question for the Porting Guide, or more
> something you'd put into the release notes (aka changes.html)?  I am
> thinking more the latter.
> 
> This patch is approved for gcc-8/changes.html once GCC 7 has branched
> and gcc-8/changes.html be put in place (though I may be doing that pro-
> actively later today ;-).
> 
> Gerald
> 

It should be part of the release notes since it only affects GCC itself,
not the actual generated output.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 858 bytes --]

Re: [wwwdocs] gcc-8/porting_to.html

[Thomas Preudhomme]

[-- Attachment #1: Type: text/plain, Size: 1550 bytes --]

Hi JonY,

Sorry for the delay. Please find updated patch as per Gerald and you suggestion.

Is this ok for wwwdocs once [1] is committed in GCC 8 cycle?

[1] https://gcc.gnu.org/ml/gcc-patches/2017-02/msg01153.html

Best regards,

Thomas

On 12/03/17 23:51, JonY wrote:
> On 03/12/2017 02:07 PM, Gerald Pfeifer wrote:
>> On Thu, 9 Mar 2017, Thomas Preudhomme wrote:
>>> JonY: what about the attached patch to document the change of behavior
>>> of GCC on Windows depending on the configure option used?
>>
>> +<h2 id="mingw">MinGW issues</h2>
>> +
>> +<p>GCC on Microsoft Windows can now be configured via
>> +<code>--enable-mingw-wildcard</code> or
>> <code>--disable-mingw-wildcard</code>
>> +to force a specific behavior for GCC itself with regards to supporting or
>> +not the wildcard character. Prior versions of GCC would follow the
>>
>> Perhaps put "(or not)" in parentheses?
>>
>> +configuration of MinGW runtime. This behavior can still be obtained by not
>> +using the above options or by using
>> +<code>--enable-mingw-wildcard=platform</code>.</p>
>>
>> Is this really going to be a question for the Porting Guide, or more
>> something you'd put into the release notes (aka changes.html)?  I am
>> thinking more the latter.
>>
>> This patch is approved for gcc-8/changes.html once GCC 7 has branched
>> and gcc-8/changes.html be put in place (though I may be doing that pro-
>> actively later today ;-).
>>
>> Gerald
>>
>
> It should be part of the release notes since it only affects GCC itself,
> not the actual generated output.
>
>

[-- Attachment #2: document_windows_wildcard_change_gcc8.patch --]
[-- Type: text/x-patch, Size: 3715 bytes --]

cvs diff: Diffing .
cvs diff: Diffing bin
cvs diff: Diffing cgi-bin
cvs diff: Diffing htdocs
cvs diff: Diffing htdocs/benchmarks
cvs diff: Diffing htdocs/bugs
cvs diff: Diffing htdocs/bzkanban
cvs diff: Diffing htdocs/egcs-1.0
cvs diff: Diffing htdocs/egcs-1.1
cvs diff: Diffing htdocs/fortran
cvs diff: Diffing htdocs/gcc-2.95
cvs diff: Diffing htdocs/gcc-3.0
cvs diff: Diffing htdocs/gcc-3.1
cvs diff: Diffing htdocs/gcc-3.2
cvs diff: Diffing htdocs/gcc-3.3
cvs diff: Diffing htdocs/gcc-3.4
cvs diff: Diffing htdocs/gcc-4.0
cvs diff: Diffing htdocs/gcc-4.1
cvs diff: Diffing htdocs/gcc-4.2
cvs diff: Diffing htdocs/gcc-4.3
cvs diff: Diffing htdocs/gcc-4.4
cvs diff: Diffing htdocs/gcc-4.5
cvs diff: Diffing htdocs/gcc-4.6
cvs diff: Diffing htdocs/gcc-4.7
cvs diff: Diffing htdocs/gcc-4.8
cvs diff: Diffing htdocs/gcc-4.9
cvs diff: Diffing htdocs/gcc-5
cvs diff: Diffing htdocs/gcc-6
cvs diff: Diffing htdocs/gcc-7
cvs diff: Diffing htdocs/gcc-8
Index: htdocs/gcc-8/changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/changes.html,v
retrieving revision 1.2
diff -u -r1.2 changes.html
--- htdocs/gcc-8/changes.html	12 Mar 2017 14:25:34 -0000	1.2
+++ htdocs/gcc-8/changes.html	21 Mar 2017 10:59:46 -0000
@@ -135,7 +135,16 @@
 
 <!-- <h3 id="vxmils">VxWorks MILS</h3> -->
 
-<!-- <h3 id="windows">Windows</h3> -->
+<h3 id="windows">Windows</h3>
+   <ul>
+     <li>GCC on Microsoft Windows can now be configured via
+       <code>--enable-mingw-wildcard</code> or
+       <code>--disable-mingw-wildcard</code> to force a specific behavior for
+       GCC itself with regards to supporting or not the wildcard character.
+       Prior versions of GCC would follow the configuration of MinGW runtime.
+       This behavior can still be obtained by not using the above options or by
+       using <code>--enable-mingw-wildcard=platform</code>.</li>
+   </ul>
 
 
 <!-- .................................................................. -->
cvs diff: Diffing htdocs/git
cvs diff: Diffing htdocs/img
cvs diff: Diffing htdocs/install
cvs diff: Diffing htdocs/java
cvs diff: Diffing htdocs/libstdc++
cvs diff: Diffing htdocs/news
cvs diff: Diffing htdocs/onlinedocs
cvs diff: Diffing htdocs/onlinedocs/4.6.0
cvs diff: Diffing htdocs/onlinedocs/4.6.1
cvs diff: Diffing htdocs/onlinedocs/4.6.2
cvs diff: Diffing htdocs/onlinedocs/4.6.3
cvs diff: Diffing htdocs/onlinedocs/4.6.4
cvs diff: Diffing htdocs/onlinedocs/4.7.0
cvs diff: Diffing htdocs/onlinedocs/4.7.1
cvs diff: Diffing htdocs/onlinedocs/4.7.2
cvs diff: Diffing htdocs/onlinedocs/4.7.3
cvs diff: Diffing htdocs/onlinedocs/4.7.4
cvs diff: Diffing htdocs/onlinedocs/4.8.0
cvs diff: Diffing htdocs/onlinedocs/4.8.1
cvs diff: Diffing htdocs/onlinedocs/4.8.2
cvs diff: Diffing htdocs/onlinedocs/4.8.3
cvs diff: Diffing htdocs/onlinedocs/4.8.4
cvs diff: Diffing htdocs/onlinedocs/4.8.5
cvs diff: Diffing htdocs/onlinedocs/4.9.0
cvs diff: Diffing htdocs/onlinedocs/4.9.1
cvs diff: Diffing htdocs/onlinedocs/4.9.2
cvs diff: Diffing htdocs/onlinedocs/4.9.3
cvs diff: Diffing htdocs/onlinedocs/4.9.4
cvs diff: Diffing htdocs/onlinedocs/5.1.0
cvs diff: Diffing htdocs/onlinedocs/5.2.0
cvs diff: Diffing htdocs/onlinedocs/5.3.0
cvs diff: Diffing htdocs/onlinedocs/5.4.0
cvs diff: Diffing htdocs/onlinedocs/6.1.0
cvs diff: Diffing htdocs/onlinedocs/6.2.0
cvs diff: Diffing htdocs/onlinedocs/6.3.0
cvs diff: Diffing htdocs/projects
cvs diff: Diffing htdocs/projects/bp
cvs diff: Diffing htdocs/projects/cxx-reflection
cvs diff: Diffing htdocs/projects/gomp
cvs diff: Diffing htdocs/projects/lto
cvs diff: Diffing htdocs/projects/strees
cvs diff: Diffing htdocs/projects/tree-ssa
cvs diff: Diffing htdocs/testing

Re: [wwwdocs] gcc-8/porting_to.html

[JonY]

[-- Attachment #1.1: Type: text/plain, Size: 361 bytes --]

On 03/22/2017 05:39 PM, Thomas Preudhomme wrote:
> Hi JonY,
> 
> Sorry for the delay. Please find updated patch as per Gerald and you
> suggestion.
> 
> Is this ok for wwwdocs once [1] is committed in GCC 8 cycle?
> 
> [1] https://gcc.gnu.org/ml/gcc-patches/2017-02/msg01153.html
> 
> Best regards,
> 
> Thomas

Looks good to me, thanks.





[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 858 bytes --]

Re: [wwwdocs] gcc-8/porting_to.html

[Gerald Pfeifer]

Hi Thomas,

On Wed, 22 Mar 2017, Thomas Preudhomme wrote:
> Is this ok for wwwdocs once [1] is committed in GCC 8 cycle?

+     <li>GCC on Microsoft Windows can now be configured via
+       <code>--enable-mingw-wildcard</code> or
+       <code>--disable-mingw-wildcard</code> to force a specific behavior for
+       GCC itself with regards to supporting or not the wildcard character.

Here I would omit the "or not" which I believe does not work well
in English.

+       Prior versions of GCC would follow the configuration of MinGW runtime.

And here add "the" before "MinGW".

This looks fine to me with these two minor changes, thank you.

Gerald

Re: [wwwdocs] gcc-8/porting_to.html

[Thomas Preudhomme]

[-- Attachment #1: Type: text/plain, Size: 802 bytes --]

Ack. Please find updated patch as per suggestions.

Best regards,

Thomas

On 23/03/17 06:47, Gerald Pfeifer wrote:
> Hi Thomas,
>
> On Wed, 22 Mar 2017, Thomas Preudhomme wrote:
>> Is this ok for wwwdocs once [1] is committed in GCC 8 cycle?
>
> +     <li>GCC on Microsoft Windows can now be configured via
> +       <code>--enable-mingw-wildcard</code> or
> +       <code>--disable-mingw-wildcard</code> to force a specific behavior for
> +       GCC itself with regards to supporting or not the wildcard character.
>
> Here I would omit the "or not" which I believe does not work well
> in English.
>
> +       Prior versions of GCC would follow the configuration of MinGW runtime.
>
> And here add "the" before "MinGW".
>
> This looks fine to me with these two minor changes, thank you.
>
> Gerald

[-- Attachment #2: document_windows_wildcard_change_gcc8.patch --]
[-- Type: text/x-patch, Size: 1054 bytes --]

Index: htdocs/gcc-8/changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/changes.html,v
retrieving revision 1.2
diff -u -r1.2 changes.html
--- htdocs/gcc-8/changes.html	12 Mar 2017 14:25:34 -0000	1.2
+++ htdocs/gcc-8/changes.html	23 Mar 2017 10:44:35 -0000
@@ -135,7 +135,16 @@
 
 <!-- <h3 id="vxmils">VxWorks MILS</h3> -->
 
-<!-- <h3 id="windows">Windows</h3> -->
+<h3 id="windows">Windows</h3>
+   <ul>
+     <li>GCC on Microsoft Windows can now be configured via
+       <code>--enable-mingw-wildcard</code> or
+       <code>--disable-mingw-wildcard</code> to force a specific behavior for
+       GCC itself with regards to supporting the wildcard character.  Prior
+       versions of GCC would follow the configuration of the MinGW runtime.
+       This behavior can still be obtained by not using the above options or by
+       using <code>--enable-mingw-wildcard=platform</code>.</li>
+   </ul>
 
 
 <!-- .................................................................. -->

Re: [wwwdocs] gcc-8/porting_to.html

[JonY]

[-- Attachment #1.1: Type: text/plain, Size: 202 bytes --]

On 03/23/2017 10:47 AM, Thomas Preudhomme wrote:
> Ack. Please find updated patch as per suggestions.
> 
> Best regards,
> 
> Thomas
> 

I've applied the changes to GCC 8 trunk as r247588.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 858 bytes --]

Re: [wwwdocs] gcc-8/porting_to.html

[Thomas Preudhomme]

Great, thanks. I'll go and commit the corresponding wwwdocs change.

Best regards,

Thomas

On 04/05/17 12:03, JonY wrote:
> On 03/23/2017 10:47 AM, Thomas Preudhomme wrote:
>> Ack. Please find updated patch as per suggestions.
>>
>> Best regards,
>>
>> Thomas
>>
>
> I've applied the changes to GCC 8 trunk as r247588.
>
>

Re: [wwwdocs] gcc-8/porting_to.html

[Thomas Preudhomme]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

Committed with the suggested changes (see attachment for reference).

Thanks.

Best regards,

Thomas

On 23/03/17 06:47, Gerald Pfeifer wrote:
> Hi Thomas,
>
> On Wed, 22 Mar 2017, Thomas Preudhomme wrote:
>> Is this ok for wwwdocs once [1] is committed in GCC 8 cycle?
>
> +     <li>GCC on Microsoft Windows can now be configured via
> +       <code>--enable-mingw-wildcard</code> or
> +       <code>--disable-mingw-wildcard</code> to force a specific behavior for
> +       GCC itself with regards to supporting or not the wildcard character.
>
> Here I would omit the "or not" which I believe does not work well
> in English.
>
> +       Prior versions of GCC would follow the configuration of MinGW runtime.
>
> And here add "the" before "MinGW".
>
> This looks fine to me with these two minor changes, thank you.
>
> Gerald

[-- Attachment #2: document_windows_wildcard_change_gcc8.patch --]
[-- Type: text/x-patch, Size: 1054 bytes --]

Index: htdocs/gcc-8/changes.html
===================================================================
RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-8/changes.html,v
retrieving revision 1.2
diff -u -r1.2 changes.html
--- htdocs/gcc-8/changes.html	12 Mar 2017 14:25:34 -0000	1.2
+++ htdocs/gcc-8/changes.html	23 Mar 2017 10:44:35 -0000
@@ -135,7 +135,16 @@
 
 <!-- <h3 id="vxmils">VxWorks MILS</h3> -->
 
-<!-- <h3 id="windows">Windows</h3> -->
+<h3 id="windows">Windows</h3>
+   <ul>
+     <li>GCC on Microsoft Windows can now be configured via
+       <code>--enable-mingw-wildcard</code> or
+       <code>--disable-mingw-wildcard</code> to force a specific behavior for
+       GCC itself with regards to supporting the wildcard character.  Prior
+       versions of GCC would follow the configuration of the MinGW runtime.
+       This behavior can still be obtained by not using the above options or by
+       using <code>--enable-mingw-wildcard=platform</code>.</li>
+   </ul>
 
 
 <!-- .................................................................. -->

[arm-embedded] [PATCH, GCC/x86 mingw32] Add configure option to force wildcard behavior on Windows

[Thomas Preudhomme]

[-- Attachment #1: Type: text/plain, Size: 892 bytes --]

Hi,

We've decided to apply the following patch to the ARM/embedded-7-branch as we 
did earlier for the ARM/embedded-6-branch. Patch attached for reference.

Best regards,

Thomas

On 17/02/17 22:52, JonY wrote:
> On 02/17/2017 11:31 AM, Thomas Preudhomme wrote:
>> Here you are:
>>
>> 2017-01-24  Thomas Preud'homme  <thomas.preudhomme@arm.com>
>>
>>         * configure.ac (--enable-mingw-wildcard): Add new configurable
>> feature.
>>         * configure: Regenerate.
>>         * config.in: Regenerate.
>>         * config/i386/driver-mingw32.c: new file.
>>         * config/i386/x-mingw32: Add rule to build driver-mingw32.o.
>>         * config.host: Link driver-mingw32.o on MinGW host.
>>         * doc/install.texi: Document new --enable-mingw-wildcard configure
>>         option.
>>
>> Must have forgotten to paste it.
>
> Thanks, I'll stage it locally until stage 1 opens.
>
>
>

[-- Attachment #2: add_windows_wildcard_support.patch --]
[-- Type: text/x-patch, Size: 6728 bytes --]

diff --git a/gcc/ChangeLog.arm b/gcc/ChangeLog.arm
new file mode 100644
index 0000000000000000000000000000000000000000..d336f6a29a7f68fb938b2fae45f453bd20f35903
--- /dev/null
+++ b/gcc/ChangeLog.arm
@@ -0,0 +1,13 @@
+2017-05-04  Thomas Preud'homme  <thomas.preudhomme@arm.com>
+
+	Backport from mainline
+	2017-05-04  Thomas Preud'homme  <thomas.preudhomme@arm.com>
+
+	* configure.ac (--enable-mingw-wildcard): Add new configurable feature.
+	* configure: Regenerate.
+	* config.in: Regenerate.
+	* config/i386/driver-mingw32.c: new file.
+	* config/i386/x-mingw32: Add rule to build driver-mingw32.o.
+	* config.host: Link driver-mingw32.o on MinGW host.
+	* doc/install.texi: Document new --enable-mingw-wildcard configure
+	option.
diff --git a/gcc/config.host b/gcc/config.host
index 6b28f3033ef92f1f0e09cc41f3a90be05c5e1e43..5e2db5327e3094a19cd29c81ceb1a9e2b11797c9 100644
--- a/gcc/config.host
+++ b/gcc/config.host
@@ -239,6 +239,7 @@ case ${host} in
     host_xmake_file="${host_xmake_file} i386/x-mingw32"
     host_exeext=.exe
     out_host_hook_obj=host-mingw32.o
+    host_extra_gcc_objs="${host_extra_gcc_objs} driver-mingw32.o"
     host_lto_plugin_soname=liblto_plugin-0.dll
     ;;
   x86_64-*-mingw*)
@@ -247,6 +248,7 @@ case ${host} in
     host_xmake_file="${host_xmake_file} i386/x-mingw32"
     host_exeext=.exe
     out_host_hook_obj=host-mingw32.o
+    host_extra_gcc_objs="${host_extra_gcc_objs} driver-mingw32.o"
     host_lto_plugin_soname=liblto_plugin-0.dll
     ;;
   i[34567]86-*-darwin* | x86_64-*-darwin*)
diff --git a/gcc/config.in b/gcc/config.in
index d87cb3c9fab0499137702be24085e6f61d7f89e4..bf2aa7b2e7d81a593b72a8d0359864773754ef5d 100644
--- a/gcc/config.in
+++ b/gcc/config.in
@@ -2009,6 +2009,12 @@
 #endif
 
 
+/* Value to set mingw's _dowildcard to. */
+#ifndef USED_FOR_TARGET
+#undef MINGW_DOWILDCARD
+#endif
+
+
 /* Define if host mkdir takes a single argument. */
 #ifndef USED_FOR_TARGET
 #undef MKDIR_TAKES_ONE_ARG
diff --git a/gcc/config/i386/driver-mingw32.c b/gcc/config/i386/driver-mingw32.c
new file mode 100644
index 0000000000000000000000000000000000000000..b70363ad26a7dc8ffccbb273e46d4dd6de1a6f8c
--- /dev/null
+++ b/gcc/config/i386/driver-mingw32.c
@@ -0,0 +1,26 @@
+/* Host OS specific configuration for the gcc driver.
+   Copyright (C) 2017 Free Software Foundation, Inc.
+
+This file is part of GCC.
+
+GCC is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 3, or (at your option)
+any later version.
+
+GCC is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GCC; see the file COPYING3.  If not see
+<http://www.gnu.org/licenses/>.  */
+
+#include "config.h"
+
+/* When defined, force the use (if non null) or not (otherwise) of CLI
+   globbing.  */
+#ifdef MINGW_DOWILDCARD
+int _dowildcard = MINGW_DOWILDCARD;
+#endif
diff --git a/gcc/config/i386/x-mingw32 b/gcc/config/i386/x-mingw32
index 6a2d5a5069461b93884fa68ffbcbb13585d24c37..85f2793e5e934b6bf5629667578940cf3f172be3 100644
--- a/gcc/config/i386/x-mingw32
+++ b/gcc/config/i386/x-mingw32
@@ -29,3 +29,6 @@ host-mingw32.o : $(srcdir)/config/i386/host-mingw32.c $(CONFIG_H) $(SYSTEM_H) \
   coretypes.h hosthooks.h hosthooks-def.h toplev.h $(DIAGNOSTIC_H) $(HOOKS_H)
 	$(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) \
 		$(srcdir)/config/i386/host-mingw32.c
+
+driver-mingw32.o : $(srcdir)/config/i386/driver-mingw32.c $(CONFIG_H)
+	$(COMPILER) -c $(ALL_COMPILERFLAGS) $(ALL_CPPFLAGS) $(INCLUDES) $<
diff --git a/gcc/configure b/gcc/configure
index ea73b151a4e1797983665a7f5437136dc8dcb46e..1a295674eb448725e24df85b2fe85e74b32f02d7 100755
--- a/gcc/configure
+++ b/gcc/configure
@@ -921,6 +921,7 @@ with_libiconv_prefix
 enable_sjlj_exceptions
 with_gcc_major_version_only
 enable_secureplt
+enable_mingw_wildcard
 enable_leading_mingw64_underscores
 enable_cld
 enable_frame_pointer
@@ -1633,6 +1634,8 @@ Optional Features:
   --enable-sjlj-exceptions
                           arrange to use setjmp/longjmp exception handling
   --enable-secureplt      enable -msecure-plt by default for PowerPC
+  --enable-mingw-wildcard Set whether to expand wildcard on command-line.
+                          Default to platform configuration
   --enable-leading-mingw64-underscores
                           enable leading underscores on 64 bit mingw targets
   --enable-cld            enable -mcld by default for 32bit x86
@@ -11963,6 +11966,21 @@ if test "${enable_secureplt+set}" = set; then :
 fi
 
 
+# Check whether --enable-mingw-wildcard was given.
+if test "${enable_mingw_wildcard+set}" = set; then :
+  enableval=$enable_mingw_wildcard;
+else
+  enable_mingw_wildcard=platform
+fi
+
+if test x"$enable_mingw_wildcard" != xplatform ; then :
+
+cat >>confdefs.h <<_ACEOF
+#define MINGW_DOWILDCARD $(test x"$enable_mingw_wildcard" = xno; echo $?)
+_ACEOF
+
+fi
+
 # Check whether --enable-leading-mingw64-underscores was given.
 if test "${enable_leading_mingw64_underscores+set}" = set; then :
   enableval=$enable_leading_mingw64_underscores;
@@ -18433,7 +18451,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 18436 "configure"
+#line 18454 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
@@ -18539,7 +18557,7 @@ else
   lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
   lt_status=$lt_dlunknown
   cat > conftest.$ac_ext <<_LT_EOF
-#line 18542 "configure"
+#line 18560 "configure"
 #include "confdefs.h"
 
 #if HAVE_DLFCN_H
diff --git a/gcc/configure.ac b/gcc/configure.ac
index 9d4c792a33f4e4da79d80a7676f22684f45df47b..b4c59e2e17d6e483a10fd9ed04233945b6355189 100644
--- a/gcc/configure.ac
+++ b/gcc/configure.ac
@@ -1811,6 +1811,16 @@ AC_ARG_ENABLE(secureplt,
 		[enable -msecure-plt by default for PowerPC])],
 [], [])
 
+AC_ARG_ENABLE(mingw-wildcard,
+[AS_HELP_STRING([--enable-mingw-wildcard],
+		[Set whether to expand wildcard on command-line.
+		 Default to platform configuration])],
+[],[enable_mingw_wildcard=platform])
+AS_IF([test x"$enable_mingw_wildcard" != xplatform ],
+      [AC_DEFINE_UNQUOTED(MINGW_DOWILDCARD,
+		 $(test x"$enable_mingw_wildcard" = xno; echo $?),
+		 [Value to set mingw's _dowildcard to.])])
+
 AC_ARG_ENABLE(leading-mingw64-underscores,
   AS_HELP_STRING([--enable-leading-mingw64-underscores],
                  [enable leading underscores on 64 bit mingw targets]),