public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [gc-improv] Convert ARM backend
@ 2009-11-09  9:50 Laurynas Biveinis
  2009-11-12 14:55 ` Daniel Jacobowitz
  0 siblings, 1 reply; 3+ messages in thread
From: Laurynas Biveinis @ 2009-11-09  9:50 UTC (permalink / raw)
  To: gcc-patches

Bootstrapped and regtested under armv5tel-unknown-linux-gnueabi.
committed to gc-improv.

2009-11-09  Laurynas Biveinis  <laurynas.biveinis@gmail.com>

        * config/arm/arm.c (arm_init_machine_status): Use typed GC
        allocation.


-- 
Laurynas


Index: gcc/ChangeLog.gc-improv
===================================================================
--- gcc/ChangeLog.gc-improv     (revision 153879)
+++ gcc/ChangeLog.gc-improv     (working copy)
@@ -1,3 +1,8 @@
+2009-11-09  Laurynas Biveinis  <laurynas.biveinis@gmail.com>
+
+       * config/arm/arm.c (arm_init_machine_status): Use typed GC
+       allocation.
+
 2009-11-02  Laurynas Biveinis  <laurynas.biveinis@gmail.com>

        * sese.h: Include obstack.h.
Index: gcc/config/arm/arm.c
===================================================================
--- gcc/config/arm/arm.c        (revision 153879)
+++ gcc/config/arm/arm.c        (working copy)
@@ -18915,7 +18915,7 @@
 arm_init_machine_status (void)
 {
   struct machine_function *machine;
-  machine = (machine_function *) ggc_alloc_cleared (sizeof
(machine_function));
+  machine = ggc_alloc_cleared_machine_function();

 #if ARM_FT_UNKNOWN != 0
   machine->func_type = ARM_FT_UNKNOWN;

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [gc-improv] Convert ARM backend
  2009-11-09  9:50 [gc-improv] Convert ARM backend Laurynas Biveinis
@ 2009-11-12 14:55 ` Daniel Jacobowitz
  2009-11-13  9:02   ` Laurynas Biveinis
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Jacobowitz @ 2009-11-12 14:55 UTC (permalink / raw)
  To: Laurynas Biveinis; +Cc: gcc-patches

On Mon, Nov 09, 2009 at 10:19:37AM +0100, Laurynas Biveinis wrote:
> -  machine = (machine_function *) ggc_alloc_cleared (sizeof
> (machine_function));
> +  machine = ggc_alloc_cleared_machine_function();

I happened to notice... you've lost the space before the open
parenthesis.  If you're doing this across a lot of backends, I figured
I'd point it out now before you tried to merge anything :-)

-- 
Daniel Jacobowitz
CodeSourcery

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [gc-improv] Convert ARM backend
  2009-11-12 14:55 ` Daniel Jacobowitz
@ 2009-11-13  9:02   ` Laurynas Biveinis
  0 siblings, 0 replies; 3+ messages in thread
From: Laurynas Biveinis @ 2009-11-13  9:02 UTC (permalink / raw)
  To: drow, gcc-patches

> On Mon, Nov 09, 2009 at 10:19:37AM +0100, Laurynas Biveinis wrote:
>> -  machine = (machine_function *) ggc_alloc_cleared (sizeof
>> (machine_function));
>> +  machine = ggc_alloc_cleared_machine_function();
>
> I happened to notice... you've lost the space before the open
> parenthesis.  If you're doing this across a lot of backends, I figured
> I'd point it out now before you tried to merge anything :-)

Thanks :) I am commiting this fix to gc-improv, tested by rebuilding arm.o.

2009-11-13  Laurynas Biveinis  <laurynas.biveinis@gmail.com>

        * config/arm/arm.c (arm_init_machine_status): Fix whitespace in
        the last commit.

Index: config/arm/arm.c
===================================================================
--- config/arm/arm.c    (revision 154027)
+++ config/arm/arm.c    (working copy)
@@ -18915,7 +18915,7 @@
 arm_init_machine_status (void)
 {
   struct machine_function *machine;
-  machine = ggc_alloc_cleared_machine_function();
+  machine = ggc_alloc_cleared_machine_function ();

 #if ARM_FT_UNKNOWN != 0
   machine->func_type = ARM_FT_UNKNOWN;



-- 
Laurynas

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-11-13  8:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-09  9:50 [gc-improv] Convert ARM backend Laurynas Biveinis
2009-11-12 14:55 ` Daniel Jacobowitz
2009-11-13  9:02   ` Laurynas Biveinis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).