From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from loongson.cn (mail.loongson.cn [114.242.206.163]) by sourceware.org (Postfix) with ESMTP id 007A73858414 for ; Tue, 1 Nov 2022 08:45:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 007A73858414 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [10.20.4.52]) by gateway (Coremail) with SMTP id _____8BxLtug3GBj_r8DAA--.13530S3; Tue, 01 Nov 2022 16:45:21 +0800 (CST) Received: from [10.20.4.52] (unknown [10.20.4.52]) by localhost.localdomain (Coremail) with SMTP id AQAAf8AxDuKg3GBjsmUJAA--.28769S2; Tue, 01 Nov 2022 16:45:20 +0800 (CST) Subject: Re: [PATCH v2] LoongArch: Optimize immediate load. To: Xi Ruoyao , gcc-patches@gcc.gnu.org Cc: i@xen0n.name, xuchenghua@loongson.cn References: <20221101061915.1677615-1-chenglulu@loongson.cn> From: Lulu Cheng Message-ID: Date: Tue, 1 Nov 2022 16:45:20 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-CM-TRANSID:AQAAf8AxDuKg3GBjsmUJAA--.28769S2 X-CM-SenderInfo: xfkh0wpoxo3qxorr0wxvrqhubq/ X-Coremail-Antispam: 1Uk129KBjvJXoW7Ww18CrWrGr1xCFyrCryUJrb_yoW8Jw4Dpr 4kJ34UJry8Jrn3K34UCryUJrWUXr1UJa17AFy8ZF9IkrWxGr1Ygw1Uur9Igr1DAw4rtr17 Jr45XrsrZr13KrJanT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj qI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUU bI8YFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s 1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xv wVC0I7IYx2IY67AKxVW8JVW5JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwA2z4 x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4UJVWxJr1l e2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAqx4xG64xvF2 IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE14v26r1j6r4U McvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCYjI0SjxkI62AI1cAE67vIY487Mx AIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_ Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwI xGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8 JwCI42IY6xAIw20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcV C2z280aVCY1x0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUwmhFDUUUU X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,BODY_8BITS,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: 在 2022/11/1 下午4:02, Xi Ruoyao 写道: > On Tue, 2022-11-01 at 14:19 +0800, Lulu Cheng wrote: >> +;; Load immediate to the 32-63 bits of the source register. >> +(define_insn_and_split "load_hi32" >> +  [(set (match_operand:DI 0 "register_operand" "=r") >> +       (ior:DI >> +         (and:DI (match_operand:DI 1 "register_operand" "0") >> +                 (match_operand 2 "hi32_mask_operand")) >> +       (match_operand 3 "const_hi32_operand" "x")))] >> +  "TARGET_64BIT" >> +  "#" >> +  "" >> +  [(set (match_dup 0) >> +       (ior:DI >> +         (zero_extend:DI >> +           (subreg:SI (match_dup 1) 0)) >> +         (match_dup 4))) >> +   (set (match_dup 0) >> +       (ior:DI >> +         (and:DI (match_dup 0) >> +                 (match_dup 6)) >> +         (match_dup 5)))] >> +{ >> +  operands[4] = GEN_INT (INTVAL (operands[3]) << 12 >> 12); > It's an undefined behavior if INTVAL (operands[3]) is negative. I'm sorry I made the same mistake twice:-( > >> +  operands[5] = GEN_INT (INTVAL (operands[3]) & 0xfff0000000000000); >> +  operands[6] = GEN_INT (0xfffffffffffff); >> +} >> +  [(set_attr "insn_count" "2")])