public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <jeffreyalaw@gmail.com>
To: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: [committed][RISC-V] Fix minor issues in diagnostic message
Date: Mon, 24 Jul 2023 07:59:27 -0600	[thread overview]
Message-ID: <d26218f5-6167-97a7-9f4c-0458b6ba8297@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 636 bytes --]

This fixes two minor issues with the recently added warning about too 
large VLEN in the RISC-V backend.  These prevent the RISC-V port from 
bootstrapping as both Andreas and I have found.

Specifically we'll get warnings for the use of '>' in the recently added 
message as well as using "can not" vs "cannot".  While these warnings 
may seem annoying, they're in place to make it easier for the translators.

This patch fixes the message in the fairly obvious way.  Spells out the 
greater than and uses cannot.  There's a similar issue in another 
recently added diagnostic that I'll push momentarily.

Committed to the trunk,
Jeff

[-- Attachment #2: P --]
[-- Type: text/plain, Size: 1588 bytes --]

commit aa1e2d543869a07580f9b2112f2d7367f83a6753
Author: Jeff Law <jlaw@ventanamicro.com>
Date:   Mon Jul 24 07:56:36 2023 -0600

    [committed][RISC-V] Fix minor issues in diagnostic message
    
    This fixes two minor issues with the recently adding warning about too large
    VLEN in the RISC-V backend.  These prevent the RISC-V port from bootstrapping
    as both Andreas and I have found.
    
    Specifically we'll get warnings for the use of '>' in the recently added
     message as well as using "can not" vs "cannot".  While these warnings may
    seem annoying, they're in place to make it easier for the translators.
    
    This patch fixes the message in the fairly obvious way.  Spells out the
    greater than and uses cannot.  There's a similar issue in another recently
    added diagnostic that I'll push momentarily.
    
    gcc/
            * config/riscv/riscv.cc (riscv_option_override): Spell out
            greater than and use cannot in diagnostic string.

diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc
index 332fa720f01..941ea25e1f2 100644
--- a/gcc/config/riscv/riscv.cc
+++ b/gcc/config/riscv/riscv.cc
@@ -6713,7 +6713,7 @@ riscv_option_override (void)
      We can only allow TARGET_MIN_VLEN * 8 (LMUL) < 65535.  */
   if (TARGET_MIN_VLEN > 4096)
     sorry (
-      "Current RISC-V GCC can not support VLEN > 4096bit for 'V' Extension");
+      "Current RISC-V GCC cannot support VLEN greater than 4096bit for 'V' Extension");
 
   /* Convert -march to a chunks count.  */
   riscv_vector_chunks = riscv_convert_vector_bits ();

                 reply	other threads:[~2023-07-24 13:59 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d26218f5-6167-97a7-9f4c-0458b6ba8297@gmail.com \
    --to=jeffreyalaw@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).