From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 6EFF13969C0B for ; Wed, 18 Aug 2021 19:08:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6EFF13969C0B Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 17IJ339j089178; Wed, 18 Aug 2021 15:08:36 -0400 Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 3ah56hd38t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 Aug 2021 15:08:36 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 17IJ8KJN015440; Wed, 18 Aug 2021 19:08:35 GMT Received: from b01cxnp22033.gho.pok.ibm.com (b01cxnp22033.gho.pok.ibm.com [9.57.198.23]) by ppma01dal.us.ibm.com with ESMTP id 3agfdma5uy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 18 Aug 2021 19:08:34 +0000 Received: from b01ledav001.gho.pok.ibm.com (b01ledav001.gho.pok.ibm.com [9.57.199.106]) by b01cxnp22033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 17IJ8XiZ21954936 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 18 Aug 2021 19:08:33 GMT Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8F8922806D; Wed, 18 Aug 2021 19:08:33 +0000 (GMT) Received: from b01ledav001.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1E35E28058; Wed, 18 Aug 2021 19:08:33 +0000 (GMT) Received: from Bills-MacBook-Pro.local (unknown [9.211.84.147]) by b01ledav001.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 18 Aug 2021 19:08:32 +0000 (GMT) Reply-To: wschmidt@linux.ibm.com Subject: Re: [PATCH 2/6] rs6000: Support SSE4.1 "min" and "max" intrinsics To: "Paul A. Clarke" , gcc-patches@gcc.gnu.org Cc: segher@kernel.crashing.org References: <20210809202355.568303-1-pc@us.ibm.com> <20210809202355.568303-3-pc@us.ibm.com> From: Bill Schmidt Message-ID: Date: Wed, 18 Aug 2021 14:08:32 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210809202355.568303-3-pc@us.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 5fD9NQ7IYC3oSAOrR-BE2nJ5X-5UPaIB X-Proofpoint-GUID: 5fD9NQ7IYC3oSAOrR-BE2nJ5X-5UPaIB X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.790 definitions=2021-08-18_07:2021-08-17, 2021-08-18 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 clxscore=1015 malwarescore=0 bulkscore=0 mlxscore=0 mlxlogscore=999 phishscore=0 suspectscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108180118 X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2021 19:08:47 -0000 Hi Paul, On 8/9/21 3:23 PM, Paul A. Clarke via Gcc-patches wrote: > Also, copy tests for _mm_min_epi8, _mm_min_epu16, _mm_min_epi32, > _mm_min_epu32, _mm_max_epi8, _mm_max_epu16, _mm_max_epi32, _mm_max_epu32 > from gcc/testsuite/gcc.target/i386. > > sse4_1-pmaxsb.c and sse4_1-pminsb.c were modified from using > "char" types to "signed char" types, because the default is unsigned on > powerpc. Where tested, do you want backports, etc... > > 2021-08-09 Paul A. Clarke > > gcc > * config/rs6000/smmintrin.h (_mm_min_epi8, _mm_min_epu16, > _mm_min_epi32, _mm_min_epu32, _mm_max_epi8, _mm_max_epu16, > _mm_max_epi32, _mm_max_epu32): New. > > gcc/testsuite > * gcc.target/powerpc/sse4_1-pmaxsb.c: Copy from gcc.target/i386. > * gcc.target/powerpc/sse4_1-pmaxsd.c: Same. > * gcc.target/powerpc/sse4_1-pmaxud.c: Same. > * gcc.target/powerpc/sse4_1-pmaxuw.c: Same. > * gcc.target/powerpc/sse4_1-pminsb.c: Same. > * gcc.target/powerpc/sse4_1-pminsd.c: Same. > * gcc.target/powerpc/sse4_1-pminud.c: Same. > * gcc.target/powerpc/sse4_1-pminuw.c: Same. > --- > gcc/config/rs6000/smmintrin.h | 56 +++++++++++++++++++ > .../gcc.target/powerpc/sse4_1-pmaxsb.c | 46 +++++++++++++++ > .../gcc.target/powerpc/sse4_1-pmaxsd.c | 46 +++++++++++++++ > .../gcc.target/powerpc/sse4_1-pmaxud.c | 47 ++++++++++++++++ > .../gcc.target/powerpc/sse4_1-pmaxuw.c | 47 ++++++++++++++++ > .../gcc.target/powerpc/sse4_1-pminsb.c | 46 +++++++++++++++ > .../gcc.target/powerpc/sse4_1-pminsd.c | 46 +++++++++++++++ > .../gcc.target/powerpc/sse4_1-pminud.c | 47 ++++++++++++++++ > .../gcc.target/powerpc/sse4_1-pminuw.c | 47 ++++++++++++++++ > 9 files changed, 428 insertions(+) > create mode 100644 gcc/testsuite/gcc.target/powerpc/sse4_1-pmaxsb.c > create mode 100644 gcc/testsuite/gcc.target/powerpc/sse4_1-pmaxsd.c > create mode 100644 gcc/testsuite/gcc.target/powerpc/sse4_1-pmaxud.c > create mode 100644 gcc/testsuite/gcc.target/powerpc/sse4_1-pmaxuw.c > create mode 100644 gcc/testsuite/gcc.target/powerpc/sse4_1-pminsb.c > create mode 100644 gcc/testsuite/gcc.target/powerpc/sse4_1-pminsd.c > create mode 100644 gcc/testsuite/gcc.target/powerpc/sse4_1-pminud.c > create mode 100644 gcc/testsuite/gcc.target/powerpc/sse4_1-pminuw.c > > diff --git a/gcc/config/rs6000/smmintrin.h b/gcc/config/rs6000/smmintrin.h > index 862e78ac7d60..f7f03d8d7782 100644 > --- a/gcc/config/rs6000/smmintrin.h > +++ b/gcc/config/rs6000/smmintrin.h > @@ -414,6 +414,62 @@ _mm_test_mix_ones_zeros (__m128i __A, __m128i __mask) > return any_ones * any_zeros; > } > > +__inline __m128i > +__attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) > +_mm_min_epi8 (__m128i __X, __m128i __Y) > +{ > + return (__m128i) vec_min ((__v16qi)__X, (__v16qi)__Y); > +} > + > +__inline __m128i > +__attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) > +_mm_min_epu16 (__m128i __X, __m128i __Y) > +{ > + return (__m128i) vec_min ((__v8hu)__X, (__v8hu)__Y); > +} > + > +__inline __m128i > +__attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) > +_mm_min_epi32 (__m128i __X, __m128i __Y) > +{ > + return (__m128i) vec_min ((__v4si)__X, (__v4si)__Y); > +} > + > +__inline __m128i > +__attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) > +_mm_min_epu32 (__m128i __X, __m128i __Y) > +{ > + return (__m128i) vec_min ((__v4su)__X, (__v4su)__Y); > +} > + > +__inline __m128i > +__attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) > +_mm_max_epi8 (__m128i __X, __m128i __Y) > +{ > + return (__m128i) vec_max ((__v16qi)__X, (__v16qi)__Y); > +} > + > +__inline __m128i > +__attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) > +_mm_max_epu16 (__m128i __X, __m128i __Y) > +{ > + return (__m128i) vec_max ((__v8hu)__X, (__v8hu)__Y); > +} > + > +__inline __m128i > +__attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) > +_mm_max_epi32 (__m128i __X, __m128i __Y) > +{ > + return (__m128i) vec_max ((__v4si)__X, (__v4si)__Y); > +} > + > +__inline __m128i > +__attribute__ ((__gnu_inline__, __always_inline__, __artificial__)) > +_mm_max_epu32 (__m128i __X, __m128i __Y) > +{ > + return (__m128i) vec_max ((__v4su)__X, (__v4su)__Y); > +} > + I guess these are all integers, so we don't have to worry about fast-math semantics.  OK. > /* Return horizontal packed word minimum and its index in bits [15:0] > and bits [18:16] respectively. */ > __inline __m128i > diff --git a/gcc/testsuite/gcc.target/powerpc/sse4_1-pmaxsb.c b/gcc/testsuite/gcc.target/powerpc/sse4_1-pmaxsb.c > new file mode 100644 > index 000000000000..24a74da309b0 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/powerpc/sse4_1-pmaxsb.c > @@ -0,0 +1,46 @@ > +/* { dg-do run } */ > +/* { dg-require-effective-target powerpc_vsx_ok } */ > +/* { dg-options "-O2 -mvsx -Wno-psabi" } */ Please check/document -Wno-psabi.  Otherwise the patch looks fine to me.  I won't hold you responsible for style issues in the x86 tests. :-) Thanks! Bill > + > +#ifndef CHECK_H > +#define CHECK_H "sse4_1-check.h" > +#endif > + > +#ifndef TEST > +#define TEST sse4_1_test > +#endif > + > +#include CHECK_H > + > +#include > + > +#define NUM 1024 > + > +static void > +TEST (void) > +{ > + union > + { > + __m128i x[NUM / 16]; > + signed char i[NUM]; > + } dst, src1, src2; > + int i, sign = 1; > + signed char max; > + > + for (i = 0; i < NUM; i++) > + { > + src1.i[i] = i * i * sign; > + src2.i[i] = (i + 20) * sign; > + sign = -sign; > + } > + > + for (i = 0; i < NUM; i += 16) > + dst.x[i / 16] = _mm_max_epi8 (src1.x[i / 16], src2.x[i / 16]); > + > + for (i = 0; i < NUM; i++) > + { > + max = src1.i[i] <= src2.i[i] ? src2.i[i] : src1.i[i]; > + if (max != dst.i[i]) > + abort (); > + } > +} > diff --git a/gcc/testsuite/gcc.target/powerpc/sse4_1-pmaxsd.c b/gcc/testsuite/gcc.target/powerpc/sse4_1-pmaxsd.c > new file mode 100644 > index 000000000000..87638457f883 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/powerpc/sse4_1-pmaxsd.c > @@ -0,0 +1,46 @@ > +/* { dg-do run } */ > +/* { dg-require-effective-target powerpc_vsx_ok } */ > +/* { dg-options "-O2 -mvsx -Wno-psabi" } */ > + > +#ifndef CHECK_H > +#define CHECK_H "sse4_1-check.h" > +#endif > + > +#ifndef TEST > +#define TEST sse4_1_test > +#endif > + > +#include CHECK_H > + > +#include > + > +#define NUM 64 > + > +static void > +TEST (void) > +{ > + union > + { > + __m128i x[NUM / 4]; > + int i[NUM]; > + } dst, src1, src2; > + int i, sign = 1; > + int max; > + > + for (i = 0; i < NUM; i++) > + { > + src1.i[i] = i * i * sign; > + src2.i[i] = (i + 20) * sign; > + sign = -sign; > + } > + > + for (i = 0; i < NUM; i += 4) > + dst.x[i / 4] = _mm_max_epi32 (src1.x[i / 4], src2.x[i / 4]); > + > + for (i = 0; i < NUM; i++) > + { > + max = src1.i[i] <= src2.i[i] ? src2.i[i] : src1.i[i]; > + if (max != dst.i[i]) > + abort (); > + } > +} > diff --git a/gcc/testsuite/gcc.target/powerpc/sse4_1-pmaxud.c b/gcc/testsuite/gcc.target/powerpc/sse4_1-pmaxud.c > new file mode 100644 > index 000000000000..a43728aef700 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/powerpc/sse4_1-pmaxud.c > @@ -0,0 +1,47 @@ > +/* { dg-do run } */ > +/* { dg-require-effective-target powerpc_vsx_ok } */ > +/* { dg-options "-O2 -mvsx -Wno-psabi" } */ > + > +#ifndef CHECK_H > +#define CHECK_H "sse4_1-check.h" > +#endif > + > +#ifndef TEST > +#define TEST sse4_1_test > +#endif > + > +#include CHECK_H > + > +#include > + > +#define NUM 64 > + > +static void > +TEST (void) > +{ > + union > + { > + __m128i x[NUM / 4]; > + unsigned int i[NUM]; > + } dst, src1, src2; > + int i; > + unsigned int max; > + > + for (i = 0; i < NUM; i++) > + { > + src1.i[i] = i * i; > + src2.i[i] = i + 20; > + if ((i % 4)) > + src2.i[i] |= 0x80000000; > + } > + > + for (i = 0; i < NUM; i += 4) > + dst.x[i / 4] = _mm_max_epu32 (src1.x[i / 4], src2.x[i / 4]); > + > + for (i = 0; i < NUM; i++) > + { > + max = src1.i[i] <= src2.i[i] ? src2.i[i] : src1.i[i]; > + if (max != dst.i[i]) > + abort (); > + } > +} > diff --git a/gcc/testsuite/gcc.target/powerpc/sse4_1-pmaxuw.c b/gcc/testsuite/gcc.target/powerpc/sse4_1-pmaxuw.c > new file mode 100644 > index 000000000000..2ceac84f6d8d > --- /dev/null > +++ b/gcc/testsuite/gcc.target/powerpc/sse4_1-pmaxuw.c > @@ -0,0 +1,47 @@ > +/* { dg-do run } */ > +/* { dg-require-effective-target powerpc_vsx_ok } */ > +/* { dg-options "-O2 -mvsx -Wno-psabi" } */ > + > +#ifndef CHECK_H > +#define CHECK_H "sse4_1-check.h" > +#endif > + > +#ifndef TEST > +#define TEST sse4_1_test > +#endif > + > +#include CHECK_H > + > +#include > + > +#define NUM 64 > + > +static void > +TEST (void) > +{ > + union > + { > + __m128i x[NUM / 8]; > + unsigned short i[NUM]; > + } dst, src1, src2; > + int i; > + unsigned short max; > + > + for (i = 0; i < NUM; i++) > + { > + src1.i[i] = i * i; > + src2.i[i] = i + 20; > + if ((i % 8)) > + src2.i[i] |= 0x8000; > + } > + > + for (i = 0; i < NUM; i += 8) > + dst.x[i / 8] = _mm_max_epu16 (src1.x[i / 8], src2.x[i / 8]); > + > + for (i = 0; i < NUM; i++) > + { > + max = src1.i[i] <= src2.i[i] ? src2.i[i] : src1.i[i]; > + if (max != dst.i[i]) > + abort (); > + } > +} > diff --git a/gcc/testsuite/gcc.target/powerpc/sse4_1-pminsb.c b/gcc/testsuite/gcc.target/powerpc/sse4_1-pminsb.c > new file mode 100644 > index 000000000000..61aee9a8b4b4 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/powerpc/sse4_1-pminsb.c > @@ -0,0 +1,46 @@ > +/* { dg-do run } */ > +/* { dg-require-effective-target powerpc_vsx_ok } */ > +/* { dg-options "-O2 -mvsx -Wno-psabi" } */ > + > +#ifndef CHECK_H > +#define CHECK_H "sse4_1-check.h" > +#endif > + > +#ifndef TEST > +#define TEST sse4_1_test > +#endif > + > +#include CHECK_H > + > +#include > + > +#define NUM 1024 > + > +static void > +TEST (void) > +{ > + union > + { > + __m128i x[NUM / 16]; > + signed char i[NUM]; > + } dst, src1, src2; > + int i, sign = 1; > + signed char min; > + > + for (i = 0; i < NUM; i++) > + { > + src1.i[i] = i * i * sign; > + src2.i[i] = (i + 20) * sign; > + sign = -sign; > + } > + > + for (i = 0; i < NUM; i += 16) > + dst.x[i / 16] = _mm_min_epi8 (src1.x[i / 16], src2.x[i / 16]); > + > + for (i = 0; i < NUM; i++) > + { > + min = src1.i[i] >= src2.i[i] ? src2.i[i] : src1.i[i]; > + if (min != dst.i[i]) > + abort (); > + } > +} > diff --git a/gcc/testsuite/gcc.target/powerpc/sse4_1-pminsd.c b/gcc/testsuite/gcc.target/powerpc/sse4_1-pminsd.c > new file mode 100644 > index 000000000000..68d8a0a6c848 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/powerpc/sse4_1-pminsd.c > @@ -0,0 +1,46 @@ > +/* { dg-do run } */ > +/* { dg-require-effective-target powerpc_vsx_ok } */ > +/* { dg-options "-O2 -mvsx -Wno-psabi" } */ > + > +#ifndef CHECK_H > +#define CHECK_H "sse4_1-check.h" > +#endif > + > +#ifndef TEST > +#define TEST sse4_1_test > +#endif > + > +#include CHECK_H > + > +#include > + > +#define NUM 64 > + > +static void > +TEST (void) > +{ > + union > + { > + __m128i x[NUM / 4]; > + int i[NUM]; > + } dst, src1, src2; > + int i, sign = 1; > + int min; > + > + for (i = 0; i < NUM; i++) > + { > + src1.i[i] = i * i * sign; > + src2.i[i] = (i + 20) * sign; > + sign = -sign; > + } > + > + for (i = 0; i < NUM; i += 4) > + dst.x[i / 4] = _mm_min_epi32 (src1.x[i / 4], src2.x[i / 4]); > + > + for (i = 0; i < NUM; i++) > + { > + min = src1.i[i] >= src2.i[i] ? src2.i[i] : src1.i[i]; > + if (min != dst.i[i]) > + abort (); > + } > +} > diff --git a/gcc/testsuite/gcc.target/powerpc/sse4_1-pminud.c b/gcc/testsuite/gcc.target/powerpc/sse4_1-pminud.c > new file mode 100644 > index 000000000000..8398e2231f29 > --- /dev/null > +++ b/gcc/testsuite/gcc.target/powerpc/sse4_1-pminud.c > @@ -0,0 +1,47 @@ > +/* { dg-do run } */ > +/* { dg-require-effective-target powerpc_vsx_ok } */ > +/* { dg-options "-O2 -mvsx -Wno-psabi" } */ > + > +#ifndef CHECK_H > +#define CHECK_H "sse4_1-check.h" > +#endif > + > +#ifndef TEST > +#define TEST sse4_1_test > +#endif > + > +#include CHECK_H > + > +#include > + > +#define NUM 64 > + > +static void > +TEST (void) > +{ > + union > + { > + __m128i x[NUM / 4]; > + unsigned int i[NUM]; > + } dst, src1, src2; > + int i; > + unsigned int min; > + > + for (i = 0; i < NUM; i++) > + { > + src1.i[i] = i * i; > + src2.i[i] = i + 20; > + if ((i % 4)) > + src2.i[i] |= 0x80000000; > + } > + > + for (i = 0; i < NUM; i += 4) > + dst.x[i / 4] = _mm_min_epu32 (src1.x[i / 4], src2.x[i / 4]); > + > + for (i = 0; i < NUM; i++) > + { > + min = src1.i[i] >= src2.i[i] ? src2.i[i] : src1.i[i]; > + if (min != dst.i[i]) > + abort (); > + } > +} > diff --git a/gcc/testsuite/gcc.target/powerpc/sse4_1-pminuw.c b/gcc/testsuite/gcc.target/powerpc/sse4_1-pminuw.c > new file mode 100644 > index 000000000000..abbd7c07b3bc > --- /dev/null > +++ b/gcc/testsuite/gcc.target/powerpc/sse4_1-pminuw.c > @@ -0,0 +1,47 @@ > +/* { dg-do run } */ > +/* { dg-require-effective-target powerpc_vsx_ok } */ > +/* { dg-options "-O2 -mvsx -Wno-psabi" } */ > + > +#ifndef CHECK_H > +#define CHECK_H "sse4_1-check.h" > +#endif > + > +#ifndef TEST > +#define TEST sse4_1_test > +#endif > + > +#include CHECK_H > + > +#include > + > +#define NUM 64 > + > +static void > +TEST (void) > +{ > + union > + { > + __m128i x[NUM / 8]; > + unsigned short i[NUM]; > + } dst, src1, src2; > + int i; > + unsigned short min; > + > + for (i = 0; i < NUM; i++) > + { > + src1.i[i] = i * i; > + src2.i[i] = i + 20; > + if ((i % 8)) > + src2.i[i] |= 0x8000; > + } > + > + for (i = 0; i < NUM; i += 8) > + dst.x[i / 8] = _mm_min_epu16 (src1.x[i / 8], src2.x[i / 8]); > + > + for (i = 0; i < NUM; i++) > + { > + min = src1.i[i] >= src2.i[i] ? src2.i[i] : src1.i[i]; > + if (min != dst.i[i]) > + abort (); > + } > +}