From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id A42B43858429 for ; Wed, 29 May 2024 06:41:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A42B43858429 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=baylibre.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A42B43858429 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32c ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716964870; cv=none; b=ItCKG4+ZfeO7sYl52mnSe+K9rMmp51ZPzq9qS17lV32Sk9OFhSaEtBI48mJPGfSLlcXtKyy8OninGPgQh80/zVJZApOp7R2bU5n53GYNJeZRrnq/adFyoQIRY64K7SnHFR84Lb3LZ1fhsVSlrm7fhtBQA4hixH9t5Y+cBzjC0yc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1716964870; c=relaxed/simple; bh=8/N81m/oPVlK1ExCAn0BxLA/kZ7EVaPFYtl4x5xZ6Zw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=AB62xoBSyPN48oNdCHzFBFpPn11d+WOduL6Hauxh+732BJZ7e1zjwFiXqlPuZq1f2S1KYZeZn0TG+PM1Ky+FtL088NE2lqa/Hfmantcu1BVzxyTsXQInYjYDGMlxMTHmKzOZR6YvwentUdrYkGGBKHwX7KMQNRJS9wR1tu13PuI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-42101a2ac2cso14570505e9.0 for ; Tue, 28 May 2024 23:41:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1716964866; x=1717569666; darn=gcc.gnu.org; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=eiHy9w+TSEHSlNNwpNBHFZAVw0/RlH9M9lRjiPYUYSU=; b=wPy1QWIyZ3zJFivE/NyHhX6SsVestrEgv42oVmsMV9dOM+EnS/x46+O7jVKjeuFVJW ZZVQf0FtEbANEIubfWMOws7JNX/GOZJJLY+Xk3snS82kaBPMp4NhgSRdLEOYu+8DNf6y o/eB1qfXT5G2dbIjFhq3PN6CRqioYPphmP4iUrWBJ4KaonpiEcL/uFvuvnG8iZh6KKDN 6VVnjwIyacC8+iUWHJoleOvOGKB9DRp1iyYt6hyypwYwF5tmWbG6u6beQu0V7wbLusnK zTxAcC8wmE2m20UigOk04UIXEnemkolyo/gOqcPyQ/RgHc4KJ/Ea40Vo7xLIV2JQzBX/ Bt5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716964866; x=1717569666; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=eiHy9w+TSEHSlNNwpNBHFZAVw0/RlH9M9lRjiPYUYSU=; b=hypG4KoHmFSKz5EahM5CmrBNZBsJv2Lxvu7WsmK1c22zE8PO0JRzPTlauXal3ITJvq 57N8kbFBJLDc67KVhIvTzarvpn6TjK/Nsphhpc1vHrVp/CiwHZu6DF6cnIUdFu+Nhh7U HZhvoOKi0TRyJGLlSY/k34xhRw8WoerMznla+V56rY1x+AYQ6s00zKcz/0wgUnQNcZjy EZJV7enCkLb2LDfMJrp3pbAys75ERohlzKD96HoG1FEzWjW5bdiZKiuQRoIeK1TS5+HE t5yWaQp5RsbKz0c6fwPwRqh4rH0KEhD7FzvTClSS6oiYjGXk7ixGf4YAXgjHA398oi4P inLA== X-Gm-Message-State: AOJu0Yy8PHnVTrx9B7nmLYNCOGxAbTByqTzxhZBDf8EAh25jt+570Tc0 D4HIgm95mEatyHGVBjKNw3WWxBjVTQZ/xZOwISvpuiRY+YgNlVIWZm4a6+VvdjM= X-Google-Smtp-Source: AGHT+IFlTlkX3QjxcmHub503HfGbQUi2dcSs6/NYlebM1n1k5JrvO/rJeygKbZ3B4ijzRVCJNDNVfw== X-Received: by 2002:a05:600c:358a:b0:421:1f6f:3e15 with SMTP id 5b1f17b1804b1-4211f6f3f19mr32101405e9.16.1716964866207; Tue, 28 May 2024 23:41:06 -0700 (PDT) Received: from ?IPV6:2001:16b8:3fa8:ee00:bc0d:b5a:797b:a391? ([2001:16b8:3fa8:ee00:bc0d:b5a:797b:a391]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-421089cca86sm166703125e9.42.2024.05.28.23.41.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 May 2024 23:41:05 -0700 (PDT) Content-Type: multipart/alternative; boundary="------------lMykLvsr51DkUorVfElEkt0e" Message-ID: Date: Wed, 29 May 2024 08:41:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [patch] OpenMP: Add -fopenmp-force-usm mode To: Jakub Jelinek Cc: gcc-patches References: Content-Language: en-US From: Tobias Burnus In-Reply-To: X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------lMykLvsr51DkUorVfElEkt0e Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Jakub Jelinek wrote: > How is that option different from > echo '#pragma omp requires unified_shared_memory' > omp-usm.h > gcc -include omp-usm.h > ? > I mean with -include you can add anything you want, not just one particular > directive, and adding a separate option for each is just weird. For C/C++, -include seems to be indeed sufficient (albeit not widely known). For Fortran, there at two issues: One placement/semantic issue: it has to be added per "compilation unit", i.e. to the specification part of a module, subprogram or main program. And a practical issue, gfortran shows: error: command-line option '-include !$omp requires' is valid for C/C++/ObjC/ObjC++ but not for Fortran Thus, for Fortran it is still intrinsically useful – even if one can argue whether that feature is needed at all / whether it should be added as command-line argument. Tobias --------------lMykLvsr51DkUorVfElEkt0e--