From: Jeff Law <law@redhat.com>
To: Martin Sebor <msebor@gmail.com>,
Gcc Patch List <gcc-patches@gcc.gnu.org>
Subject: Re: PING #2 [PATCH] handle expressions in __builtin_has_attribute (PR 88383)
Date: Thu, 17 Jan 2019 01:16:00 -0000 [thread overview]
Message-ID: <d2cb4a4e-9f32-cdbe-c22f-093c4c218fc1@redhat.com> (raw)
In-Reply-To: <2ffcff76-844d-87b7-2f5c-2bbc35cf63b5@gmail.com>
On 1/15/19 9:31 AM, Martin Sebor wrote:
> Ping: https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00337.html
>
> Jeff, do you have any more questions/concerns or is this patch
> good to commit?
I think both Jakub and I were concerned about handling expressions in
this code. I don't recall a resolution on that fundamental question.
jeff
prev parent reply other threads:[~2019-01-17 1:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 3:56 Martin Sebor
2018-12-13 18:59 ` Jeff Law
2018-12-13 19:21 ` Martin Sebor
2018-12-13 19:48 ` Martin Sebor
2018-12-13 19:56 ` Jakub Jelinek
2018-12-13 22:22 ` Martin Sebor
2018-12-13 23:40 ` Jakub Jelinek
2018-12-14 4:04 ` Martin Sebor
2018-12-14 7:41 ` Jakub Jelinek
2018-12-15 0:18 ` Martin Sebor
2018-12-21 2:56 ` Martin Sebor
2019-01-03 22:22 ` PING " Martin Sebor
2019-01-08 0:32 ` PING #2 " Martin Sebor
2019-01-15 16:31 ` Martin Sebor
2019-01-17 1:16 ` Jeff Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2cb4a4e-9f32-cdbe-c22f-093c4c218fc1@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).