From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 1E8013858D38 for ; Tue, 13 Jun 2023 16:28:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E8013858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-6563ccf5151so6104704b3a.0 for ; Tue, 13 Jun 2023 09:28:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686673696; x=1689265696; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gU2oUvEFn6oGe4jDFXiPBoRwo06EmNYQJ7Q/VC53AUY=; b=YOnz8G3rsINd3Sp4XLqTU109EvcX5n4XejMAvm3ETpzP4eW8d8EsdV4USnCc74/X02 X31vFNO/FJnHy4WiR3efnK5Btg6xI+9ATgquMB53bahL5F4KU+aVPmBtSlieQrMYvtaP zvXvHCYq3K2IDHEuOCENHQYNgSlI5Bv3xQgeBn+IsY2K8Udh7kNV7Dzr0GXvAanLV5KN /FXqe9xJWLzBhJns+C85VDFxet0vc+uxkBu/7OlSBaqc6ypuL9151QKhwsw9kKsq/5Br qEpO2w2F5pmPrl3KgBlEOKqPpVEpP1r/MvNrVp0IW3AENY5wvv6dwdigOlFLatRe8piU 10Kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686673696; x=1689265696; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gU2oUvEFn6oGe4jDFXiPBoRwo06EmNYQJ7Q/VC53AUY=; b=bGRh5klyJtBDL7o/BBKy9uG3+6XOE8bppqkuQvqVOzAdopcKE+ceZ/BL7iLm+sMah2 t9bbsOfxbqTVRhiWa5kGKNy2J71oYAwY0iCmwPV0AoQs/5q54iA6edYJtZoWFejqQiqM OajzneuM8TWN3JGh9JXFjprCQKlIuAb9vtGLxTsrAVu+OmQrn8DyxAsw21XWaqA3cjZ0 qzltiF3iE0fmXdfdnRPIEnkawuTkkFNwRun+8PhwaF1cyTV4xpAdBmmx4a+J/oOgoyr4 POe6TkoRIV/OvnhP0cryfZ6bHoitbyFdLbOZHc56aTVnEriBplCUxVTLd5Z1Uk+OeXMI wsqw== X-Gm-Message-State: AC+VfDwCRfYtqySlDrb6Sg3WnS9VaA5HMGVQCtFvqmR6bn7QFoFFeRTa nLmioqa+5FXDEjKhvkGAGAk= X-Google-Smtp-Source: ACHHUZ5m8f0iKTijHeD6Ga/inTIJ1wJgCUNRTzvzeifeO/mTPncd5fgcLUZTVxG/xfwf0E2gm1dzCw== X-Received: by 2002:a05:6a00:84a:b0:655:89f1:2db8 with SMTP id q10-20020a056a00084a00b0065589f12db8mr17830431pfk.16.1686673696013; Tue, 13 Jun 2023 09:28:16 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id t12-20020a62ea0c000000b0064cca73d911sm8820816pfh.103.2023.06.13.09.28.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 13 Jun 2023 09:28:15 -0700 (PDT) Message-ID: Date: Tue, 13 Jun 2023 10:28:14 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] vect: Vectorize via libfuncs Content-Language: en-US To: Andrew Stubbs , "gcc-patches@gcc.gnu.org" References: <0e5fddf8-8605-a0d6-eede-1a8fcf12535c@codesourcery.com> From: Jeff Law In-Reply-To: <0e5fddf8-8605-a0d6-eede-1a8fcf12535c@codesourcery.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/13/23 09:55, Andrew Stubbs wrote: > Subject: > [PATCH] vect: Vectorize via libfuncs > From: > Andrew Stubbs > Date: > 6/13/23, 09:55 > > To: > "gcc-patches@gcc.gnu.org" > > > This patch allows vectorization when operators are available as > libfuncs, rather that only as insns. > > This will be useful for amdgcn where we plan to vectorize loops that > contain integer division or modulus, but don't want to generate inline > instructions for the division algorithm every time. > > The change should have not affect architectures that do not define > vector-mode libfuncs. > > OK for mainline? > > Andrew > > 230613-vect-allow-libfuncs.patch > > vect: vectorize via libfuncs > > This patch allows vectorization when the libfuncs are defined. > > gcc/ChangeLog: > > * tree-vect-generic.cc: Include optabs-libfuncs.h. > (get_compute_type): Check optab_libfunc. > * tree-vect-stmts.cc: Include optabs-libfuncs.h. > (vectorizable_operation): Check optab_libfunc. > > diff --git a/gcc/tree-vect-generic.cc b/gcc/tree-vect-generic.cc > index b7d4a919c55..4d784a70c0d 100644 > --- a/gcc/tree-vect-generic.cc > +++ b/gcc/tree-vect-generic.cc > @@ -44,6 +44,7 @@ along with GCC; see the file COPYING3. If not see > #include "gimple-fold.h" > #include "gimple-match.h" > #include "recog.h" /* FIXME: for insn_data */ > +#include "optabs-libfuncs.h" > > > /* Build a ternary operation and gimplify it. Emit code before GSI. > @@ -1714,7 +1715,8 @@ get_compute_type (enum tree_code code, optab op, tree type) > machine_mode compute_mode = TYPE_MODE (compute_type); > if (VECTOR_MODE_P (compute_mode)) > { > - if (op && optab_handler (op, compute_mode) != CODE_FOR_nothing) > + if (op && (optab_handler (op, compute_mode) != CODE_FOR_nothing > + || optab_libfunc (op, compute_mode))) Formatting nit. Bring the && down and align it under OP. That'll require re-indenting the optab_libfunc call as well. OK with that nit. jeff