From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x29.google.com (mail-oa1-x29.google.com [IPv6:2001:4860:4864:20::29]) by sourceware.org (Postfix) with ESMTPS id 2DDF13858C54 for ; Wed, 7 Jun 2023 02:54:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2DDF13858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-19f30256921so7534024fac.1 for ; Tue, 06 Jun 2023 19:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686106487; x=1688698487; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZVC2KiTWJgTLMT20IPmQCw4WGgaC6+dMAVm1H28DOgQ=; b=D+BPoTr+nMmPxSq3H4XlBmkFXqqJhHuLteLheHAl1GNCy7AbPbI+TmrETu49tGHdgB VOUeykUOP3uoTIPO44CUl0atxGyhQNKB28ocaDKo99kaW+L9sq0qvE7MM+qe87fcBuQJ rQZGxvyl1xI+qwQwMYrlNaAs26HGJKP2Wp9hFusGJCAXuzGj/ctc1Hbrg00AfAe93rnp JqTQ6spuw0NV/9Hjp2DONflvV2NjLAadHA9YHT9irCMAxGeXsltpKxQ/gTzDle9FeoNW G2t7B1AXwI+GlAdTdP/HtsDXfSTYuMLZl7ejWtBfudL2MLPd4qh+YIHDYT02o27nRdj7 aXQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686106487; x=1688698487; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZVC2KiTWJgTLMT20IPmQCw4WGgaC6+dMAVm1H28DOgQ=; b=fj134n/c2PxiFu94X1YU+YobSkfeIPV+n10irlh57an0uSTvbXD8gXCI4A6g+sMEAZ 9qAkYyT4ABasp+1balxH/oQc/zPjuaSPE8O5DaxOEmQ0i6f9K4Rx7xK9iphl4qJA8CfY 1k68D8b2L+AgcfRxzRCmvs2cS27RQrwKBr92AllUjgDgICVFpnl98jPpkLZ9Q6yfnDYM bUKFTvj4jpZqgurI3muDVRcUSha3zVdZ4OuUugFGlrratcAQcCJmRGxSyk/7K09PLDBw l0YIXTHkdXNEvs0IHllNWK+tkIhSnzamszJFQQasC11vN/LC/FgKnO9/xuD3IFEv0/UR M0ww== X-Gm-Message-State: AC+VfDzkW+s0AAqbQLi2aytWZ/fd/6XyZ3ClgbUzR8LShVZ2fF27kVsf f6foJHyM1pz/mp8JuuvR4Y7XKc16nNE= X-Google-Smtp-Source: ACHHUZ6FUB0r7DkriBaVK2+Qep0clUVpsfhpwhlsekEN/N7avOaK5yNhao7l1FdnHNtpn7ELXDvc2Q== X-Received: by 2002:a05:6871:4e95:b0:19d:cf95:ca9 with SMTP id uk21-20020a0568714e9500b0019dcf950ca9mr5857903oab.54.1686106487573; Tue, 06 Jun 2023 19:54:47 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id f16-20020a63f750000000b00528da88275bsm8011495pgk.47.2023.06.06.19.54.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jun 2023 19:54:47 -0700 (PDT) Message-ID: Date: Tue, 6 Jun 2023 20:54:46 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/2] Improve do_store_flag for single bit when there is no non-zero bits Content-Language: en-US To: Andrew Pinski , gcc-patches@gcc.gnu.org References: <20230605055331.2864335-1-apinski@marvell.com> From: Jeff Law In-Reply-To: <20230605055331.2864335-1-apinski@marvell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/4/23 23:53, Andrew Pinski via Gcc-patches wrote: > In r14-1534-g908e5ab5c11c, I forgot you could turn off CCP or > turn off the bit tracking part of CCP so we would lose out > what TER was able to do before hand. This moves around the > TER code so that it is used instead of just the nonzerobits. > It also makes it easier to remove the TER part of the code > later on too. Given that we want to kill TER, that seems like a good idea :-) > > OK? Bootstrapped and tested on x86_64-linux-gnu. > > Note it reintroduces PR 110117 (which was accidently fixed after > r14-1534-g908e5ab5c11c). The next patch in series will fix that. > > gcc/ChangeLog: > > * expr.cc (do_store_flag): Rearrange the > TER code so that it overrides the nonzero bits > info if we had `a & POW2`. OK. jeff