From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2074.outbound.protection.outlook.com [40.107.15.74]) by sourceware.org (Postfix) with ESMTPS id 48DBF3858C31 for ; Wed, 27 Mar 2024 10:19:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 48DBF3858C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 48DBF3858C31 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.15.74 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1711534744; cv=pass; b=e8sigzyxRYnm1MIEG7zqpPjI5VLDEGNcBZJ4AUoI2ubUtbvSvqPDTJMOr6IYnj5aopjRs4JUmvfOq8JR5Hh4sDTuSXbpE3o8Qg2GairxBDIh4GF66jKQBwhtDs5PBaBe283mSRu9IfpPEtutjvBpTrxSfZWQjw9Xu/VQfEyifvk= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1711534744; c=relaxed/simple; bh=zwUmeLkS8+HZEjjLhQihHyAMIAVLGu+Kz1KQdJQpLII=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=GiBYQ0jCf+DqbBnONPZDhaNXGM6U+/O7senJr685t5hRytKACoCnWOwy7H3aCIul9Ys5iIbaQfGFGE5IQqU7dyvbZbvRfWEYpWZa/sI6lF3PMwoDwK2/jhIvaYPugPZcsOomOgQpx+YVd0rOi7F4H328uTfKMfJ3Eq7nooYx36A= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dpE6r85tX0xADjZzODgbbPPBNVNcccvlTWU1KHpLtm9KpyjneLNfR4K2dAeqXZxm8iEfIlrrCr14rkD/1VeP9sPxe+0rIsYBIdyIvY3sQ9cTH0dBLNiaMb/iiXRNx4Qaoio7Mgp1brqvMKwm7x11ua3ztt7yeyDL8uVhHDpO4ytDLC+hjizAHmYFODjVG/2UOu0sSOVAzMVAsAMqHjhyb1W+klbF6Adom1sy0m3e9yp62bVe5cSFz49CnZ8Sc8xfpvXX1J8Z29GnHtzDZj1gU8dGq/4kJUvmxnhCHxwW8L3XmAOtJpYS8/Yl0F1VqFF+hyxNEjeGz0v137WyMgbGgA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xhs4/noHRSpuZeTMbQgny9jP6ltEUgfGNICl3ngqzLw=; b=Ohf67HnXGixUvsIiPB1fXYc6T+2RthcfIMMLJ5l2+ecrfAmI6IQA3sVNkEALdggL26j3hnMwuf3LNjmhxPyz1II55xb3sD8F67lM2IkSBwYHUDlkt8DVTFPbhoA0dCBtZMdJ/lqCFdO66FI8DJY91KjI6r8tntzZ3uCcbtzLDtfg6RPDnm1z6eUKKdS/s1lYw2rF5k4S9zqB1JaM6kslusCfWGw+O6eSD5nrW2ya0LH3tiDAVz2TOVpj130FxvNdu6ShK7nCmpj41jB2cqFOu/4aVynaKYPNt9aNote4fonU7ngvkQn8ZJ4H6JoOXof+L8mcOlkNr1PX1I8juggF4g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xhs4/noHRSpuZeTMbQgny9jP6ltEUgfGNICl3ngqzLw=; b=4xO8DQCW3LIGUpChBZHbsFo8y+0vdApzCFXdF2Em3rNYSP8/eD2sqZvVsGUWPgEd3oqz3bLgwNqpj88UvhtjceKOgvKKvW7t/sJIGQBlad7l1SqjDMLk7c8esV4f074/rGjP4f3281I0lH9JK266lfeqG7Evixv7OdEaftYL9ds= Received: from DB7PR05CA0070.eurprd05.prod.outlook.com (2603:10a6:10:2e::47) by AS2PR08MB8747.eurprd08.prod.outlook.com (2603:10a6:20b:55f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Wed, 27 Mar 2024 10:18:57 +0000 Received: from DU6PEPF0000A7E3.eurprd02.prod.outlook.com (2603:10a6:10:2e:cafe::ff) by DB7PR05CA0070.outlook.office365.com (2603:10a6:10:2e::47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.13 via Frontend Transport; Wed, 27 Mar 2024 10:18:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU6PEPF0000A7E3.mail.protection.outlook.com (10.167.8.41) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7409.10 via Frontend Transport; Wed, 27 Mar 2024 10:18:57 +0000 Received: ("Tessian outbound 1b0f2681ce6f:v300"); Wed, 27 Mar 2024 10:18:57 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 86a598616bf444d9 X-CR-MTA-TID: 64aa7808 Received: from e2bfcdcea21e.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id B1A6D3AE-9F43-4DA8-8BAB-62BB1D77AA48.1; Wed, 27 Mar 2024 10:18:51 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id e2bfcdcea21e.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 27 Mar 2024 10:18:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EMq08WRcjpRbFXXD+ijv9lA7HqiMqb8Nlwag4C2+fJZVt1mFq87J0TW8VIXYXBk11R5orANnvaJrLHDVqXJvHcYEQ2OFr3EIHmBB/oBTALQY6HEoAtrKYxe+q3zmqYjKeGg0aJmKt7jMVu64JLFRCPNVT4zkYky9EE3MBBYVxSCyKZLdKoqutVyIPQfm9Oqy5y1thU2G/QBNYNPxi4CeCuIPTP11FbBs19Q8oloylHCMS9sX6uGrgpZ7+4kXnzUGOP9ingZik2wJnpisfmwcIjmla5dYHpUqnFbj2ljzYcGDjFAiRAlk6qBYanhhCgaLECDbn/ZUJx2Q9P1EkJV4QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xhs4/noHRSpuZeTMbQgny9jP6ltEUgfGNICl3ngqzLw=; b=atmgEN2v9/yHgqv/QdpRc0VjHU0oq16EOnEvRdSp8PV3iOZBUO7s7Z176pgi93AT4fFnebnxkAMfHRWw3ESWvwa2BoG5I3y7W15CAVkIl2hB35aa+Zgh9SN7DHviUxteU/9e5xEKCrxrg6VhLiIF6CatuMf4HaNtLx0BG7ikrOATR51dQqdnLZN2Gr2AX9sx7cH6e+Mv3yHhAFdL51dfTJxT5AlvVMqro4N/qv4p5ee1z3/tFGc+oiMxXnX+crSB+7KZiv3tvmH5mGfmFTkAe4GD/xU4VhVkrX8Wwuq0Zd2Sgu6uf3Sd7MWNEEzAQa9gFuCE+dGO3oWMOerRcofwRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xhs4/noHRSpuZeTMbQgny9jP6ltEUgfGNICl3ngqzLw=; b=4xO8DQCW3LIGUpChBZHbsFo8y+0vdApzCFXdF2Em3rNYSP8/eD2sqZvVsGUWPgEd3oqz3bLgwNqpj88UvhtjceKOgvKKvW7t/sJIGQBlad7l1SqjDMLk7c8esV4f074/rGjP4f3281I0lH9JK266lfeqG7Evixv7OdEaftYL9ds= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DBBPR08MB5993.eurprd08.prod.outlook.com (2603:10a6:10:1f4::23) by DB9PR08MB7722.eurprd08.prod.outlook.com (2603:10a6:10:391::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.24; Wed, 27 Mar 2024 10:18:48 +0000 Received: from DBBPR08MB5993.eurprd08.prod.outlook.com ([fe80::f32:290a:4663:4c45]) by DBBPR08MB5993.eurprd08.prod.outlook.com ([fe80::f32:290a:4663:4c45%6]) with mapi id 15.20.7409.028; Wed, 27 Mar 2024 10:18:45 +0000 Message-ID: Date: Wed, 27 Mar 2024 10:18:42 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] aarch64: Add +lse128 architectural extension command-line flag Content-Language: en-US To: gcc-patches@gcc.gnu.org, kyrylo.tkachov@arm.com, Richard.Earnshaw@arm.com, richard.sandiford@arm.com References: <20240315111452.1741691-1-victor.donascimento@arm.com> From: Victor Do Nascimento In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0072.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5d::36) To DBBPR08MB5993.eurprd08.prod.outlook.com (2603:10a6:10:1f4::23) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DBBPR08MB5993:EE_|DB9PR08MB7722:EE_|DU6PEPF0000A7E3:EE_|AS2PR08MB8747:EE_ X-MS-Office365-Filtering-Correlation-Id: 6cf936de-b5d7-430a-3d45-08dc4e475069 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Yh6ghvuprW3Z1L5PTQaGZsK6OfJm2uA5cNqLCKzWMU9EDgPlCTVl7z2nE9vePMQ//ozmjeqXk1T5v9fAcZlDcLjT+j6zftp5A/ZvdLFUSp0SOqt73AoEGCts3VJW1nqmOQ09viPJtt3DSVkgp5MaRdTL1z8hbCKARka6LvXdRYw35BbRzu9AGuNIju92BjkZJebBJWxC/aEj48bDJuILRGJ0Zce5ExgCBG27B1ObVJH/ldJOOYy3hVLpBrRuWWXfYJwHrsAg6M8Jb90kIq4F+cmYinRJTVSGn1LxAZo2bpmtIb13G6C0QKMvDGkxzIF3pkhxs15kYnEQwLlFOanq6TIt1n2is2PgJ74dTMscIuvZcL7QH37YFkcv6mpW9YmcJGZWg96XgKiDAqmfz0fqdVSFENEWeVvUFFIq5uqJ07LeaY5Ur+NeFT0C7+Dg2GsHiCj9ux1njPqRoVCUEjH9oaPT2byeSFFnpJ8ghl+ARPdo73KtyFTALfDVSnT8X5W/wqVMG05cHEvk7C+Vp0kCt3D+9if5BG1KSfr9G7+0cIbYp5etXqZLN5YAMRo4lw91zdK6tgwdr0FIw0umWRkCz3PvwYO6xgrDzJsLRHIRHvP7V4y3nmklaPg1hjlKNaBS X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DBBPR08MB5993.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(366007);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB7722 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU6PEPF0000A7E3.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 3e73a8c0-e6cc-45fc-e5a1-08dc4e47492c X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: f+yG7Opj8WLkm1LCaCiO2dxcUI172dfl7qA/41PbvvBMEcwHNgLXEkZSGjpNHJ2OcJ9kQNAovEzdRQGuR4pBWtT2gb9jVNQM2ucxIfs7fVLQfHDoifPojiTdoEU+SHNIViZAPv/BybKIBnMi8238mkqvSWakFu87dYKIElwqAdZII/h5xwbmDqiz5R+dSOXRu+J9NADO2GEMS/jzaueDjT/G99E4LF3jdfq7ocktQf5Vvpj4cvl7MKS5vBwwGZr83b/1C4WvwgjTNAcaSi7ooVsvJ07cgh7tPfkyOxWUK/p7nzucfDxqpUcpGOExwtDydddbpDkWzaPpuqOqsHaVOZ/qiL9q4nnu10+D6bvnu2YIMj+1c1Yf9DmSt8yFxoqpp3jpw4Zg+lJmL8eD7toPGn9/jT7ghQkGpm5Tel+WtO9PMGU6BHE4qHbEMBa+jD/Jkh390fMR5AUIkgKmRIfjYLKIt4BIECqzTM1Og0a4kg/6NFalzVqtivuZU7rVf2Hmo4kDDYlmCZbreEiiB+5zHx1a1xm1WB94hr3g66cHuProFrmL6yBGdF29zhvS1U9MqxFJS0NZd2KY8e8/Eqljmc1RzRysR8CHv4sHnnQBcYgNq8Jym5bRwvlFMBOSv2k+JZA2qmTEDbDXEk9zRz58f3N3dZ7aA4PF5rUA4YoKYpWE65V9RqJN8ddAiM2LY87sBR2QyfJghuGascD/+VYkwg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(376005)(36860700004)(82310400014)(1800799015);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2024 10:18:57.8486 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6cf936de-b5d7-430a-3d45-08dc4e475069 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF0000A7E3.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB8747 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/26/24 12:26, Richard Sandiford wrote: > Victor Do Nascimento writes: >> Given how, at present, the choice of using LSE128 atomic instructions >> by the toolchain is delegated to run-time selection in the form of >> Libatomic ifuncs, responsible for querying target support, the >> `+lse128' target architecture compile-time flag is absent from GCC. >> >> This, however, contrasts with the Binutils implementation, which gates >> LSE128 instructions behind the `+lse128' flag. This can lead to >> problems in GCC for certain use-cases. One such example is in the use >> of inline assembly, whereby the inability of enabling the feature in >> the command-line prevents the compiler from automatically issuing the >> necessary LSE128 `.arch' directive. >> >> This patch therefore brings GCC into alignment with LLVM and Binutils >> in adding support for the `+lse128' architectural extension flag. >> >> gcc/ChangeLog: >> >> * config/aarch64/aarch64-option-extensions.def: Add LSE128 >> AARCH64_OPT_EXTENSION, adding it as a dependency for the D128 >> feature. >> >> gcc/testsuite/ChangeLog: >> >> * gcc.target/aarch64/lse128-flag.c: New. >> * gcc.target/aarch64/cpunative/info_23: Likewise. >> * gcc.target/aarch64/cpunative/native_cpu_23.c: Likewise. > > The new extension should be documented in doc/invoke.texi. > >> --- >> gcc/config/aarch64/aarch64-option-extensions.def | 4 +++- >> gcc/testsuite/gcc.target/aarch64/cpunative/info_23 | 8 ++++++++ >> .../gcc.target/aarch64/cpunative/native_cpu_23.c | 11 +++++++++++ >> gcc/testsuite/gcc.target/aarch64/lse128-flag.c | 10 ++++++++++ >> 4 files changed, 32 insertions(+), 1 deletion(-) >> create mode 100644 gcc/testsuite/gcc.target/aarch64/cpunative/info_23 >> create mode 100644 gcc/testsuite/gcc.target/aarch64/cpunative/native_cpu_23.c >> create mode 100644 gcc/testsuite/gcc.target/aarch64/lse128-flag.c >> >> diff --git a/gcc/config/aarch64/aarch64-option-extensions.def b/gcc/config/aarch64/aarch64-option-extensions.def >> index 1a3b91c68cf..ac54b899a06 100644 >> --- a/gcc/config/aarch64/aarch64-option-extensions.def >> +++ b/gcc/config/aarch64/aarch64-option-extensions.def >> @@ -275,7 +275,9 @@ AARCH64_OPT_EXTENSION("mops", MOPS, (), (), (), "") >> >> AARCH64_OPT_EXTENSION("cssc", CSSC, (), (), (), "cssc") >> >> -AARCH64_OPT_EXTENSION("d128", D128, (), (), (), "d128") >> +AARCH64_OPT_EXTENSION("lse128", LSE128, (LSE), (), (), "lse128") >> + >> +AARCH64_OPT_EXTENSION("d128", D128, (LSE128), (), (), "d128") >> >> AARCH64_OPT_EXTENSION("the", THE, (), (), (), "the") >> >> diff --git a/gcc/testsuite/gcc.target/aarch64/cpunative/info_23 b/gcc/testsuite/gcc.target/aarch64/cpunative/info_23 >> new file mode 100644 >> index 00000000000..d77c25d2f61 >> --- /dev/null >> +++ b/gcc/testsuite/gcc.target/aarch64/cpunative/info_23 >> @@ -0,0 +1,8 @@ >> +processor : 0 >> +BogoMIPS : 100.00 >> +Features : fp asimd evtstrm aes pmull sha1 sha2 crc32 asimddp atomics lse128 >> +CPU implementer : 0xfe >> +CPU architecture: 8 >> +CPU variant : 0x0 >> +CPU part : 0xd08 >> +CPU revision : 2 >> \ No newline at end of file >> diff --git a/gcc/testsuite/gcc.target/aarch64/cpunative/native_cpu_23.c b/gcc/testsuite/gcc.target/aarch64/cpunative/native_cpu_23.c >> new file mode 100644 >> index 00000000000..8a1e235d8ab >> --- /dev/null >> +++ b/gcc/testsuite/gcc.target/aarch64/cpunative/native_cpu_23.c >> @@ -0,0 +1,11 @@ >> +/* { dg-do compile { target { { aarch64*-*-linux*} && native } } } */ >> +/* { dg-set-compiler-env-var GCC_CPUINFO "$srcdir/gcc.target/aarch64/cpunative/info_23" } */ >> +/* { dg-additional-options "-mcpu=native" } */ >> + >> +int main() >> +{ >> + return 0; >> +} >> + >> +/* { dg-final { scan-assembler {\.arch armv8-a\+dotprod\+crc\+crypto\+lse128} } } */ >> +/* Test one where lse128 is available and so should be emitted. */ >> diff --git a/gcc/testsuite/gcc.target/aarch64/lse128-flag.c b/gcc/testsuite/gcc.target/aarch64/lse128-flag.c >> new file mode 100644 >> index 00000000000..71339c3af6d >> --- /dev/null >> +++ b/gcc/testsuite/gcc.target/aarch64/lse128-flag.c >> @@ -0,0 +1,10 @@ >> +/* { dg-do compile { target { aarch64*-*-*} } } */ >> +/* { dg-additional-options "-march=armv9.4-a+lse128" } */ >> + >> +int main() >> +{ >> + return 0; >> +} >> + >> +/* { dg-final { scan-assembler {\.arch armv9\.4-a\+crc\+lse128} } } */ >> +/* Test a normal looking procinfo. */ > > Not sure I understand the comment. Is procinfo part of this test? Thank you for catching this, Richard. This was originally a procinfo-reliant test which ended up being redesigned without reference to procinfo and this remained. I've now dropped it from the patch. Cheers! > Looks good otherwise. > > Thanks, > Richard