From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.smtpout.orange.fr (smtp-25.smtpout.orange.fr [80.12.242.25]) by sourceware.org (Postfix) with ESMTPS id C107B3856DE5 for ; Tue, 25 Apr 2023 10:45:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C107B3856DE5 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=orange.fr Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=orange.fr Received: from [192.168.1.15] ([86.215.161.51]) by smtp.orange.fr with ESMTPA id rGAopO3DQgYwYrGAtpgdLw; Tue, 25 Apr 2023 12:45:32 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=orange.fr; s=t20230301; t=1682419532; bh=D4dXsgyWw/X6tk9YQ5iCdCHHaKlIWW2zSbcH4kffIdY=; h=Date:From:Subject:To:References:In-Reply-To; b=BbcOOPInpuDhDHV2rOrqhNCdFLrICdqZ9cY+G3LBTJNj9HLhSa8iLaoMP4+VL1bMw tRGu/Lc4MuQFx47jjxn6A+xk5GbpGkjjNYCCEssu/q+tjyxftg4+DZdlQxJtT4MQpT nza8AABDcp7P4vcIypuvQ8mCmmMyYMIJPhV+VZvRD9VzxmLDkZJaKwAJgEQ/Msej2a qcvL+KL6iSdGAE9hJ/HLF8G/KWSR3ooal556MKaJlH7XFe1MUVzTE2FKk8vsfdjqbU dHV8MfWz7yGYxzenwchSYMKfWhJePsSlvbKrah1dyZcdRJscSfR1KGsZU1bLKSgZHS YiWNmAHWDdNHg== X-ME-Helo: [192.168.1.15] X-ME-Auth: bW9yaW4tbWlrYWVsQG9yYW5nZS5mcg== X-ME-Date: Tue, 25 Apr 2023 12:45:32 +0200 X-ME-IP: 86.215.161.51 Message-ID: Date: Tue, 25 Apr 2023 12:45:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 From: Mikael Morin Subject: Re: [PATCH 6/7] MATCH: Factor out code that for min max detection with constants To: Andrew Pinski , gcc-patches@gcc.gnu.org References: <20230424213011.528181-1-apinski@marvell.com> <20230424213011.528181-7-apinski@marvell.com> Content-Language: en-US In-Reply-To: <20230424213011.528181-7-apinski@marvell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,JMQ_SPF_NEUTRAL,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, > diff --git a/gcc/fold-const.cc b/gcc/fold-const.cc > index 3b397ae2941..b8add24f874 100644 > --- a/gcc/fold-const.cc > +++ b/gcc/fold-const.cc > @@ -150,6 +150,49 @@ static tree fold_convert_const (enum tree_code, tree, tree); > static tree fold_view_convert_expr (tree, tree); > static tree fold_negate_expr (location_t, tree); > > +/* This is a helper function to detect min/max for some operands of COND_EXPR. > + The form is "(EXP0 CMP EXP1) ? EXP2 : EXP3". */ > +tree_code > +minmax_from_comparison (tree_code cmp, tree exp0, tree exp1, tree exp2, tree exp3) > +{ > + enum tree_code code = ERROR_MARK; > + > + if (HONOR_NANS (exp0) || HONOR_SIGNED_ZEROS (exp0)) > + return ERROR_MARK; > + > + if (!operand_equal_p (exp0, exp2)) > + return ERROR_MARK; > + > + if (TREE_CODE (exp1) == INTEGER_CST && TREE_CODE (exp1) == INTEGER_CST one of these conditions should probably be TREE_CODE (exp3) == INTEGER_CST? > + && wi::to_widest (exp1) == (wi::to_widest (exp3) - 1)) > + { > + /* X <= Y - 1 equals to X < Y. */ > + if (cmp == LE_EXPR) > + code = LT_EXPR; > + /* X > Y - 1 equals to X >= Y. */ > + if (cmp == GT_EXPR) > + code = GE_EXPR; > + } > + if (TREE_CODE (exp3) == INTEGER_CST && TREE_CODE (exp1) == INTEGER_CST > + && wi::to_widest (exp1) == (wi::to_widest (exp3) + 1)) > + { > + /* X < Y + 1 equals to X <= Y. */ > + if (cmp == LT_EXPR) > + code = LE_EXPR; > + /* X >= Y + 1 equals to X > Y. */ > + if (cmp == GE_EXPR) > + code = GT_EXPR; > + } Mikael