From: Jeff Law <jeffreyalaw@gmail.com>
To: Andrew Pinski <apinski@marvell.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 2/3] MATCH: Improve zero_one_valued_p by using ssa_name_has_boolean_range
Date: Tue, 5 Sep 2023 00:59:16 -0600 [thread overview]
Message-ID: <d394c6f7-c6dd-46d9-bd78-c044966a0b58@gmail.com> (raw)
In-Reply-To: <20230902150957.845269-2-apinski@marvell.com>
On 9/2/23 09:09, Andrew Pinski via Gcc-patches wrote:
> Currently zero_one_valued_p uses tree_nonzero_bits which uses
> the global ranges of the SSA Names. We can improve this via using
> ssa_name_has_boolean_range which uses the local ranges
> which are used while handling folding during VRP and other passes.
>
> OK? Bootstrapped and tested on x86_64 with no regressions.
>
> gcc/ChangeLog:
>
> * match.pd (zero_one_valued_p): Match SSA_NAMES where
> ssa_name_has_boolean_range returns true.
OK. Presumably we're confident using a context sensitive range is
always OK in here.
Jeff
next prev parent reply other threads:[~2023-09-05 6:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 15:09 [PATCH 1/3] Improve ssa_name_has_boolean_range slightly Andrew Pinski
2023-09-02 15:09 ` [PATCH 2/3] MATCH: Improve zero_one_valued_p by using ssa_name_has_boolean_range Andrew Pinski
2023-09-05 6:59 ` Jeff Law [this message]
2023-09-02 15:09 ` [PATCH 3/3] MATCH: Replace all uses of ssa_name_has_boolean_range with zero_one_valued_p Andrew Pinski
2023-09-05 7:02 ` Jeff Law
2023-09-05 6:58 ` [PATCH 1/3] Improve ssa_name_has_boolean_range slightly Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d394c6f7-c6dd-46d9-bd78-c044966a0b58@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).