Re: [PATCH v2, Fortran] [PR libfortran/101317] Bind(c): Improve error checking in CFI_* functions

[Tobias Burnus <tobias@codesourcery.com>]

Hi Sandra,

On 25.07.21 06:11, Sandra Loosemore wrote:
>> Congratulation – we have found a bug in the spec, which is also
>> present in the current draft (21-007). I have now written to J3:
>> https://mailman.j3-fortran.org/pipermail/j3/2021-July/013189.html
>
> That discussion seems to have wandered off into some other direction
> so I'm not sure whether it really clarifies this problem.

I concur. I do hope that it will be at some point discussed and clarified.

But for now:

> For the purposes of this patch I have left in the test for elem_len >
> 0 in CFI_establish where the standard explicitly has that requirement
> and removed it from the other functions where I'd added it just to be
> consistent.
I think that makes sense.
> OK, I have done that throughout the file, and also made the wording
> change you asked for.  While I was at it, I went through all the
> diagnostic messages in the file and simplified the wording of a few
> other messages as well, fixed typos and inconsistent capitalization
> and missing punctuation and things like that.
Thanks!
> Here's a new patch.

LGTM.

Thanks,

Tobias

-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955