From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 079823858007; Mon, 26 Jul 2021 07:35:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 079823858007 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: 5nxa0GXBUatEQt0usFa2w/ykwTh5JlGtpaEp8rZRiKtL3rG9Li+mDrJ8WMCSeDhkU68XdJnlUy FMyHqxQlPEvNGD8R1dvwJVlUxposWtup5ZD826fAuRLAlXKiRsW6OKGsMcNISEyqd2ruLXegxm eSAs7Jv+Q4MlLi3oMYd9WKN11qrgvy42HBdY+q9FURVnSCG7Yt5xo5M85+hlYWfsNpFmqBeVGi NP9ELSCHcC2Rrk9h2rsmuCHFhHzVeWDgk2dY1FcISyXm9JD3lMJyHiAd7hiEdjmJU49hnbYmee o1g6u5oCBKAg18J0TsgQXEW2 X-IronPort-AV: E=Sophos;i="5.84,270,1620720000"; d="scan'208";a="66363705" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 25 Jul 2021 23:35:36 -0800 IronPort-SDR: eFtvaYpPaomnpZHUYL3AZ9WI930WADmQrpUtCChHNdgcEPqDTTPuRL6L/YfqxyLnxiJ6GRNoCp GPfth6JKH1FML4c4rVF86pJ7IpjNmp+4QOXTuPm4Knrpp7EN1QAMvdwkXSfa68neEGj747kupm qE2mSB0YSVaKWbgys4cMWYA3y/GDqNvsMy1uR6gj6dh2mnTLLhnT+AtimKglGWsR+fpmsWWmY9 OnI+PeNcy2vFN1CRFwwLlUonQdimycRco4CIULLUTEv7zJqAK3+9GUO7kE6FM8UazaKLK0Ktfg xIs= Subject: Re: [PATCH v2, Fortran] [PR libfortran/101317] Bind(c): Improve error checking in CFI_* functions To: Sandra Loosemore , "fortran@gcc.gnu.org" , "gcc-patches@gcc.gnu.org" References: <8fc3b97c-b122-9c2c-4657-4f98cf82973e@codesourcery.com> <1fd11074-9c32-37a6-a957-3fe3e329eb9e@codesourcery.com> <28519de9-3fca-7c94-1edf-5d920d3fccdf@codesourcery.com> From: Tobias Burnus Message-ID: Date: Mon, 26 Jul 2021 09:35:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <28519de9-3fca-7c94-1edf-5d920d3fccdf@codesourcery.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-08.mgc.mentorg.com (139.181.222.8) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jul 2021 07:35:38 -0000 Hi Sandra, On 25.07.21 06:11, Sandra Loosemore wrote: >> Congratulation =E2=80=93 we have found a bug in the spec, which is also >> present in the current draft (21-007). I have now written to J3: >> https://mailman.j3-fortran.org/pipermail/j3/2021-July/013189.html > > That discussion seems to have wandered off into some other direction > so I'm not sure whether it really clarifies this problem. I concur. I do hope that it will be at some point discussed and clarified. But for now: > For the purposes of this patch I have left in the test for elem_len > > 0 in CFI_establish where the standard explicitly has that requirement > and removed it from the other functions where I'd added it just to be > consistent. I think that makes sense. > OK, I have done that throughout the file, and also made the wording > change you asked for. While I was at it, I went through all the > diagnostic messages in the file and simplified the wording of a few > other messages as well, fixed typos and inconsistent capitalization > and missing punctuation and things like that. Thanks! > Here's a new patch. LGTM. Thanks, Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955