From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 74C303858D20; Wed, 17 Apr 2024 06:09:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 74C303858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 74C303858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713334201; cv=none; b=yARS/r3rdSWJ6tm1EsBEdHqtpEDf/rXrPaBx0+lGeQi0AhALjOFw+7ctnoeyJRPexuM/mmec2xflGeNnu4+UZOdx6/qTgExIFuyXD5atqlaM6AjrLayabCrvjvMkXfRoYdiWOzC4jaTYlyYnkxprU2VFjZE030yJP8zoqGBxkls= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713334201; c=relaxed/simple; bh=qDrhKHLfcgpyJAUMslx+9FfX7+hcftY6+4FGQCARUng=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=rg8Q0P9EtmURJx/6sfuW8LyZbNSFHvOXYn/hHHpCBWwdxRU00J9wVwZ4JAy/VJudwmToIkWYQaQtaFDCXlbbCJ3N/hCHbIrItY+9WR9gvfn0gjthNBezmuIJuYyBhyKVQYVrXtT/O78BdjmqbW6OGzSOxMiTOeHtyRYMoMVoW9c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43H65THX009333; Wed, 17 Apr 2024 06:09:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=rh3dFgFLn6fO7Kk/i9Ya1minkbLnZo3goB490ivtFGc=; b=fxgeshKOQZ1+IRCS7e+pgNPt3uvLM+MqrLhmuOdGyZ6CwyZouIrwsJljRw1JuNmDVdeg 4aiQ8/ezjKoz/SoLoZAkOceHRFO3V6JnxVVSSfL663jrb+bcHm5YkY51cZLLBaPJDPEN tgom8jekg13mYgGjQPIRIgqRT/KvYsCi3a60IEUcy/iDduekkidWZ2QEyT+C/sJt0iNc CcnA0i8kFLEGXKben3BEDivEFsJHcAXE9l+I6yK2iSfeeTObGnMH47zo6RK4UIA/tSU5 NeUGI3PMBvR7QCLA1glbk5gGKFYrXB7+vrU8n2tALXAXK2m889OLFaa1MHnxFtREVVdM SQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xj8ug009g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Apr 2024 06:09:58 +0000 Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 43H69weJ015519; Wed, 17 Apr 2024 06:09:58 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xj8ug009e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Apr 2024 06:09:58 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43H4XquT027289; Wed, 17 Apr 2024 06:09:57 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3xg4s02raq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 Apr 2024 06:09:57 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43H69mPF49545472 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 Apr 2024 06:09:50 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BAF6A200B5; Wed, 17 Apr 2024 06:09:48 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8A71E200A9; Wed, 17 Apr 2024 06:09:48 +0000 (GMT) Received: from [9.152.224.246] (unknown [9.152.224.246]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 17 Apr 2024 06:09:48 +0000 (GMT) Message-ID: Date: Wed, 17 Apr 2024 08:09:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] s390: avoid peeking eof after __vector To: Jiufu Guo , gcc-patches@gcc.gnu.org Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, bergner@linux.ibm.com, uweigand@de.ibm.com References: <20240327063614.2444325-1-guojiufu@linux.ibm.com> Content-Language: en-US From: Andreas Krebbel In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: lMSr08-fh_Wl5xFcH4VN6zT-OHkL5WGC X-Proofpoint-GUID: LbcQMuhnoR_Lo2y94ovtwig36YYaqfY8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-04-17_05,2024-04-16_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 priorityscore=1501 adultscore=0 spamscore=0 suspectscore=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1011 phishscore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404170040 X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/17/24 03:52, Jiufu Guo wrote: > > Hi, > > I would like to ping this patch. > > > Jeff (Jiufu Guo) > > Jiufu Guo writes: > >> Hi, >> >> Same like PR101168, this patch is need for s390 to >> avoid peeking eof after vector keyword. >> And similar test case is also ok for s390. >> >> Is this ok for trunk? >> >> Jeff (Jiufu Guo) >> >> PR target/95782 >> >> gcc/ChangeLog: >> >> * config/s390/s390-c.cc (s390_macro_to_expand): Avoid empty identifier. >> >> gcc/testsuite/ChangeLog: >> >> * g++.target/s390/pr95782.C: New test. Sorry for the delay. This is ok. Thanks! Andreas >> >> --- >> gcc/config/s390/s390-c.cc | 4 +++- >> gcc/testsuite/g++.target/s390/pr95782.C | 5 +++++ >> 2 files changed, 8 insertions(+), 1 deletion(-) >> create mode 100644 gcc/testsuite/g++.target/s390/pr95782.C >> >> diff --git a/gcc/config/s390/s390-c.cc b/gcc/config/s390/s390-c.cc >> index 8d3d1a467a8..45f164d978b 100644 >> --- a/gcc/config/s390/s390-c.cc >> +++ b/gcc/config/s390/s390-c.cc >> @@ -275,7 +275,9 @@ s390_macro_to_expand (cpp_reader *pfile, const cpp_token *tok) >> /* __vector long __bool a; */ >> if (ident == C_CPP_HASHNODE (__bool_keyword)) >> expand_bool_p = true; >> - else >> + >> + /* If there are more tokens to check. */ >> + else if (ident) >> { >> /* Triggered with: __vector long long __bool a; */ >> do >> diff --git a/gcc/testsuite/g++.target/s390/pr95782.C b/gcc/testsuite/g++.target/s390/pr95782.C >> new file mode 100644 >> index 00000000000..daf887fc6fe >> --- /dev/null >> +++ b/gcc/testsuite/g++.target/s390/pr95782.C >> @@ -0,0 +1,5 @@ >> +// { dg-do compile } >> +// { dg-options "-march=z14 -mzvector" } >> + >> +using vdbl = __vector double; >> +#define BREAK 1