On 11/23/20 12:00 PM, Richard Biener wrote: > Can you split out the unifying of -[gf]record-gcc-switches processing > and the target hook adjustment from the change introducing > -frecord-gcc-switches-format? Sure. > > dwarf2out.c seems to retain its gen_producer_string () even though > you duplicate it elsewhere and it is now unused? Please retain > the gen_producer_string name since the function does actual > processing and not just fetch a precomputed string from somewhere. Yep, please take a look at the attached patch. > > I'd like somebody else chime in on the -frecord-gcc-switches-format > driver handling but will happily work with getting the unification part merged. May I apply the patch after it finishes regression tests and bootstrap? Thanks, Martin > > Richard.