* [PATCH] Document --coverage and fork-like functions (PR gcov-profile/82457).
@ 2017-10-19 10:27 Martin Liška
2017-10-19 18:30 ` Eric Gallager
0 siblings, 1 reply; 6+ messages in thread
From: Martin Liška @ 2017-10-19 10:27 UTC (permalink / raw)
To: gcc-patches; +Cc: Jan Hubicka, Andrew Pinski
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
Hi.
As discussed in the PR, we should be more precise in our documentation.
The patch does that.
Ready for trunk?
Martin
gcc/ChangeLog:
2017-10-19 Martin Liska <mliska@suse.cz>
PR gcov-profile/82457
* doc/invoke.texi: Document that one needs a non-strict ISO mode
for fork-like functions to be properly instrumented.
---
gcc/doc/invoke.texi | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
[-- Attachment #2: 0001-Document-coverage-and-fork-like-functions-PR-gcov-pr.patch --]
[-- Type: text/x-patch, Size: 700 bytes --]
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 5e88279528f..b37bca48960 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -10861,7 +10861,9 @@ information. This may be repeated any number of times. You can run
concurrent instances of your program, and provided that the file system
supports locking, the data files will be correctly updated. Also
@code{fork} calls are detected and correctly handled (double counting
-will not happen).
+will not happen). For C language, a non-strict ISO C mode
+(@option{-ansi}, @option{-std=c90}, @option{-std=c99} or @option{-std=c11})
+is needed.
@item
For profile-directed optimizations, compile the source files again with
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Document --coverage and fork-like functions (PR gcov-profile/82457).
2017-10-19 10:27 [PATCH] Document --coverage and fork-like functions (PR gcov-profile/82457) Martin Liška
@ 2017-10-19 18:30 ` Eric Gallager
2017-10-20 4:10 ` Sandra Loosemore
0 siblings, 1 reply; 6+ messages in thread
From: Eric Gallager @ 2017-10-19 18:30 UTC (permalink / raw)
To: Martin Liška; +Cc: gcc-patches, Jan Hubicka, Andrew Pinski
On 10/19/17, Martin Liška <mliska@suse.cz> wrote:
> Hi.
>
> As discussed in the PR, we should be more precise in our documentation.
> The patch does that.
>
> Ready for trunk?
> Martin
>
> gcc/ChangeLog:
>
> 2017-10-19 Martin Liska <mliska@suse.cz>
>
> PR gcov-profile/82457
> * doc/invoke.texi: Document that one needs a non-strict ISO mode
> for fork-like functions to be properly instrumented.
> ---
> gcc/doc/invoke.texi | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>
>
The wording is kinda unclear because the modes in the parentheses are
all strict ISO modes, but the part before the parentheses says
NON-strict... I think you either need an additional "not" inside the
parentheses, or to change all the instances of -std=c* to -std=gnu*.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Document --coverage and fork-like functions (PR gcov-profile/82457).
2017-10-19 18:30 ` Eric Gallager
@ 2017-10-20 4:10 ` Sandra Loosemore
2017-10-26 7:34 ` Martin Liška
0 siblings, 1 reply; 6+ messages in thread
From: Sandra Loosemore @ 2017-10-20 4:10 UTC (permalink / raw)
To: Eric Gallager, Martin Liška; +Cc: gcc-patches, Jan Hubicka, Andrew Pinski
On 10/19/2017 12:26 PM, Eric Gallager wrote:
> On 10/19/17, Martin Liška <mliska@suse.cz> wrote:
>> Hi.
>>
>> As discussed in the PR, we should be more precise in our documentation.
>> The patch does that.
>>
>> Ready for trunk?
>> Martin
>>
>> gcc/ChangeLog:
>>
>> 2017-10-19 Martin Liska <mliska@suse.cz>
>>
>> PR gcov-profile/82457
>> * doc/invoke.texi: Document that one needs a non-strict ISO mode
>> for fork-like functions to be properly instrumented.
>> ---
>> gcc/doc/invoke.texi | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>>
>>
>
> The wording is kinda unclear because the modes in the parentheses are
> all strict ISO modes, but the part before the parentheses says
> NON-strict... I think you either need an additional "not" inside the
> parentheses, or to change all the instances of -std=c* to -std=gnu*.
The wording in the patch doesn't make sense to me, either. If I
understand the issue correctly, the intent is probably to say something like
Unless a strict ISO C dialect option is in effect,
@code{fork} calls are detected and correctly handled without double
counting.
??
-Sandra
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Document --coverage and fork-like functions (PR gcov-profile/82457).
2017-10-20 4:10 ` Sandra Loosemore
@ 2017-10-26 7:34 ` Martin Liška
2017-10-26 16:37 ` Sandra Loosemore
0 siblings, 1 reply; 6+ messages in thread
From: Martin Liška @ 2017-10-26 7:34 UTC (permalink / raw)
To: Sandra Loosemore, Eric Gallager; +Cc: gcc-patches, Jan Hubicka, Andrew Pinski
[-- Attachment #1: Type: text/plain, Size: 1428 bytes --]
On 10/20/2017 06:03 AM, Sandra Loosemore wrote:
> On 10/19/2017 12:26 PM, Eric Gallager wrote:
>> On 10/19/17, Martin Liška <mliska@suse.cz> wrote:
>>> Hi.
>>>
>>> As discussed in the PR, we should be more precise in our documentation.
>>> The patch does that.
>>>
>>> Ready for trunk?
>>> Martin
>>>
>>> gcc/ChangeLog:
>>>
>>> 2017-10-19 Martin Liska <mliska@suse.cz>
>>>
>>> Â Â Â Â PR gcov-profile/82457
>>> Â Â Â Â * doc/invoke.texi: Document that one needs a non-strict ISO mode
>>> Â Â Â Â for fork-like functions to be properly instrumented.
>>> ---
>>> Â gcc/doc/invoke.texi | 4 +++-
>>> Â 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>>
>>>
>>
>> The wording is kinda unclear because the modes in the parentheses are
>> all strict ISO modes, but the part before the parentheses says
>> NON-strict... I think you either need an additional "not" inside the
>> parentheses, or to change all the instances of -std=c* to -std=gnu*.
>
> The wording in the patch doesn't make sense to me, either. If I understand the issue correctly, the intent is probably to say something like
>
> Unless a strict ISO C dialect option is in effect,
> @code{fork} calls are detected and correctly handled without double counting.
>
> ??
Hi Sandra.
Thank you for the feedback, I'm sending version you suggested. Hope it's fine to install the patch?
Thanks,
Martin
>
> -Sandra
>
>
[-- Attachment #2: 0001-Document-coverage-and-fork-like-functions-PR-gcov-pr.patch --]
[-- Type: text/x-patch, Size: 1223 bytes --]
From 4395e7172b8af4628f3c294e16294d5136a5e51a Mon Sep 17 00:00:00 2001
From: marxin <mliska@suse.cz>
Date: Thu, 19 Oct 2017 12:18:45 +0200
Subject: [PATCH] Document --coverage and fork-like functions (PR
gcov-profile/82457).
gcc/ChangeLog:
2017-10-19 Martin Liska <mliska@suse.cz>
PR gcov-profile/82457
* doc/invoke.texi: Document that one needs a non-strict ISO mode
for fork-like functions to be properly instrumented.
---
gcc/doc/invoke.texi | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 71b2445f70f..f5dbf866adc 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -10864,7 +10864,8 @@ information. This may be repeated any number of times. You can run
concurrent instances of your program, and provided that the file system
supports locking, the data files will be correctly updated. Also
@code{fork} calls are detected and correctly handled (double counting
-will not happen).
+will not happen). Unless a strict ISO C dialect option is in effect,
+@code{fork} calls are detected and correctly handled without double counting.
@item
For profile-directed optimizations, compile the source files again with
--
2.14.2
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Document --coverage and fork-like functions (PR gcov-profile/82457).
2017-10-26 7:34 ` Martin Liška
@ 2017-10-26 16:37 ` Sandra Loosemore
2017-10-27 8:36 ` Martin Liška
0 siblings, 1 reply; 6+ messages in thread
From: Sandra Loosemore @ 2017-10-26 16:37 UTC (permalink / raw)
To: Martin Liška, Eric Gallager; +Cc: gcc-patches, Jan Hubicka, Andrew Pinski
On 10/26/2017 01:21 AM, Martin Liška wrote:
> On 10/20/2017 06:03 AM, Sandra Loosemore wrote:
>> On 10/19/2017 12:26 PM, Eric Gallager wrote:
>>> On 10/19/17, Martin Liška <mliska@suse.cz> wrote:
>>>> Hi.
>>>>
>>>> As discussed in the PR, we should be more precise in our documentation.
>>>> The patch does that.
>>>>
>>>> Ready for trunk?
>>>> Martin
>>>>
>>>> gcc/ChangeLog:
>>>>
>>>> 2017-10-19 Martin Liska <mliska@suse.cz>
>>>>
>>>> PR gcov-profile/82457
>>>> * doc/invoke.texi: Document that one needs a non-strict ISO mode
>>>> for fork-like functions to be properly instrumented.
>>>> ---
>>>> gcc/doc/invoke.texi | 4 +++-
>>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>>
>>>>
>>>
>>> The wording is kinda unclear because the modes in the parentheses are
>>> all strict ISO modes, but the part before the parentheses says
>>> NON-strict... I think you either need an additional "not" inside the
>>> parentheses, or to change all the instances of -std=c* to -std=gnu*.
>>
>> The wording in the patch doesn't make sense to me, either. If I understand the issue correctly, the intent is probably to say something like
>>
>> Unless a strict ISO C dialect option is in effect,
>> @code{fork} calls are detected and correctly handled without double counting.
>>
>> ??
>
> Hi Sandra.
>
> Thank you for the feedback, I'm sending version you suggested. Hope it's fine to install the patch?
Ummm, no. Sorry to have been unclear; the wording I suggested above was
intended to replace the existing sentence about fork behavior, not to be
appended to it.
-Sandra
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Document --coverage and fork-like functions (PR gcov-profile/82457).
2017-10-26 16:37 ` Sandra Loosemore
@ 2017-10-27 8:36 ` Martin Liška
0 siblings, 0 replies; 6+ messages in thread
From: Martin Liška @ 2017-10-27 8:36 UTC (permalink / raw)
To: Sandra Loosemore, Eric Gallager; +Cc: gcc-patches, Jan Hubicka, Andrew Pinski
[-- Attachment #1: Type: text/plain, Size: 1846 bytes --]
On 10/26/2017 06:30 PM, Sandra Loosemore wrote:
> On 10/26/2017 01:21 AM, Martin Liška wrote:
>> On 10/20/2017 06:03 AM, Sandra Loosemore wrote:
>>> On 10/19/2017 12:26 PM, Eric Gallager wrote:
>>>> On 10/19/17, Martin Liška <mliska@suse.cz> wrote:
>>>>> Hi.
>>>>>
>>>>> As discussed in the PR, we should be more precise in our documentation.
>>>>> The patch does that.
>>>>>
>>>>> Ready for trunk?
>>>>> Martin
>>>>>
>>>>> gcc/ChangeLog:
>>>>>
>>>>> 2017-10-19 Martin Liska <mliska@suse.cz>
>>>>>
>>>>> Â Â Â Â PR gcov-profile/82457
>>>>> Â Â Â Â * doc/invoke.texi: Document that one needs a non-strict ISO mode
>>>>> Â Â Â Â for fork-like functions to be properly instrumented.
>>>>> ---
>>>>> Â Â gcc/doc/invoke.texi | 4 +++-
>>>>> Â Â 1 file changed, 3 insertions(+), 1 deletion(-)
>>>>>
>>>>>
>>>>>
>>>>
>>>> The wording is kinda unclear because the modes in the parentheses are
>>>> all strict ISO modes, but the part before the parentheses says
>>>> NON-strict... I think you either need an additional "not" inside the
>>>> parentheses, or to change all the instances of -std=c* to -std=gnu*.
>>>
>>> The wording in the patch doesn't make sense to me, either. If I understand the issue correctly, the intent is probably to say something like
>>>
>>> Unless a strict ISO C dialect option is in effect,
>>> @code{fork} calls are detected and correctly handled without double counting.
>>>
>>> ??
>>
>> Hi Sandra.
>>
>> Thank you for the feedback, I'm sending version you suggested. Hope it's fine to install the patch?
>
> Ummm, no. Sorry to have been unclear; the wording I suggested above was intended to replace the existing sentence about fork behavior, not to be appended to it.
>
> -Sandra
>
Sorry, stupid mistake. Should be fixed, I'm going to install the patch.
Martin
[-- Attachment #2: 0001-Document-coverage-and-fork-like-functions-PR-gcov-pr.patch --]
[-- Type: text/x-patch, Size: 1417 bytes --]
From 30a3987aae8d306764bf38037f3f197cfe0d2aef Mon Sep 17 00:00:00 2001
From: marxin <mliska@suse.cz>
Date: Thu, 19 Oct 2017 12:18:45 +0200
Subject: [PATCH] Document --coverage and fork-like functions (PR
gcov-profile/82457).
gcc/ChangeLog:
2017-10-19 Martin Liska <mliska@suse.cz>
PR gcov-profile/82457
* doc/invoke.texi: Document that one needs a non-strict ISO mode
for fork-like functions to be properly instrumented.
---
gcc/doc/invoke.texi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 71b2445f70f..6ca59baac67 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -10862,9 +10862,9 @@ Link your object files with @option{-lgcov} or @option{-fprofile-arcs}
Run the program on a representative workload to generate the arc profile
information. This may be repeated any number of times. You can run
concurrent instances of your program, and provided that the file system
-supports locking, the data files will be correctly updated. Also
-@code{fork} calls are detected and correctly handled (double counting
-will not happen).
+supports locking, the data files will be correctly updated. Unless
+a strict ISO C dialect option is in effect, @code{fork} calls are
+detected and correctly handled without double counting.
@item
For profile-directed optimizations, compile the source files again with
--
2.14.2
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-10-27 8:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-19 10:27 [PATCH] Document --coverage and fork-like functions (PR gcov-profile/82457) Martin Liška
2017-10-19 18:30 ` Eric Gallager
2017-10-20 4:10 ` Sandra Loosemore
2017-10-26 7:34 ` Martin Liška
2017-10-26 16:37 ` Sandra Loosemore
2017-10-27 8:36 ` Martin Liška
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).