From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id B93613858C20 for ; Mon, 22 Aug 2022 09:24:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B93613858C20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 9FBD11FAC8; Mon, 22 Aug 2022 09:24:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1661160266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ROXNYThuYoB7O9BXPmnGSnoZZrulw1T4C1AOx5Nh62A=; b=rToQVVkFxzJUEhFT8oCBgcy6ZIIg12FHdVD+Ac5D6hzw7nRf8obqF2j42PEabmulNDCeRq JA1mTlwRqxDUjn7S2qOfNtW1+LvRsQLwP19yCaggV30MxTpXImgcRNO04unxDiw0p5TqXH T94TmI8SOpuZ29iWbfs6bjAVy/oG6Z4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1661160266; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ROXNYThuYoB7O9BXPmnGSnoZZrulw1T4C1AOx5Nh62A=; b=3Q/LBn/xkc9XHpInofXyQFo/KnCDkDoA14kjz5ix8w8HHOr8vQl6RvKcZ6eoPo/o4p71wW bWCYZWQTKo1/qMDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 82ED913523; Mon, 22 Aug 2022 09:24:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uu2yHkpLA2P/bwAAMHmgww (envelope-from ); Mon, 22 Aug 2022 09:24:26 +0000 Message-ID: Date: Mon, 22 Aug 2022 11:24:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [PATCH][DOCS] Document make jobserver related changes for GCC 13. Content-Language: en-US To: Gerald Pfeifer Cc: gcc-patches@gcc.gnu.org References: <87f6f563-8e1a-0f14-8993-cc0bfb3d926c@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Aug 2022 09:24:30 -0000 On 8/18/22 22:53, Gerald Pfeifer wrote: > On Thu, 18 Aug 2022, Martin Liška wrote: >> Ready for master? > > Nearly. :) > >> + Link-time optimization improvements: >> +
    >> +
  • LTO supports the newly added GNU make's jobserver that uses named pipes (--jobserver-style=fifo) > > I believe that's just "GNU make" (instead of "GNU make's"), or maybe > "...the newly added jobserver of GNU make...". > > Not 100% sure myself. > >> +
  • If make's jobserver is active, parallel LTO WPA streaming >> communicates with it and so the streaming >> + does not lead to the system overcommitting.
    • > > Might we be able to simplify this to something like > > "...parallel LTO WPA streaming communicates with it and thus avoids > system overcommitting" ? > > > Just two minor points; the patch as such looks fine. Thanks for the review, installed with your suggestions. Martin > > Thank you, > Gerald