From: Jeff Law <jeffreyalaw@gmail.com>
To: Andrew Carlotti <andrew.carlotti@arm.com>, gcc-patches@gcc.gnu.org
Cc: jason@redhat.com, nathan@acm.org, rguenther@suse.de,
richard.sandiford@arm.com, richard.earnshaw@arm.com
Subject: Re: [PATCH v2 2/5] c-family: Simplify attribute exclusion handling
Date: Sun, 19 Nov 2023 14:45:22 -0700 [thread overview]
Message-ID: <d4dbe761-93a0-4058-a315-3c168a07b9f0@gmail.com> (raw)
In-Reply-To: <408e5c77-961f-4613-009f-d0dea61a37ca@e124511.cambridge.arm.com>
On 11/16/23 19:53, Andrew Carlotti wrote:
> This patch changes the handling of mutual exclusions involving the
> target and target_clones attributes to use the generic attribute
> exclusion lists. Additionally, the duplicate handling for the
> always_inline and noinline attribute exclusion is removed.
>
> The only change in functionality is the choice of warning message
> displayed - due to either a change in the wording for mutual exclusion
> warnings, or a change in the order in which different checks occur.
>
> Ok for master?
>
> gcc/c-family/ChangeLog:
>
> * c-attribs.cc (attr_always_inline_exclusions): New.
> (attr_target_exclusions): Ditto.
> (attr_target_clones_exclusions): Ditto.
> (c_common_attribute_table): Add new exclusion lists.
> (handle_noinline_attribute): Remove custom exclusion handling.
> (handle_always_inline_attribute): Ditto.
> (handle_target_attribute): Ditto.
> (handle_target_clones_attribute): Ditto.
>
> gcc/testsuite/ChangeLog:
>
> * g++.target/i386/mvc2.C:
> * g++.target/i386/mvc3.C:
OK
jeff
next prev parent reply other threads:[~2023-11-19 21:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 2:49 [PATCH v2 0/5] target_version and aarch64 function multiversioning Andrew Carlotti
2023-11-17 2:51 ` [PATCH v2[1/5] aarch64: Add cpu feature detection to libgcc Andrew Carlotti
2023-11-20 15:46 ` Richard Sandiford
2023-12-04 10:31 ` Andrew Carlotti
2023-11-17 2:53 ` [PATCH v2 2/5] c-family: Simplify attribute exclusion handling Andrew Carlotti
2023-11-19 21:45 ` Jeff Law [this message]
2023-11-17 2:54 ` [PATCH v2 3/5] ada: Improve " Andrew Carlotti
2023-11-17 10:45 ` Marc Poulhiès
2023-11-17 11:15 ` Andrew Carlotti
2023-11-20 8:26 ` Marc Poulhiès
2023-11-17 2:55 ` [PATCH v2 4/5] Add support for target_version attribute Andrew Carlotti
2023-11-29 17:53 ` Richard Sandiford
2023-12-04 11:14 ` Andrew Carlotti
2023-11-17 2:56 ` [PATCH v2 5/5] aarch64: Add function multiversioning support Andrew Carlotti
2023-11-24 16:22 ` Richard Sandiford
2023-12-04 13:23 ` Andrew Carlotti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4dbe761-93a0-4058-a315-3c168a07b9f0@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=andrew.carlotti@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=nathan@acm.org \
--cc=rguenther@suse.de \
--cc=richard.earnshaw@arm.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).