From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-459354-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 108416 invoked by alias); 31 Jul 2017 10:25:05 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 108285 invoked by uid 89); 31 Jul 2017 10:25:04 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=mistaken
X-HELO: sasl.smtp.pobox.com
Received: from pb-smtp2.pobox.com (HELO sasl.smtp.pobox.com) (64.147.108.71) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 31 Jul 2017 10:25:02 +0000
Received: from sasl.smtp.pobox.com (unknown [127.0.0.1])	by pb-smtp2.pobox.com (Postfix) with ESMTP id 620B599DE5;	Mon, 31 Jul 2017 06:24:58 -0400 (EDT)
Received: from pb-smtp2.nyi.icgroup.com (unknown [127.0.0.1])	by pb-smtp2.pobox.com (Postfix) with ESMTP id 59A3399DE4;	Mon, 31 Jul 2017 06:24:58 -0400 (EDT)
Received: from [192.168.1.4] (unknown [76.215.41.237])	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))	(No client certificate requested)	by pb-smtp2.pobox.com (Postfix) with ESMTPSA id 99A7099DE2;	Mon, 31 Jul 2017 06:24:57 -0400 (EDT)
From: Daniel Santos <daniel.santos@pobox.com>
Subject: Re: [PING] [PATCH v4 0/12] [i386] Improve 64-bit Microsoft to System V ABI pro/epilogues
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: Uros Bizjak <ubizjak@gmail.com>, gcc-patches <gcc-patches@gcc.gnu.org>
References: <49e81c0b-07a4-22df-d7c3-2439177ac7cf@pobox.com> <08ca9667-0844-13a9-890b-a2c7092e060a@pobox.com> <CAFULd4bFuNx6hJAEcn1zz30yCaDV6Xn_Z2ssJ2TsA3Su4hcJ0A@mail.gmail.com> <62ed3cf1-bc4d-a989-4423-e47017d255e4@pobox.com> <CAFULd4bsXQKeoBUfgM04vH_1LsDe+NPJLLJDMh5AQWcE7Zo80Q@mail.gmail.com> <CAMe9rOpcte-DEWeZ5QzUbXgTVTWkQ70rzOo+BB3r065=NXB-tA@mail.gmail.com> <27aa9300-78a6-f1c3-d025-aa43fdcbc6a3@pobox.com> <CAMe9rOqaMZNOcwtQ=0yyoBFkMAqwL_Mq7sh75bB8ys4YExZjvA@mail.gmail.com>
Message-ID: <d557b9f3-7637-28e4-1542-bf1e05388b22@pobox.com>
Date: Mon, 31 Jul 2017 10:25:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0
MIME-Version: 1.0
In-Reply-To: <CAMe9rOqaMZNOcwtQ=0yyoBFkMAqwL_Mq7sh75bB8ys4YExZjvA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Pobox-Relay-ID: 80908012-75DA-11E7-8D99-9D2B0D78B957-06139138!pb-smtp2.pobox.com
X-IsSubscribed: yes
X-SW-Source: 2017-07/txt/msg02003.txt.bz2

On 07/28/2017 09:41 AM, H.J. Lu wrote:
> On Fri, Jul 28, 2017 at 6:57 AM, Daniel Santos<daniel.santos@pobox.com>  wrote:
>> On 07/26/2017 02:03 PM, H.J. Lu wrote:
>>> This patch caused:
>>>
>>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81563
>> Hello.  I've rebased my patch set and I'm now retesting.  I'm afraid that
>> your changes are wrong because my my sp_valid_at and fp_valid_at functions
>> are wrong -- these are supposed to be for the base offset and not the CFA
>> offset, sorry about that.  This means that the check in choose_basereg (and
>> thus choose_baseaddr) have been wrong as well.  I'm retesting now.
> Please check your change with gcc.target/i386/pr81563.c.
>
> Thanks.

I'm still getting used to x86 stack math and and briefly I thought that 
my understanding of the CFA was wrong and that I had messed up 
sp_valid_at and fp_valid_at, but I was mistaken, so sorry for the false 
alarm.  My rebased patches pass all tests, so it's OK.