public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: JunMa <JunMa@linux.alibaba.com>
To: gcc-patches <gcc-patches@gcc.gnu.org>
Cc: Iain Sandoe <iain@sandoe.co.uk>, Nathan Sidwell <nathan@acm.org>
Subject: Re: [PING PATCH coroutines] Set side effects flag for BIND_EXPR which build in maybe_promote_captured_temps
Date: Thu, 27 Feb 2020 02:17:00 -0000	[thread overview]
Message-ID: <d567541b-d7fe-d8e0-d7a7-d440a05b38de@linux.alibaba.com> (raw)
In-Reply-To: <8108a8fc-3ea4-6a3d-d018-5d8d3755cf5b@linux.alibaba.com>

在 2020/2/11 上午10:50, JunMa 写道:
Hi
kindly ping~

Regards
JunMa
> Hi
> As title. in maybe_promote_captured_temps, we promote captured 
> temporaries
> and co_await_expr into a new BIND_EXPR. As the BIND_EXPR contains
> co_await_expr and maybe other function calls, the side effects flag 
> should
> be set.
>
> This patch fix one mismatch in cppcoro, the testcase comes from cppcoro
> and is reduced by creduce.
>
> Bootstrap and test on X86_64, is it OK?
>
> Regards
> JunMa
>
> gcc/cp
> 2020-02-11  Jun Ma <JunMa@linux.alibaba.com>
>
>         * coroutines.cc (maybe_promote_captured_temps): Set side effects
>         flag for BIND_EXPR.
>
> gcc/testsuite
> 2020-02-11  Jun Ma <JunMa@linux.alibaba.com>
>
>         * g++.dg/coroutines/torture/lambda-10-co-await-lambda.C: New 
> test.


  parent reply	other threads:[~2020-02-27  2:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-11  2:50 [PATCH " JunMa
2020-02-11  8:45 ` JunMa
2020-02-27  2:17 ` JunMa [this message]
2020-03-05 11:55   ` [PING PATCH " JunMa
2020-03-05 13:52     ` Iain Sandoe
2020-03-06  5:44       ` JunMa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d567541b-d7fe-d8e0-d7a7-d440a05b38de@linux.alibaba.com \
    --to=junma@linux.alibaba.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=iain@sandoe.co.uk \
    --cc=nathan@acm.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).