From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by sourceware.org (Postfix) with ESMTPS id F2B2E3850432 for ; Fri, 23 Jul 2021 16:29:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F2B2E3850432 Received: by mail-pl1-x62d.google.com with SMTP id e14so3756702plh.8 for ; Fri, 23 Jul 2021 09:29:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=FW8UNEh/4YIIK4ENR/llnV22XUFNg8x4lAP6/2uACCs=; b=ADsos6TdBjPspdMfPuas6ytNgu+aUU2MR5mXsfMYJA+48i5CJKJNTAesWYaK621nl4 ad8gaXhJ7MRSa7R03AyQ1OQXgh7njj/3o0jo2eO5LPj8N2fY4oy2HtC7ogs7qP/b6YaH 9QYqtGwj5e3x2gcGml3PTxNW9ljmFMzsErOaFnJhXgbQ4n8GkU1sbc4y+QMWmltRjAcg oX9bBO1ImHX08GT42nkY2WYh2ULhJ/kIzXzN+CZZIp1gNX65G/3ZM2C0cX9l22chVYFq DHkqqGruaAbmVc/AhmY+ewXKhG5KGceL94d3otJQZcXbdDn3dXVbQ7N//QTDGKrcPzjW 63hQ== X-Gm-Message-State: AOAM533FjelaPZWDQhxrCqyzNS77Y0T+1HdL+p3GfEhKnYEGdRPXXQsP iTqC1I3iGWwM+eBd5WvUTrbQ3PWKT5FtHg== X-Google-Smtp-Source: ABdhPJxyBBnNjViLIoqXStjQup2lGeMOfbsfxieURbc3tWpDhz88bYWKu7VxDHwBAvomNsK47Tnwkw== X-Received: by 2002:a05:6a00:1582:b029:333:a366:fe47 with SMTP id u2-20020a056a001582b0290333a366fe47mr5366372pfk.0.1627057783994; Fri, 23 Jul 2021 09:29:43 -0700 (PDT) Received: from [192.168.1.17] (c-98-202-48-222.hsd1.ut.comcast.net. [98.202.48.222]) by smtp.gmail.com with ESMTPSA id a24sm29121442pgj.12.2021.07.23.09.29.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 23 Jul 2021 09:29:43 -0700 (PDT) Subject: Re: 0001-Don-t-skip-prologue-instructions-as-it-could-affect-.patch To: "bin.cheng" , GCC Patches References: From: Jeff Law Message-ID: Date: Fri, 23 Jul 2021 10:29:40 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jul 2021 16:29:47 -0000 On 7/14/2021 3:14 AM, bin.cheng via Gcc-patches wrote: > Hi, > I ran into a wrong code bug in code with deep template instantiation when working on sdx::simd. > The root cause as described in commit summary is we skip prologue insns in init_alias_analysis. > This simple patch fixes the issue, however, it's hard to reduce a case because of heavy use of > templates. > Bootstrap and test on x86_64, is it OK? It's a clear correctness improvement, but what's unclear to me is why we'd want to skip them in the epilogue either. Jeff