From: Vineet Gupta <vineetg@rivosinc.com>
To: Jeff Law <jeffreyalaw@gmail.com>, Palmer Dabbelt <palmer@dabbelt.com>
Cc: gcc-patches@gcc.gnu.org, gnu-toolchain@rivosinc.com
Subject: Re: [PATCH] RISC-V: fix TARGET_PROMOTE_FUNCTION_MODE hook for libcalls
Date: Tue, 31 Oct 2023 18:37:58 -0700 [thread overview]
Message-ID: <d5889396-8d84-488b-aaa6-4a2cc4948c56@rivosinc.com> (raw)
In-Reply-To: <4f1c8ccd-1232-43aa-a289-1717bc4d0fef@gmail.com>
On 10/31/23 17:51, Jeff Law wrote:
>>>
>>
>> We also have a non-orthogonality in the ABI sign extension rules
>> between SI and DI, a few of us were talking about it on the internal
>> slack (though the specifics were for a different patch, Vineet has a
>> few in flight).
> So the old issue I was thinking of really only affects targets that
> push arguments on the stack and when a sub-word push actually
> allocates a full word on the stack (m68k, but !coldfire, h8 and
> probably others of that era).
>
> Point being, those issues don't apply here.
OK, I think Palmer was conflating this with the discussion in other
thread/patch.
-Vineet
next prev parent reply other threads:[~2023-11-01 1:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 18:35 Vineet Gupta
2023-10-31 23:18 ` Jeff Law
2023-10-31 23:41 ` Palmer Dabbelt
2023-11-01 0:51 ` Jeff Law
2023-11-01 1:37 ` Vineet Gupta [this message]
2023-11-01 19:11 ` Jeff Law
2023-11-01 19:19 ` Vineet Gupta
2023-11-01 21:24 ` Patrick O'Neill
2023-11-01 21:51 ` [[Committed]] " Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5889396-8d84-488b-aaa6-4a2cc4948c56@rivosinc.com \
--to=vineetg@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gnu-toolchain@rivosinc.com \
--cc=jeffreyalaw@gmail.com \
--cc=palmer@dabbelt.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).