From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 4F405385E445 for ; Fri, 15 Mar 2024 20:34:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4F405385E445 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4F405385E445 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710534894; cv=none; b=D9XsMMmUOVbfC1eRzqghO+TmgC1KOa0z7i6PlW923WwmazMmY/Hx0rMRPM2rFjUrP3dnEBxT70umCH6s+ICCZ2XcCbEVacjVCzrk7utwTq6nxcIONX5+ZRHqnSAtEfh/cJ1ZJ/jSuX2VkkoYnPAf7HqRt3rolTxgYkKJ68uHs08= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710534894; c=relaxed/simple; bh=AJ5F4oviDxJ8BXdQ4S6qJhIWgubuKbGMq4usT704gS4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Kt0709/wpGvR7pWeCfSRZzwTJPOGEgXt21umTezLW3jBhBcmZzIjBTMYDNzQEUjrjAZ69YFv0InQSigzxtnaM5dXf/xYsFIqGy1+3JauRJ9WaRzIEBTJnm2MzWjIIKOxhutV/f07OaXpIZPVe8/vRQXQM6Z9llhSssW/QvzlkTk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42FKNMxG005368; Fri, 15 Mar 2024 20:34:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=UuQMqiBfMRTM6Cvo8JEN9eRewn2IrKUefWvMW/4YynQ=; b=ouDOk8T8WoCsJNg3HTgFKC1tmL3hYRhGs0rwxAkVSeFp14LIFeRhfcjfk/U3FAaO4sfD 5hwFpVeyeyiIgtpNEhY1PzE+5xlIF/ezWoGkY8xp8EusPtVYXgMyCTQiCqKo36xfnSnw cdgC+dZAvkcTBxD49Cg8vZebNJ+8t4CdXyvRbS63xB6zbptshqyxq+/8zjYouWJNuL0T rcttWokWTVENgFEZZ23XjLag8BaQAiQ+wWNnL/HvZkc4RdD/gc9kPQ6JPtWFRSU1wo4p RJ/H/idFxH9D2jiHR3hrhoC8WC6nBHWVL3mo3W5BFlSrQMJagmplLPQqvrcMVPbg0ePI 7g== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3wvved8py0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Mar 2024 20:34:51 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 42FJMovw026843; Fri, 15 Mar 2024 20:34:50 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3wvsydh8qb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Mar 2024 20:34:50 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 42FKYlf115008422 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 15 Mar 2024 20:34:49 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CAAF358055; Fri, 15 Mar 2024 20:34:47 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2A1715804B; Fri, 15 Mar 2024 20:34:47 +0000 (GMT) Received: from [9.61.153.201] (unknown [9.61.153.201]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Fri, 15 Mar 2024 20:34:47 +0000 (GMT) Message-ID: Date: Fri, 15 Mar 2024 15:34:46 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3] rs6000: Don't ICE when compiling the __builtin_vsx_splat_2di built-in [PR113950] Content-Language: en-US To: "Kewen.Lin" , jeevitha Cc: GCC Patches , Segher Boessenkool , Michael Meissner References: From: Peter Bergner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: kWQQWsPyqs2dELx9-s7uYCAKiCYPJWTY X-Proofpoint-GUID: kWQQWsPyqs2dELx9-s7uYCAKiCYPJWTY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-15_07,2024-03-15_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 phishscore=0 malwarescore=0 clxscore=1011 bulkscore=0 adultscore=0 priorityscore=1501 lowpriorityscore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2403140000 definitions=main-2403150164 X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/6/24 3:27 AM, Kewen.Lin wrote: > on 2024/3/4 02:55, jeevitha wrote: >> The following patch has been bootstrapped and regtested on powerpc64le-linux. >> >> When we expand the __builtin_vsx_splat_2di function, we were allowing immediate >> value for second operand which causes an unrecognizable insn ICE. Even though >> the immediate value was forced into a register, it wasn't correctly assigned >> to the second operand. So corrected the assignment of op1 to operands[1]. [snip] > As the discussions in the thread of the previous versions, I think > Segher agreed this approach, so OK for trunk with the above nits > tweaked, thanks! The bogus vsx_splat_ code goes all the way back to GCC 8, so we should backport this fix. Segher and Ke Wen, can we get an approval to backport this to all the open release branches (GCC 13, 12, 11)? Thanks. Jeevitha, once we get approval, please perform the backports. Peter