From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 945EB3856973 for ; Fri, 19 May 2023 16:51:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 945EB3856973 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-64d3fdcadb8so294677b3a.3 for ; Fri, 19 May 2023 09:51:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684515073; x=1687107073; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NxZ7LY5412v1liQnRb4/XkfcXtAT04oTQJjQ4Sh10kc=; b=A460gk7TxGIhv0I2nq8VSkdaRPir+Hs4keOFKbqQu9vrg2i513NtQ3ndAiYPR/FOJo JOJVUT5iO34GYzelC8zKi7ZQYAB5f5agGO4l3wvvMZjEah+4ubzZicFfFPI+opUQ6HZH WpJjNoKHo/BHhr1YQfsvFsPMDmB2YuXRweGAEC/Rl0As6BLd1mpqHv59/HlczN5qFL/z pNFHI8+Mu+VIAzIH7bhgHpeGHGXKhtfPZCSGYd0IwSh2JPlwOiJChZsdXoBttMmcYaJ9 09GoTtPL0qLpSPB3OPALiW3Xj9I2/zuxxw5NIFtYAF0hsvdEqbSJzXWyBXJqZF+vLdao iiVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684515073; x=1687107073; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NxZ7LY5412v1liQnRb4/XkfcXtAT04oTQJjQ4Sh10kc=; b=jXklmVpk2VBAL/cp4Z2kuT21Az7D3qLXMpluI0zo+PXizfiV+bSaujBC9SGCEnymeE w17/9dP/CHw/DYVPSwjS5AOPdw0csACGP3DZbUgPgeBwsZxSs0p7PnlBh60dTeOhjvxH t3+lwW+WOoqRTR9+2V+P8W12+4lDIdJOjl2Q0Yy1o4gy4slltgtqzBVL0v5vDJq71G4a CND98N1vDa3rGciZgI6HIpqQiL7cADnDYmwy50GthmHIBocjgSZK92PRnoBGpBJuSHaq OJL9+XyNBaARgLihdReQYKT3OPZKePEz1WzvMLHpuWlKPKHWFcdFlDWbvZy099qxXjmh CN5w== X-Gm-Message-State: AC+VfDwMLy/JLF+uvTPPa3P3iJ1WA95sEWzHLGt9v1Zc8ntpVFOC+O4S Zz9ziIaA7ymMYoVUo0fBzAM= X-Google-Smtp-Source: ACHHUZ6X3J63CPo6ks6ZjdeQABJBA3pqQRK/d5MyNyQsYruvDw9phyv97s3HhVtEaDx5wFZuWyx3WQ== X-Received: by 2002:a05:6a00:1896:b0:646:6d5e:1d25 with SMTP id x22-20020a056a00189600b006466d5e1d25mr4296468pfh.16.1684515073456; Fri, 19 May 2023 09:51:13 -0700 (PDT) Received: from ?IPV6:2601:681:8d00:265::f0a? ([2601:681:8d00:265::f0a]) by smtp.gmail.com with ESMTPSA id j22-20020aa79296000000b0063d44634d8csm3183553pfa.71.2023.05.19.09.51.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 May 2023 09:51:12 -0700 (PDT) Message-ID: Date: Fri, 19 May 2023 10:51:11 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH] avr: Set param_min_pagesize to 0 [PR105523] Content-Language: en-US To: Bernhard Reutner-Fischer , SenthilKumar.Selvaraj@microchip.com, "SenthilKumar.Selvaraj--- via Gcc-patches" , richard.guenther@gmail.com Cc: chertykov@gmail.com References: <8089B1FC-D297-4D78-B11D-6FBB4A7CFFBF@microchip.com> <92A00825-A5ED-4AAC-925E-117B5D9422FF@gmail.com> From: Jeff Law In-Reply-To: <92A00825-A5ED-4AAC-925E-117B5D9422FF@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/19/23 08:02, Bernhard Reutner-Fischer via Gcc-patches wrote: > On 19 May 2023 07:58:48 CEST, "SenthilKumar.Selvaraj--- via Gcc-patches" wrote: > > Just a nit: > >> +static bool >> +avr_addr_space_zero_address_valid (addr_space_t as ATTRIBUTE_UNUSED) >> +{ >> + return flag_delete_null_pointer_checks == 0; >> +} > > Since we are c++ nowadays, you can omit the parameter name for unused arguments. I.e.: > > static bool > avr_addr_space_zero_address_valid (addr_space_t) > { Right. And I strongly prefer that over ATTRIBUTE_UNUSED. So OK for the trunk with that change. jeff