From: Jason Merrill <jason@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [C++ PATCH] Constexpr fold even some TREE_CONSTANT ctors (PR c++/87934)
Date: Tue, 18 Dec 2018 22:40:00 -0000 [thread overview]
Message-ID: <d5c024a2-e11c-fd88-ad8b-a5bfad0b4932@redhat.com> (raw)
In-Reply-To: <20181218204517.GS23305@tucnak>
On 12/18/18 3:45 PM, Jakub Jelinek wrote:
> The following testcase FAILs, because parsing creates a TREE_CONSTANT
> CONSTRUCTOR that contains CONST_DECL elts. cp_fold_r can handle that,
> but constexpr evaluation doesn't touch those CONSTRUCTORs.
>
> Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for
> trunk?
OK. I also wonder if store_init_value should use cp_fold_r rather than
just cp_fully_fold.
Jason
next prev parent reply other threads:[~2018-12-18 22:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 20:45 Jakub Jelinek
2018-12-18 22:40 ` Jason Merrill [this message]
2018-12-18 23:19 ` Jakub Jelinek
2018-12-19 3:28 ` Jason Merrill
2018-12-19 23:14 ` Jakub Jelinek
2018-12-20 16:01 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5c024a2-e11c-fd88-ad8b-a5bfad0b4932@redhat.com \
--to=jason@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).